git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Matheus Tavares <matheus.bernardino@usp.br>, git@vger.kernel.org
Cc: gitster@pobox.com, avarab@gmail.com
Subject: Re: [PATCH v2 0/2] format-patch: warn if commit msg contains a patch delimiter
Date: Wed, 7 Sep 2022 19:44:25 +0200	[thread overview]
Message-ID: <05a52191-89b0-eb55-e6bc-1ed2642842de@web.de> (raw)
In-Reply-To: <cover.1662559356.git.matheus.bernardino@usp.br>

Am 07.09.22 um 16:44 schrieb Matheus Tavares:
> This makes format-patch warn on strings like "---" and "-- >8 --", which
> can make a later git am fail to properly apply the generated patch.
>
> Changes in v2:
> - Use heredoc in tests.
> - Add internationalization _()
> - Incorporate René changes to use a buf/size pair.
>
> René, I added your changes from [1] as a preparatory patch. Please let
> me know if you are OK with that so that I can add your SoB in the next
> re-roll.

Fine with me, but I think they are trivial and you don't actually need my
sign-off.

René

      parent reply	other threads:[~2022-09-07 17:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04 23:12 [PATCH] format-patch: warn if commit msg contains a patch delimiter Matheus Tavares
2022-09-05  8:01 ` Ævar Arnfjörð Bjarmason
2022-09-05 10:57   ` René Scharfe
2022-09-07 14:44   ` [PATCH v2 0/2] " Matheus Tavares
2022-09-07 14:44     ` [PATCH v2 1/2] patchbreak(), is_scissors_line(): work with a buf/len pair Matheus Tavares
2022-09-07 18:20       ` Phillip Wood
2022-09-08  0:35       ` Eric Sunshine
2022-09-07 14:44     ` [PATCH v2 2/2] format-patch: warn if commit msg contains a patch delimiter Matheus Tavares
2022-09-07 18:09       ` Phillip Wood
2022-09-07 18:36         ` Junio C Hamano
2022-09-09  1:08           ` Matheus Tavares
2022-09-09 16:47             ` Junio C Hamano
2022-09-07 17:44     ` René Scharfe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05a52191-89b0-eb55-e6bc-1ed2642842de@web.de \
    --to=l.s.r@web.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=matheus.bernardino@usp.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).