* [PATCH] trace2: use warning() directly in tr2_dst_malformed_warning()
@ 2019-08-25 17:44 René Scharfe
2019-09-04 9:14 ` Jeff Hostetler
0 siblings, 1 reply; 2+ messages in thread
From: René Scharfe @ 2019-08-25 17:44 UTC (permalink / raw)
To: Git Mailing List; +Cc: Jeff Hostetler, Junio C Hamano
Let warning() format the message instead of using an intermediate strbuf
for that. This is shorter, easier to read and avoids an allocation.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
trace2/tr2_dst.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/trace2/tr2_dst.c b/trace2/tr2_dst.c
index 5dda0ca1cd..c69857515f 100644
--- a/trace2/tr2_dst.c
+++ b/trace2/tr2_dst.c
@@ -215,13 +215,8 @@ static int tr2_dst_try_unix_domain_socket(struct tr2_dst *dst,
static void tr2_dst_malformed_warning(struct tr2_dst *dst,
const char *tgt_value)
{
- struct strbuf buf = STRBUF_INIT;
-
- strbuf_addf(&buf, "trace2: unknown value for '%s': '%s'",
- tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
- warning("%s", buf.buf);
-
- strbuf_release(&buf);
+ warning("trace2: unknown value for '%s': '%s'",
+ tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
}
int tr2_dst_get_trace_fd(struct tr2_dst *dst)
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] trace2: use warning() directly in tr2_dst_malformed_warning()
2019-08-25 17:44 [PATCH] trace2: use warning() directly in tr2_dst_malformed_warning() René Scharfe
@ 2019-09-04 9:14 ` Jeff Hostetler
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Hostetler @ 2019-09-04 9:14 UTC (permalink / raw)
To: René Scharfe, Git Mailing List; +Cc: Jeff Hostetler, Junio C Hamano
On 8/25/2019 1:44 PM, René Scharfe wrote:
> Let warning() format the message instead of using an intermediate strbuf
> for that. This is shorter, easier to read and avoids an allocation.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> trace2/tr2_dst.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/trace2/tr2_dst.c b/trace2/tr2_dst.c
> index 5dda0ca1cd..c69857515f 100644
> --- a/trace2/tr2_dst.c
> +++ b/trace2/tr2_dst.c
> @@ -215,13 +215,8 @@ static int tr2_dst_try_unix_domain_socket(struct tr2_dst *dst,
> static void tr2_dst_malformed_warning(struct tr2_dst *dst,
> const char *tgt_value)
> {
> - struct strbuf buf = STRBUF_INIT;
> -
> - strbuf_addf(&buf, "trace2: unknown value for '%s': '%s'",
> - tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
> - warning("%s", buf.buf);
> -
> - strbuf_release(&buf);
> + warning("trace2: unknown value for '%s': '%s'",
> + tr2_sysenv_display_name(dst->sysenv_var), tgt_value);
> }
>
> int tr2_dst_get_trace_fd(struct tr2_dst *dst)
> --
> 2.23.0
>
good catch! thanks!
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-04 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-25 17:44 [PATCH] trace2: use warning() directly in tr2_dst_malformed_warning() René Scharfe
2019-09-04 9:14 ` Jeff Hostetler
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).