From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: 'martin' <test2@mfriebe.de>,
"'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>
Cc: "'Felipe Contreras'" <felipe.contreras@gmail.com>,
"'Andreas Schwab'" <schwab@linux-m68k.org>, <git@vger.kernel.org>,
"'Junio C Hamano'" <gitster@pobox.com>
Subject: RE: [PATCH 5/5] config: add default aliases
Date: Fri, 2 Jul 2021 18:03:07 -0400 [thread overview]
Message-ID: <03cf01d76f8e$0d8cf620$28a6e260$@nexbridge.com> (raw)
In-Reply-To: <8f847f31-5c5d-0236-997c-bd07040f7ea7@mfriebe.de>
On July 2, 2021 10:44 AM, martin wrote:
>To: Randall S. Becker <rsbecker@nexbridge.com>; 'Ævar Arnfjörð Bjarmason' <avarab@gmail.com>
>Cc: 'Felipe Contreras' <felipe.contreras@gmail.com>; 'Andreas Schwab' <schwab@linux-m68k.org>; git@vger.kernel.org; 'Junio C
>Hamano' <gitster@pobox.com>
>Subject: Re: [PATCH 5/5] config: add default aliases
>
>On 02/07/2021 16:15, Randall S. Becker wrote:
>> On July 2, 2021 9:42 AM, Ævar Arnfjörð Bjarmason wrote:
>>> So aside from the "are these aliases good idea?" discussion, would
>>> you prefer if they're implemented that we theat them the exact same
>>> way we do "git fsck-objects" and "git fsck"? I.e. list them twice in git.c, just pointing to the same cmd_fsck?
>> Without knowing the full history of why the duplication, yes. That would be my preference. If it is a git command, it should be handled
>like one as closely as possible. Presumably, it also would show up in git help -a. I would not expect aliases to show in help.
>>
>But, if it is a git command, can you still overwrite it with your on alias?
>
>As it was pointed out, some of those are used by people as aliases for other things already.
If an alias overwrites/overrides a git command, I would expect NIST to have a proverbial cow and a CVE will be raised, probably by me.
Overriding base product functionality with something that does something other than what is documented is a highly questionable practice.
next prev parent reply other threads:[~2021-07-02 22:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 10:05 [PATCH 0/5] Default aliases Felipe Contreras
2021-07-02 10:05 ` [PATCH 1/5] test: add missing whitespaces Felipe Contreras
2021-07-02 10:05 ` [PATCH 2/5] config: trivial style fix Felipe Contreras
2021-07-02 10:05 ` [PATCH 3/5] config: trivial struct initialization cleanup Felipe Contreras
2021-07-02 10:05 ` [PATCH 4/5] config: initialize origin_type correctly Felipe Contreras
2021-07-02 10:05 ` [PATCH 5/5] config: add default aliases Felipe Contreras
2021-07-02 10:10 ` Andreas Schwab
2021-07-02 10:17 ` Felipe Contreras
2021-07-02 10:31 ` Andreas Schwab
2021-07-02 10:46 ` Felipe Contreras
2021-07-02 10:54 ` Andreas Schwab
2021-07-02 10:44 ` martin
2021-07-02 10:54 ` Felipe Contreras
2021-07-02 11:15 ` martin
2021-07-02 13:26 ` Randall S. Becker
2021-07-02 13:41 ` Ævar Arnfjörð Bjarmason
2021-07-02 14:15 ` Randall S. Becker
2021-07-02 14:43 ` martin
2021-07-02 20:44 ` Felipe Contreras
2021-07-02 22:03 ` Randall S. Becker [this message]
2021-07-02 22:32 ` Felipe Contreras
2021-07-02 15:39 ` Junio C Hamano
2021-07-02 20:41 ` Felipe Contreras
2021-07-02 21:02 ` Felipe Contreras
2021-07-02 21:40 ` martin
2021-07-02 22:16 ` Felipe Contreras
2021-07-02 22:00 ` Randall S. Becker
2021-07-02 22:31 ` Felipe Contreras
2021-07-02 21:12 ` Felipe Contreras
2021-07-02 21:31 ` martin
2021-07-02 22:14 ` Felipe Contreras
2021-07-02 11:32 ` Ævar Arnfjörð Bjarmason
2021-07-02 21:58 ` Felipe Contreras
2021-07-02 22:38 ` martin
2021-07-02 23:48 ` Felipe Contreras
2021-07-05 14:02 ` Randall S. Becker
2021-07-06 15:27 ` Randall S. Becker
2021-07-06 21:59 ` Felipe Contreras
2021-07-10 15:30 ` Philip Oakley
2021-07-03 10:50 ` Jeff King
2021-07-06 21:54 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03cf01d76f8e$0d8cf620$28a6e260$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=schwab@linux-m68k.org \
--cc=test2@mfriebe.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).