From: "Randall S. Becker" <email@example.com>
To: "'martin'" <firstname.lastname@example.org>,
"'Felipe Contreras'" <email@example.com>,
"'Andreas Schwab'" <firstname.lastname@example.org>
"'Ævar Arnfjörð Bjarmason'" <email@example.com>,
"'Junio C Hamano'" <firstname.lastname@example.org>
Subject: RE: [PATCH 5/5] config: add default aliases
Date: Fri, 2 Jul 2021 09:26:30 -0400 [thread overview]
Message-ID: <email@example.com> (raw)
On July 2, 2021 7:15 AM, martin wrote:
>On 02/07/2021 12:54, Felipe Contreras wrote:
>> martin wrote:
>>> IMHO it would be good to (partly) follow other vcs, and have commit =
>> I'm fine with leaving co out of the default aliases if it's deemed
>> "too controversial".
>> But ci doesn't make sense. ci comes from "check in" which has no
>> similitude in git.
>svn uses it for "commit".
>It can be seen as CommIt.
>But of course other letters can be picked. I don't see an advantage in it though.
>Like CoMmit cm ? or CommiT ct ? None of them seems any better to me.
>> I don't think it's a good idea to leave "git checkout" without an
>> alias (it's perhaps the second or third most used command), but at
>> least some aliases are better than no aliases.
>Well, that goes back to a bigger question. And from the brief time I have been on this mail list, it appears to me there is a divide into 2
>If checkout is really meant to give way to switch/restore then it needs no further advertising. And then the current usage statistics are a
>relict from the before switch/restore time.
>If on the other hand checkout is not just to be kept for backward compatibility, but should always remain an equal alternative to
>switch/restore (i.e. it should still be taught to new user in 20 years) then it wants to have a default alias.
In my opinion, default aliases are not a good path. If a command is intended to be part of the git command set, then it should be a builtin not an alias. Users have their own alias setups and implied conflicts are just going to be confusing and end up in help, examples, presentations, and so forth.
If you want a default alias set, publish it as part of an extension set, like the bash-completion, so that the user has to take action to install them in their environment. Do not do this in the base git product by default.
Further, if you are deprecating a command like checkout (which I know is not happening), then the command should go away rather than become an alias, unless a specific user wants to include this. That's what deprecation is. Keeping it around as an alias means you are keeping it around as a command, just providing a new access path.
If I was a committer on this project, I would have to be much more convinced that there is long-term value in this series than appears on the surface.
I am sorry if I am coming across too strongly on this subject, but I do think we are overloading alias capability and intruding on a domain that should be reserved for our users, not ourselves.
next prev parent reply other threads:[~2021-07-02 13:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 10:05 [PATCH 0/5] Default aliases Felipe Contreras
2021-07-02 10:05 ` [PATCH 1/5] test: add missing whitespaces Felipe Contreras
2021-07-02 10:05 ` [PATCH 2/5] config: trivial style fix Felipe Contreras
2021-07-02 10:05 ` [PATCH 3/5] config: trivial struct initialization cleanup Felipe Contreras
2021-07-02 10:05 ` [PATCH 4/5] config: initialize origin_type correctly Felipe Contreras
2021-07-02 10:05 ` [PATCH 5/5] config: add default aliases Felipe Contreras
2021-07-02 10:10 ` Andreas Schwab
2021-07-02 10:17 ` Felipe Contreras
2021-07-02 10:31 ` Andreas Schwab
2021-07-02 10:46 ` Felipe Contreras
2021-07-02 10:54 ` Andreas Schwab
2021-07-02 10:44 ` martin
2021-07-02 10:54 ` Felipe Contreras
2021-07-02 11:15 ` martin
2021-07-02 13:26 ` Randall S. Becker [this message]
2021-07-02 13:41 ` Ævar Arnfjörð Bjarmason
2021-07-02 14:15 ` Randall S. Becker
2021-07-02 14:43 ` martin
2021-07-02 20:44 ` Felipe Contreras
2021-07-02 22:03 ` Randall S. Becker
2021-07-02 22:32 ` Felipe Contreras
2021-07-02 15:39 ` Junio C Hamano
2021-07-02 20:41 ` Felipe Contreras
2021-07-02 21:02 ` Felipe Contreras
2021-07-02 21:40 ` martin
2021-07-02 22:16 ` Felipe Contreras
2021-07-02 22:00 ` Randall S. Becker
2021-07-02 22:31 ` Felipe Contreras
2021-07-02 21:12 ` Felipe Contreras
2021-07-02 21:31 ` martin
2021-07-02 22:14 ` Felipe Contreras
2021-07-02 11:32 ` Ævar Arnfjörð Bjarmason
2021-07-02 21:58 ` Felipe Contreras
2021-07-02 22:38 ` martin
2021-07-02 23:48 ` Felipe Contreras
2021-07-05 14:02 ` Randall S. Becker
2021-07-06 15:27 ` Randall S. Becker
2021-07-06 21:59 ` Felipe Contreras
2021-07-10 15:30 ` Philip Oakley
2021-07-03 10:50 ` Jeff King
2021-07-06 21:54 ` Felipe Contreras
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).