From: Lessley Dennington <lessleydennington@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Lessley Dennington via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, stolee@gmail.com, newren@gmail.com,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v4 2/4] test-read-cache: set up repo after git directory
Date: Wed, 24 Nov 2021 07:10:33 -0800 [thread overview]
Message-ID: <0372ee0b-8dda-c505-2b83-30da74e4fb36@gmail.com> (raw)
In-Reply-To: <xmqq4k82781w.fsf@gitster.g>
On 11/23/21 3:42 PM, Junio C Hamano wrote:
> "Lessley Dennington via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
>> From: Lessley Dennington <lessleydennington@gmail.com>
>>
>> Move repo setup to occur after git directory is set up. This will ensure
>> enabling the sparse index for `diff` (and guarding against the nongit
>> scenario) will not cause tests to start failing, since that change will include
>> adding a check to prepare_repo_settings() with the new BUG.
>
> This looks obviously the right thing to do. Would anything break
> because of the "wrong" ordering of events in the original code?
>
> IOW, can this "bugfix" be protected with a new test against
> regression?
>
Yep! Tests 2, 3, 28, and 34 in t1092-sparse-checkout-compatibility.sh
will fail without this change.
>> Signed-off-by: Lessley Dennington <lessleydennington@gmail.com>
>> ---
>> t/helper/test-read-cache.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/t/helper/test-read-cache.c b/t/helper/test-read-cache.c
>> index b52c174acc7..0d9f08931a1 100644
>> --- a/t/helper/test-read-cache.c
>> +++ b/t/helper/test-read-cache.c
>> @@ -39,8 +39,6 @@ int cmd__read_cache(int argc, const char **argv)
>> int table = 0, expand = 0;
>>
>> initialize_the_repository();
>> - prepare_repo_settings(r);
>> - r->settings.command_requires_full_index = 0;
>>
>> for (++argv, --argc; *argv && starts_with(*argv, "--"); ++argv, --argc) {
>> if (skip_prefix(*argv, "--print-and-refresh=", &name))
>> @@ -56,6 +54,9 @@ int cmd__read_cache(int argc, const char **argv)
>> setup_git_directory();
>> git_config(git_default_config, NULL);
>>
>> + prepare_repo_settings(r);
>> + r->settings.command_requires_full_index = 0;
>> +
>> for (i = 0; i < cnt; i++) {
>> repo_read_index(r);
next prev parent reply other threads:[~2021-11-24 15:10 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 17:25 [PATCH 0/2] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-10-14 17:25 ` [PATCH 1/2] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-10-15 16:46 ` Derrick Stolee
2021-10-14 17:25 ` [PATCH 2/2] blame: " Lessley Dennington via GitGitGadget
2021-11-23 7:57 ` Elijah Newren
2021-11-23 14:57 ` Lessley Dennington
2021-10-15 21:20 ` [PATCH v2 0/2] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-10-15 21:20 ` [PATCH v2 1/2] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-10-25 20:47 ` Taylor Blau
2021-10-26 16:10 ` Lessley Dennington
2021-10-26 16:15 ` Taylor Blau
2021-10-15 21:20 ` [PATCH v2 2/2] blame: " Lessley Dennington via GitGitGadget
2021-10-25 20:53 ` Taylor Blau
2021-10-26 16:17 ` Lessley Dennington
2021-11-21 1:32 ` Elijah Newren
2021-11-01 21:27 ` [PATCH v3 0/2] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-11-01 21:27 ` [PATCH v3 1/2] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-11-03 17:05 ` Junio C Hamano
2021-11-04 23:55 ` Lessley Dennington
2021-11-01 21:27 ` [PATCH v3 2/2] blame: " Lessley Dennington via GitGitGadget
2021-11-03 16:47 ` Junio C Hamano
2021-11-05 0:04 ` Lessley Dennington
2021-11-21 1:46 ` Elijah Newren
2021-11-22 22:42 ` [PATCH v4 0/4] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-11-22 22:42 ` [PATCH v4 1/4] sparse index: enable only for git repos Lessley Dennington via GitGitGadget
2021-11-23 7:41 ` Elijah Newren
2021-11-23 14:52 ` Lessley Dennington
2021-11-23 23:39 ` Junio C Hamano
2021-11-24 14:41 ` Lessley Dennington
2021-11-24 18:23 ` Junio C Hamano
2021-11-29 23:38 ` Lessley Dennington
2021-11-30 6:32 ` Junio C Hamano
2021-11-30 23:25 ` Lessley Dennington
2021-11-22 22:42 ` [PATCH v4 2/4] test-read-cache: set up repo after git directory Lessley Dennington via GitGitGadget
2021-11-23 23:42 ` Junio C Hamano
2021-11-24 15:10 ` Lessley Dennington [this message]
2021-11-24 18:36 ` Junio C Hamano
2021-11-29 23:01 ` Lessley Dennington
2021-11-22 22:42 ` [PATCH v4 3/4] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-11-23 7:47 ` Elijah Newren
2021-11-23 14:53 ` Lessley Dennington
2021-11-23 23:48 ` Junio C Hamano
2021-11-22 22:42 ` [PATCH v4 4/4] blame: " Lessley Dennington via GitGitGadget
2021-11-23 23:53 ` Junio C Hamano
2021-11-24 14:52 ` Lessley Dennington
2021-12-03 21:15 ` [PATCH v5 0/7] Sparse Index: diff and blame builtins Lessley Dennington via GitGitGadget
2021-12-03 21:15 ` [PATCH v5 1/7] git: esnure correct git directory setup with -h Lessley Dennington via GitGitGadget
2021-12-04 18:41 ` Elijah Newren
2021-12-04 19:58 ` Junio C Hamano
2021-12-03 21:16 ` [PATCH v5 2/7] commit-graph: return if there is no git directory Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 3/7] test-read-cache: set up repo after " Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 4/7] repo-settings: prepare_repo_settings only in git repos Lessley Dennington via GitGitGadget
2021-12-07 4:43 ` Ævar Arnfjörð Bjarmason
2021-12-08 15:46 ` Lessley Dennington
2021-12-03 21:16 ` [PATCH v5 5/7] diff: replace --staged with --cached in t1092 tests Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 6/7] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-12-03 21:16 ` [PATCH v5 7/7] blame: " Lessley Dennington via GitGitGadget
2021-12-04 19:43 ` [PATCH v5 0/7] Sparse Index: diff and blame builtins Elijah Newren
2021-12-06 15:55 ` [PATCH v6 " Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 1/7] git: ensure correct git directory setup with -h Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 2/7] commit-graph: return if there is no git directory Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 3/7] test-read-cache: set up repo after " Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 4/7] repo-settings: prepare_repo_settings only in git repos Lessley Dennington via GitGitGadget
2021-12-06 15:55 ` [PATCH v6 5/7] diff: replace --staged with --cached in t1092 tests Lessley Dennington via GitGitGadget
2021-12-06 15:56 ` [PATCH v6 6/7] diff: enable and test the sparse index Lessley Dennington via GitGitGadget
2021-12-06 15:56 ` [PATCH v6 7/7] blame: " Lessley Dennington via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0372ee0b-8dda-c505-2b83-30da74e4fb36@gmail.com \
--to=lessleydennington@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).