From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: <git@vger.kernel.org>, "'Junio C Hamano'" <gitster@pobox.com>
Subject: Re: [ANNOUNCE] git-2.30.0-rc0 - Compile Fails on HPE NonStop
Date: Mon, 14 Dec 2020 18:12:03 -0500 [thread overview]
Message-ID: <035d01d6d26e$8c255260$a46ff720$@nexbridge.com> (raw)
2.30.0-rc0 fails to compile strmap.o, and probably others, since this is in
a header file:
"git-compat-util.h", line 277: warning(1252):
missing return statement at end of non-void function "setitimer"
return strmap_remove(&map->map, str, 0);
^
"strmap.h", line 168: error(210):
a void function may not return a value
return strmap_remove(&set->map, str, 0);
^
"strmap.h", line 252: error(210):
a void function may not return a value
Aside from inlining bodies, this should not have compiled on any platform:
static inline void strset_remove(struct strset *set, const char *str)
{
return strmap_remove(&set->map, str, 0);
}
What is really intended here?
Sorry,
Randall
-- Brief whoami:
NonStop developer since approximately 211288444200000000
UNIX developer since approximately 421664400
-- In my real life, I talk too much.
next reply other threads:[~2020-12-14 23:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 23:12 Randall S. Becker [this message]
2020-12-15 2:43 ` [ANNOUNCE] git-2.30.0-rc0 - Compile Fails on HPE NonStop Junio C Hamano
2020-12-15 2:52 ` Jeff King
2020-12-15 15:55 ` Randall S. Becker
2020-12-15 16:21 ` Elijah Newren
2020-12-15 21:07 ` Junio C Hamano
2020-12-15 21:08 ` Junio C Hamano
2020-12-15 21:25 ` [PATCH] strmap: make callers of strmap_remove() to call it in void context Junio C Hamano
2020-12-15 21:35 ` Randall S. Becker
2020-12-15 21:26 ` [PATCH] compat-util: pretend that stub setitimer() always succeeds Junio C Hamano
2020-12-15 21:37 ` [ANNOUNCE] git-2.30.0-rc0 - Compile Fails on HPE NonStop Jeff King
2020-12-16 17:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='035d01d6d26e$8c255260$a46ff720$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).