From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C20031F8C6 for ; Sat, 7 Aug 2021 09:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231684AbhHGJor (ORCPT ); Sat, 7 Aug 2021 05:44:47 -0400 Received: from bsmtp5.bon.at ([195.3.86.187]:47146 "EHLO bsmtp5.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231615AbhHGJoq (ORCPT ); Sat, 7 Aug 2021 05:44:46 -0400 X-Greylist: delayed 7476 seconds by postgrey-1.27 at vger.kernel.org; Sat, 07 Aug 2021 05:44:46 EDT Received: from bsmtp.bon.at (unknown [192.168.181.101]) by bsmtp5.bon.at (Postfix) with ESMTPS id 4GhXy63j5pz5vLr for ; Sat, 7 Aug 2021 08:49:18 +0200 (CEST) Received: from [192.168.1.103] (089144221092.atnat0030.highway.webapn.at [89.144.221.92]) by bsmtp.bon.at (Postfix) with ESMTPSA id 4GhXy12Ylrz5tl9; Sat, 7 Aug 2021 08:49:13 +0200 (CEST) Subject: Re: [PATCH] Revert 'diff-merges: let "-m" imply "-p"' To: Jonathan Nieder Cc: Junio C Hamano , Sergey Organov , Jeff King , Philip Oakley , Elijah Newren , Felipe Contreras , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Alex Henrie , huang guanlong , git@vger.kernel.org, Hudson Ayers , Taylor Yu , Joshua Nelson References: <20210520214703.27323-1-sorganov@gmail.com> <20210520214703.27323-11-sorganov@gmail.com> From: Johannes Sixt Message-ID: <035b4e99-e708-f31b-2f13-e255d99dea33@kdbg.org> Date: Sat, 7 Aug 2021 08:49:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 07.08.21 um 03:55 schrieb Jonathan Nieder: > The motivating example (Rust) shows that there is at least one script > that _did_ use "-m" in this way. Rust has mitigation, but the above > logic leads me to believe that they are not the only project that will > be affected. And more generally, when a script author has a > reasonable reason to believe something will work, they write scripts > where it _does_ work, and then an update breaks their script, I think > it's reasonable for them not to be happy. As you know, we have "plumbing" commands with a stable interface and "porcelain" commands for which we reserve to change the behavior without advance notice. By your reasoning we would not need to distinguish between the two categories and were forced to keep all behavior stable. This undoing of a behavior change in a "porcelain" command with the argument that one script depended on the old behavior and that others might do so as well would set an unwanted precedent. Perhaps we need to point script authors to "plumbing" commands more clearly? (BTW, I have no opinion on whether -m should or should not imply -p.) -- Hannes