From: <rsbecker@nexbridge.com>
To: "'Carlo Marcelo Arenas Belón'" <carenas@gmail.com>
Cc: "'Junio C Hamano'" <gitster@pobox.com>,
"'Git Mailing List'" <git@vger.kernel.org>,
<git-packagers@googlegroups.com>
Subject: RE: [ANNOUNCE] Git v2.36.0-rc0 - Build failure on NonStops
Date: Mon, 4 Apr 2022 22:59:54 -0400 [thread overview]
Message-ID: <035b01d84899$3cdc5b20$b6951160$@nexbridge.com> (raw)
In-Reply-To: <20220405005418.3s2zayr3dmpxg45q@carlos-mbp.lan>
On April 4, 2022 8:54 PM, Carlo Marcelo Arenas Belón wrote:
>On Mon, Apr 04, 2022 at 05:26:10PM -0700, Carlo Marcelo Arenas Belón wrote:
>> On Mon, Apr 04, 2022 at 06:40:35PM -0400, rsbecker@nexbridge.com wrote:
>> > On April 4, 2022 6:33 PM, Junio C Hamano wrote:
>> > >To: Randall S. Becker <rsbecker@nexbridge.com>
>> > >Cc: Git Mailing List <git@vger.kernel.org>;
>> > >git-packagers@googlegroups.com
>> > >Subject: Re: [ANNOUNCE] Git v2.36.0-rc0 - Build failure on NonStops
>> > >
>> > >CSPRNG_METHOD?
>> >
>> > We already have
>> >
>> > CSPRNG_METHOD = openssl
>> >
>> > In the config for NonStop. Should that not have worked?
>>
>> only if you are not telling your openssl to hide that function[1]
>>
>> Carlo
>>
>> [1] https://www.openssl.org/docs/manmaster/man3/RAND_bytes.html
>
>neverming, it seems we forgot to track this header somehow, so will need
>something like (untested and likely to need changes to support NO_OPENSSL)
>
>Carlo
>--- >8 ---
>diff --git a/git-compat-util.h b/git-compat-util.h index 4d444dca274..68a9b9cd975
>100644
>--- a/git-compat-util.h
>+++ b/git-compat-util.h
>@@ -525,6 +525,10 @@ void warning_errno(const char *err, ...)
>__attribute__((format (printf, 1, 2))); #include <openssl/x509v3.h> #endif /*
>NO_OPENSSL */
>
>+#ifdef HAVE_OPENSSL_CSPRNG
>+#include <openssl/rand.h>
>+#endif
>+
> /*
> * Let callers be aware of the constant return value; this can help
> * gcc with -Wuninitialized analysis. We restrict this trick to gcc, though,
I was able to make the build work, adding the above patch and libcrypto.so and libssl.so to our LDFLAGS. This patch is probably required. What confuses me somewhat is why RAND_bytes is required for anything in the fsync series, but it is what it is.
If there is a knob for force -lcrypto and -lssl in config.mak.uname, it would help. The CSPRNG_METHOD=openssl should be forcing these two libraries into the link, I would think. The DLLs do show up in other links, so I am suspecting there is an omission somewhere that includes the git-daemon link.
The test cycle has begun, but that will take at least 40 hours on an ia64 to get complete results.
--Randall
next prev parent reply other threads:[~2022-04-05 3:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 22:30 [ANNOUNCE] Git v2.36.0-rc0 - Build failure on NonStops rsbecker
2022-04-04 22:32 ` Junio C Hamano
2022-04-04 22:40 ` rsbecker
2022-04-05 0:26 ` Carlo Marcelo Arenas Belón
2022-04-05 0:54 ` Carlo Marcelo Arenas Belón
2022-04-05 2:59 ` rsbecker [this message]
2022-04-05 4:28 ` Carlo Marcelo Arenas Belón
2022-04-05 8:10 ` brian m. carlson
2022-04-05 22:47 ` Carlo Arenas
2022-04-05 23:09 ` rsbecker
2022-04-06 16:04 ` Junio C Hamano
2022-04-05 12:33 ` rsbecker
2022-04-05 1:56 ` rsbecker
2022-04-06 16:14 ` Junio C Hamano
2022-04-06 16:23 ` rsbecker
2022-04-06 19:37 ` Junio C Hamano
2022-04-06 22:32 ` rsbecker
2022-04-06 20:01 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='035b01d84899$3cdc5b20$b6951160$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=carenas@gmail.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).