From: "René Scharfe" <l.s.r@web.de>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2] strbuf: let strbuf_addftime handle %z and %Z itself
Date: Thu, 15 Jun 2017 14:28:22 +0200 [thread overview]
Message-ID: <02cf275a-8eaa-49b9-7c2a-f98424088e1e@web.de> (raw)
In-Reply-To: <22850.28477.715057.441985@a1i15.kph.uni-mainz.de>
Am 15.06.2017 um 13:27 schrieb Ulrich Mueller:
>>>>>> On Thu, 15 Jun 2017, René Scharfe wrote:
>
>> Callers can opt out for %Z by passing NULL as timezone name. %z is
>> always handled internally -- this helps on Windows, where strftime would
>> expand it to a timezone name (same as %Z), in violation of POSIX.
>> Modifiers are not handled, e.g. %Ez is still passed to strftime.
>
> POSIX would also allow other things, like a field width:
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html
>
> $ date '+%8z'
> +0000200
>
> (But I believe that's not very useful, and supporting it might require
> duplicating much of strftime's code.)
Windows doesn't support that (unsurprisingly), but it accepts %#z,
which does the same as %z. Let's wait for someone to request support
for modifiers and just document the behavior for now.
>> Changes from v1:
>> - Always handle %z internally.
>
> Minor nitpick: Shouldn't the comment in strbuf.h be updated to reflect
> that change?
>
>> + * Add the time specified by `tm`, as formatted by `strftime`. `tz_offset`
>> + * and `tz_name` are used to expand %z and %Z internally, unless `tz_name`
>> + * is NULL. `tz_offset` is in decimal hhmm format, e.g. -600 means six
>> + * hours west of Greenwich.
Yes, it should. Thanks for paying attention! :)
René
next prev parent reply other threads:[~2017-06-15 12:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 18:33 git-2.13.0: log --date=format:%z not working Ulrich Mueller
2017-05-27 16:57 ` Ævar Arnfjörð Bjarmason
2017-05-27 21:46 ` Jeff King
2017-05-28 10:29 ` Ævar Arnfjörð Bjarmason
2017-05-29 0:53 ` Junio C Hamano
2017-05-28 11:43 ` René Scharfe
2017-06-02 2:23 ` Junio C Hamano
2017-06-02 3:08 ` Jeff King
2017-06-02 17:25 ` René Scharfe
2017-06-02 18:35 ` Jeff King
2017-06-02 22:04 ` Ulrich Mueller
2017-06-02 22:30 ` Jeff King
2017-06-02 22:47 ` Ulrich Mueller
2017-06-02 22:51 ` Jeff King
2017-06-03 10:40 ` [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself René Scharfe
2017-06-03 13:13 ` Ulrich Mueller
2017-06-03 16:20 ` René Scharfe
2017-06-07 8:17 ` Jeff King
2017-06-07 9:13 ` [PATCH] date: use localtime() for "-local" time formats Jeff King
2017-06-11 17:36 ` [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself René Scharfe
2017-06-12 15:12 ` Junio C Hamano
2017-06-12 16:16 ` Ævar Arnfjörð Bjarmason
2017-06-12 16:56 ` Ulrich Mueller
2017-06-12 17:53 ` Ævar Arnfjörð Bjarmason
2017-06-12 18:15 ` Junio C Hamano
2017-06-12 18:20 ` Jeff King
2017-06-12 19:02 ` Ævar Arnfjörð Bjarmason
2017-06-12 21:10 ` Jeff King
2017-06-13 6:23 ` Linus Torvalds
2017-06-12 22:31 ` René Scharfe
2017-06-13 10:16 ` Ævar Arnfjörð Bjarmason
2017-06-13 10:31 ` Ulrich Mueller
2017-06-12 16:58 ` René Scharfe
2017-06-12 17:36 ` Jeff King
2017-06-15 8:46 ` [PATCH v2] " René Scharfe
2017-06-15 11:27 ` Ulrich Mueller
2017-06-15 12:28 ` René Scharfe [this message]
2017-06-15 12:29 ` [PATCH v3] " René Scharfe
2017-06-15 13:49 ` Jeff King
2017-06-15 13:51 ` [PATCH 1/2] t0006: check --date=format zone offsets Jeff King
2017-06-15 13:52 ` [PATCH 2/2] date: use localtime() for "-local" time formats Jeff King
2017-06-15 16:12 ` René Scharfe
2017-06-15 21:40 ` Junio C Hamano
2017-06-16 12:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cf275a-8eaa-49b9-7c2a-f98424088e1e@web.de \
--to=l.s.r@web.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).