git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Aaron S. Meurer" <asmeurer@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
	"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: git bisect problems/ideas
Date: Wed, 19 Jan 2011 12:44:57 -0700	[thread overview]
Message-ID: <0253BAE3-90F7-492C-ADF5-8B16DFFA1E44@gmail.com> (raw)
In-Reply-To: <AANLkTi=A2Twepg3Jo_VYxtvghkhx6ixcpRH3332BoRQo@mail.gmail.com>

>>> Yeah, many people find it difficult to reverse the meaning of "bad"
>>> and "good" when looking for a fix. There were some suggestions at some
>>> points to do something about it. Some of the suggestions were to use
>>> some aliases for "good" and "bad", but there was no agreement. Other
>>> suggestions had a patch attached but the patch was not good enough or
>>> something.
>>> 
>>> Anyway, the restriction is that the "bad" commit cannot be an ancestor
>>> of a "good" commit. But the "good" commits need not be all ancestors
>>> of the "bad" commit. For example if you have a "master" branch and a
>>> "dev" branch that was forked from the "master" branch at one point,
>>> like that:
>>> 
>>> A-B-C-D-E <-- master
>>>     \F-G <-- dev
>>> 
>> 
>> I don't understand how this can only be one way?  Isn't this symmetric?  In
>> other words, how is it different from
>> 
>> A-B-C-D-E <-- dev
>>    \F-G <-- master
>> 
>> as far as bisect is concerned? Or maybe I am not entirely clear on what you
>> are saying.
> 
> Yes, it is symmetric, so we cannot just automatically reverse the
> meanning because there is no "after" or "before" relationship between
> "dev" and "master".
> 
> Best regards,
> Christian.


I think I understand.  What if something works in A, gets broken in C, stays broken in E, but gets fixed in G?  Should it maybe be implied by whichever one is marked as good first, A or G, if you trying to find the fix or the break?

If no, I think --reverse is actually a suitable fix.

Aaron Meurer

  parent reply	other threads:[~2011-01-19 19:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-15  7:33 git bisect problems/ideas Aaron S. Meurer
2011-01-17  9:38 ` Christian Couder
2011-01-17 11:51   ` Jonathan Nieder
2011-01-17 13:38     ` SZEDER Gábor
2011-01-17 20:55       ` Jonathan Nieder
2011-01-18  9:05         ` Christian Couder
2011-01-17 18:27     ` Aaron S. Meurer
2011-01-17 18:23   ` Aaron S. Meurer
2011-01-18  9:04     ` Christian Couder
2011-01-18 18:34       ` Junio C Hamano
2011-01-19 13:15         ` Christian Couder
2011-01-19 19:15         ` Aaron S. Meurer
2011-01-19 19:29           ` Junio C Hamano
2011-01-19 19:44       ` Aaron S. Meurer [this message]
2011-01-21 13:18         ` Christian Couder
2011-01-21 22:04           ` Johannes Sixt
2011-01-22 14:52             ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0253BAE3-90F7-492C-ADF5-8B16DFFA1E44@gmail.com \
    --to=asmeurer@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).