git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [BUG] Git 2.28.0-rc1 t1800 message text comparison
@ 2022-09-22 19:01 rsbecker
  2022-09-22 19:02 ` [BUG] Git 2.38.0-rc1 " rsbecker
  2022-09-23 20:43 ` rsbecker
  0 siblings, 2 replies; 3+ messages in thread
From: rsbecker @ 2022-09-22 19:01 UTC (permalink / raw)
  To: git

Rc1 is looking good except for this test.

We get a diff as follows:

-fatal: cannot run bad-hooks/test-hook: ...
+fatal: cannot exec 'bad-hooks/test-hook': Permission denied

It looks like the pattern 
sed -e s/test-hook: .*/test-hook: .../

needs to be a bit extended. Adding

sed -e s/exec/run/ | send -e s/["']//g

might help clear off the other noise.

Regards,
Randall


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [BUG] Git 2.38.0-rc1 t1800 message text comparison
  2022-09-22 19:01 [BUG] Git 2.28.0-rc1 t1800 message text comparison rsbecker
@ 2022-09-22 19:02 ` rsbecker
  2022-09-23 20:43 ` rsbecker
  1 sibling, 0 replies; 3+ messages in thread
From: rsbecker @ 2022-09-22 19:02 UTC (permalink / raw)
  To: rsbecker, git

On September 22, 2022 3:02 PM, I wrote:
>Rc1 is looking good except for this test.
>
>We get a diff as follows:
>
>-fatal: cannot run bad-hooks/test-hook: ...
>+fatal: cannot exec 'bad-hooks/test-hook': Permission denied
>
>It looks like the pattern
>sed -e s/test-hook: .*/test-hook: .../
>
>needs to be a bit extended. Adding
>
>sed -e s/exec/run/ | send -e s/["']//g
>
>might help clear off the other noise.

The subject should have been 2.38.0, not 2.28.0.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [BUG] Git 2.38.0-rc1 t1800 message text comparison
  2022-09-22 19:01 [BUG] Git 2.28.0-rc1 t1800 message text comparison rsbecker
  2022-09-22 19:02 ` [BUG] Git 2.38.0-rc1 " rsbecker
@ 2022-09-23 20:43 ` rsbecker
  1 sibling, 0 replies; 3+ messages in thread
From: rsbecker @ 2022-09-23 20:43 UTC (permalink / raw)
  To: git

On September 22, 2022 3:03 PM, I wrote:
>On September 22, 2022 3:02 PM, I wrote:
>>Rc1 is looking good except for this test.
>>
>>We get a diff as follows:
>>
>>-fatal: cannot run bad-hooks/test-hook: ...
>>+fatal: cannot exec 'bad-hooks/test-hook': Permission denied
>>
>>It looks like the pattern
>>sed -e s/test-hook: .*/test-hook: .../
>>
>>needs to be a bit extended. Adding
>>
>>sed -e s/exec/run/ | send -e s/["']//g
>>
>>might help clear off the other noise.

A patch that might work is as follows:

diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh
index 43fcb7c0bf..9a723631a2 100755
--- a/t/t1800-hook.sh
+++ b/t/t1800-hook.sh
@@ -173,7 +173,10 @@ test_expect_success 'git hook run a hook with a bad
shebang' '
                -c core.hooksPath=bad-hooks \
                hook run test-hook >out 2>err &&
        test_must_be_empty out &&
-       sed -e "s/test-hook: .*/test-hook: .../" <err >actual &&
+       quot=`echo "\047"` &&
+       sed -e "s/exec/run/" <err | \
+               sed -e "s/$quot//g" | \
+               sed -e "s/test-hook: .*/test-hook: .../" >actual &&
        test_cmp expect actual
 '

This does not require setting up a prerequisite for NonStop and the
technique might make the MING code easier but adding a change from spawn to
run.

-Randall


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-23 20:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 19:01 [BUG] Git 2.28.0-rc1 t1800 message text comparison rsbecker
2022-09-22 19:02 ` [BUG] Git 2.38.0-rc1 " rsbecker
2022-09-23 20:43 ` rsbecker

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).