From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Jeff King'" <peff@peff.net>
Cc: "'Junio C Hamano'" <gitster@pobox.com>, <git@vger.kernel.org>
Subject: RE: [ANNOUNCE] Git v2.33.0-rc2 (Build/Test Report)
Date: Tue, 17 Aug 2021 10:30:34 -0400 [thread overview]
Message-ID: <01f901d79374$73e759b0$5bb60d10$@nexbridge.com> (raw)
In-Reply-To: <YRrm5odz3WhcUQS9@coredump.intra.peff.net>
On August 16, 2021 6:30 PM, Jeff King wrote:
>To: Randall S. Becker <rsbecker@nexbridge.com>
>Cc: 'Junio C Hamano' <gitster@pobox.com>; git@vger.kernel.org
>Subject: Re: [ANNOUNCE] Git v2.33.0-rc2 (Build/Test Report)
>
>On Mon, Aug 16, 2021 at 06:22:59PM -0400, Jeff King wrote:
>
>> Yeah, I think we are better to get a consistent exit code from perl.
>> There are a few options here:
>
>So concretely, the patch below works for me (my tests are not failing, but with some instrumenting, I see that the case in question is
>exiting with code 25 before this patch, and 255 after. So it really is just that my errno values are lower than yours).
>
>It's ugly, and I kind of wonder if we'd want to do it for every script to get consistent exit codes. But it does work.
>
>diff --git a/git-send-email.perl b/git-send-email.perl index e65d969d0b..c82336c2e8 100755
>--- a/git-send-email.perl
>+++ b/git-send-email.perl
>@@ -35,8 +35,15 @@ sub readline {
> my $self = shift;
> die "Cannot use readline on FakeTerm: $$self"; }
>+
> package main;
>
>+$SIG{__DIE__} = sub {
>+ CORE::die @_ if $^S; # in an eval; use regular die
>+ CORE::die @_ if !defined $^S; # in perl's parser
>+ print STDERR "fatal: @_\n";
>+ exit 255;
>+};
>
> sub usage {
> print <<EOT;
Not as ugly as my suggestion (previous email).
-Randall
next prev parent reply other threads:[~2021-08-17 14:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 14:22 [ANNOUNCE] Git v2.33.0-rc2 (Build/Test Report) Randall S. Becker
2021-08-13 15:00 ` Junio C Hamano
2021-08-13 16:06 ` Jeff King
2021-08-16 18:08 ` Randall S. Becker
2021-08-16 18:35 ` Jeff King
2021-08-16 18:54 ` Randall S. Becker
2021-08-16 21:55 ` Jeff King
2021-08-16 21:59 ` Jeff King
2021-08-16 18:31 ` Randall S. Becker
2021-08-16 18:36 ` Jeff King
2021-08-16 20:43 ` Randall S. Becker
2021-08-16 21:02 ` Jeff King
2021-08-16 21:54 ` Randall S. Becker
2021-08-16 22:22 ` Jeff King
2021-08-16 22:29 ` Jeff King
2021-08-17 14:30 ` Randall S. Becker [this message]
2021-08-17 14:29 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01f901d79374$73e759b0$5bb60d10$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).