git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>, git@vger.kernel.org
Cc: "'Junio C Hamano'" <gitster@pobox.com>,
	"'James Knight'" <james.d.knight@live.com>
Subject: RE: [PATCH 2/2] config.mak.uname: remove unused NEEDS_SSL_WITH_CURL flag
Date: Wed, 11 Nov 2020 11:09:14 -0500	[thread overview]
Message-ID: <012701d6b845$03bde880$0b39b980$@nexbridge.com> (raw)
In-Reply-To: <20201111095420.1446-3-avarab@gmail.com>

On November 11, 2020 4:54 AM, Ævar Arnfjörð Bjarmason wrote:
> The NEEDS_SSL_WITH_CURL flag was still being set in one case, but hasn't
> existed since 23c4bbe28e6 ("build: link with curl-defined linker flags", 2018-
> 11-03). Remove it, and a comment which referred to it. See 6c109904bc8
> ("Port to HP NonStop", 2012-09-19) for the initial addition of the comment.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  config.mak.uname | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/config.mak.uname b/config.mak.uname index
> 8d7b96f8b9b..5b30a9154ac 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -541,11 +541,6 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>  	# removing the directory at OS releases J06.21 and L17.02.
>  	# Default to the older rm until those two releases are deprecated.
>  	RM = /bin/rm -f
> -	# As detected by './configure'.
> -	# Missdetected, hence commented out, see below.
> -	#NO_CURL = YesPlease
> -	# Added manually, see above.
> -	NEEDS_SSL_WITH_CURL = YesPlease
>  	NEEDS_CRYPTO_WITH_SSL = YesPlease
>  	HAVE_DEV_TTY = YesPlease
>  	HAVE_LIBCHARSET_H = YesPlease
> --
> 2.29.2.222.g5d2a92d10f8

This should be fine. We will test when rolled in, but I can't see an issue here. Sadly, I can't remove the junk above those deletions yet.

Thanks,
Randall

-- Brief whoami:
 NonStop developer since approximately 211288444200000000
 UNIX developer since approximately 421664400
-- In my real life, I talk too much.




      reply	other threads:[~2020-11-11 16:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  9:54 [PATCH 0/2] config.mak.uname: remove unused flags Ævar Arnfjörð Bjarmason
2020-11-11  9:54 ` [PATCH 1/2] config.mak.uname: remove unused the NO_R_TO_GCC_LINKER flag Ævar Arnfjörð Bjarmason
2020-11-11  9:54 ` [PATCH 2/2] config.mak.uname: remove unused NEEDS_SSL_WITH_CURL flag Ævar Arnfjörð Bjarmason
2020-11-11 16:09   ` Randall S. Becker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='012701d6b845$03bde880$0b39b980$@nexbridge.com' \
    --to=rsbecker@nexbridge.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=james.d.knight@live.com \
    --subject='RE: [PATCH 2/2] config.mak.uname: remove unused NEEDS_SSL_WITH_CURL flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git