From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id A33B11F910 for ; Thu, 24 Nov 2022 22:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229463AbiKXWW1 convert rfc822-to-8bit (ORCPT ); Thu, 24 Nov 2022 17:22:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiKXWW0 (ORCPT ); Thu, 24 Nov 2022 17:22:26 -0500 Received: from elephants.elehost.com (elephants.elehost.com [216.66.27.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EC9D8DA6B for ; Thu, 24 Nov 2022 14:22:25 -0800 (PST) Received: from Mazikeen (cpebc4dfb928313-cmbc4dfb928310.cpe.net.cable.rogers.com [99.228.251.108] (may be forged)) (authenticated bits=0) by elephants.elehost.com (8.16.1/8.16.1) with ESMTPSA id 2AOMMMtV063505 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 24 Nov 2022 17:22:22 -0500 (EST) (envelope-from rsbecker@nexbridge.com) Reply-To: From: To: "=?utf-8?Q?'=C3=86var_Arnfj=C3=B6r=C3=B0_Bjarmason'?=" Cc: , "'Jeff Hostetler'" References: <010201d9002e$8e2f9940$aa8ecbc0$@nexbridge.com> <221124.86o7swnqc1.gmgdl@evledraar.gmail.com> <221124.86bkownhqd.gmgdl@evledraar.gmail.com> In-Reply-To: <221124.86bkownhqd.gmgdl@evledraar.gmail.com> Subject: RE: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 Date: Thu, 24 Nov 2022 17:22:16 -0500 Organization: Nexbridge Inc. Message-ID: <011c01d90053$38e50900$aaaf1b00$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFGpJPtZgFqVIqLLqBzAuIVm5wgnAIIG9s7Ahg7GT6vUlpukA== Content-Language: en-ca Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On November 24, 2022 4:51 PM, Ævar Arnfjörð Bjarmason wrote: >On Thu, Nov 24 2022, Ævar Arnfjörð Bjarmason wrote: > >> [CC-ing Jeff, this is from the "stopwatch timers" topic] >> >> On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote: >> >>> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a >>> condition >>> where: >> >> Don't you mean t0211-trace2-perf.sh? >> >>> >>> + test_when_finished rm trace.perf actual test_config_global >>> + trace2.perfBrief 1 pwd test_config_global trace2.perfTarget >>> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash >>> directory.t0211-trace2-perf/trace.perf >>> + test-tool trace2 101timer 5 10 3 >>> fatal: failed to create thread[0] >>> >>> was encountered, causing the test to fail. Pointers on resolving this >>> would be helpful. >> >> Apparently we really could use a NO_PTHREADS=Y CI setup, because >> that's all that's needed to reproduce this on linux & elsewhere. >> Running the test with that: >> >> + test-tool trace2 101timer 5 10 3 >> fatal: failed to create thread[0] >> error: last command exited with $?=128 >> >> For that all that's needed is this: >> >> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh >> index 0b3436e8cac..cfba6861322 100755 >> --- a/t/t0211-trace2-perf.sh >> +++ b/t/t0211-trace2-perf.sh >> @@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' ' >> have_timer_event "main" "timer" "test" "test1" 5 actual >> ' >> >> -test_expect_success 'stopwatch timer test/test2' ' >> +test_expect_success PTHREADS 'stopwatch timer test/test2' ' >> test_when_finished "rm trace.perf actual" && >> test_config_global trace2.perfBrief 1 && >> test_config_global trace2.perfTarget "$(pwd)/trace.perf" && >> @@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' ' >> have_counter_event "main" "counter" "test" "test1" 15 actual >> ' >> >> -test_expect_success 'global counter test/test2' ' >> +test_expect_success PTHREADS 'global counter test/test2' ' >> test_when_finished "rm trace.perf actual" && >> test_config_global trace2.perfBrief 1 && >> test_config_global trace2.perfTarget "$(pwd)/trace.perf" && >> >> I think that's the correct fix here, and it should go into rc1. > >I submitted a fix at >https://lore.kernel.org/git/patch-1.1-f7f21c94a6c-20221124T214813Z- >avarab@gmail.com/; >but I see that since your message-id's contain "$" I got the In-Reply-To wrong, >sorry :) Thanks