git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509
@ 2018-01-11  5:40 Randall S. Becker
  2018-01-11  6:01 ` Randall S. Becker
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Randall S. Becker @ 2018-01-11  5:40 UTC (permalink / raw)
  To: 'git mailing list'

This fix was needed on HPE NonStop NSE where SSIZE_MAX is less than
BUFFERSIZE resulting in EINVAL. The call to read in transport-helper.c
was the only place outside of wrapper.c.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
 transport-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/transport-helper.c b/transport-helper.c
index 3640804..68a4e30 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -1202,7 +1202,7 @@ static int udt_do_read(struct unidirectional_transfer *t)
                return 0;       /* No space for more. */

        transfer_debug("%s is readable", t->src_name);
-       bytes = read(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse);
+       bytes = xread(t->src, t->buf + t->bufuse, BUFFERSIZE - t->bufuse);
        if (bytes < 0 && errno != EWOULDBLOCK && errno != EAGAIN &&
                errno != EINTR) {
                error_errno("read(%s) failed", t->src_name);
--
2.8.5.23.g6fa7ec3



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-01-11 13:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11  5:40 [PATCH] Replaced read with xread in transport-helper.c to fix SSIZE_MAX overun in t5509 Randall S. Becker
2018-01-11  6:01 ` Randall S. Becker
2018-01-11  6:20 ` Jeff King
2018-01-11 13:40   ` Randall S. Becker
2018-01-11  6:31 ` Jeff King
2018-01-11 13:43   ` Randall S. Becker

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).