From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6B1701F406 for ; Tue, 9 Jan 2018 13:05:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757049AbeAINF1 (ORCPT ); Tue, 9 Jan 2018 08:05:27 -0500 Received: from a7-12.smtp-out.eu-west-1.amazonses.com ([54.240.7.12]:49098 "EHLO a7-12.smtp-out.eu-west-1.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756975AbeAINFY (ORCPT ); Tue, 9 Jan 2018 08:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=shh3fegwg5fppqsuzphvschd53n6ihuv; d=amazonses.com; t=1515503123; h=From:To:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=aq5zsjJbI/b7MSVUj1dQ0wsa6ves2p66kj3KDFsTwHo=; b=ZNsVOuO7qMyZj0BziOeIdeUGdxbmvwGeClDftHFG8EAYZ/BqO1sMsBY8XE9iB628 QsjtgNzcaKYGvcOYOMIqIMptJEOooQU0F93IJ4qmyeAhSLzOoKOMZiHwlvvjvL01Z3E /LP2u+i6AGRja1iuRePWnMXHGjqU8lKc/p+4lLIk= From: Olga Telezhnaya To: git@vger.kernel.org Message-ID: <01020160db067b11-6e867688-40cb-4467-954d-847076ff6157-000000@eu-west-1.amazonses.com> In-Reply-To: <01020160db0679c9-799a0bc4-b6d1-43e2-ad3b-80be4e4c55e9-000000@eu-west-1.amazonses.com> References: <01020160db0679c9-799a0bc4-b6d1-43e2-ad3b-80be4e4c55e9-000000@eu-west-1.amazonses.com> Subject: [PATCH 11/20] cat-file: get rid of duplicate checking MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Tue, 9 Jan 2018 13:05:23 +0000 X-SES-Outgoing: 2018.01.09-54.240.7.12 Feedback-ID: 1.eu-west-1.YYPRFFOog89kHDDPKvTu4MK67j4wW0z7cAgZtFqQH58=:AmazonSES Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org We could remove this because we have already checked that at verify_ref_format function in ref-filter. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- builtin/cat-file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/builtin/cat-file.c b/builtin/cat-file.c index dd43457c0ad7e..1f331559e55c7 100644 --- a/builtin/cat-file.c +++ b/builtin/cat-file.c @@ -197,8 +197,6 @@ static void expand_atom(struct strbuf *sb, const char *atom, int len, strbuf_addstr(sb, data->rest); else if (is_atom("deltabase", atom, len)) strbuf_addstr(sb, oid_to_hex(&data->delta_base_oid)); - else - die("unknown format element: %.*s", len, atom); } static size_t expand_format(struct strbuf *sb, const char *start, void *vdata) -- https://github.com/git/git/pull/450