From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pranit Bauva Subject: [PATCH v9 3/3] commit: add a commit.verbose config variable Date: Thu, 24 Mar 2016 08:25:18 +0000 Message-ID: <01020153a7ba4ec2-1fb668c3-9dc6-4137-8d92-c6a5825a156c-000000@eu-west-1.amazonses.com> References: <01020153a7ba4e07-f326395b-63df-4f8a-b378-8f387b02d0bd-000000@eu-west-1.amazonses.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Thu Mar 24 09:47:11 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aj0v8-0002sb-Vp for gcvg-git-2@plane.gmane.org; Thu, 24 Mar 2016 09:47:11 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754983AbcCXIrH (ORCPT ); Thu, 24 Mar 2016 04:47:07 -0400 Received: from a7-12.smtp-out.eu-west-1.amazonses.com ([54.240.7.12]:53500 "EHLO a7-12.smtp-out.eu-west-1.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752843AbcCXIrF (ORCPT ); Thu, 24 Mar 2016 04:47:05 -0400 X-Greylist: delayed 1304 seconds by postgrey-1.27 at vger.kernel.org; Thu, 24 Mar 2016 04:47:05 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ihchhvubuqgjsxyuhssfvqohv7z3u4hn; d=amazonses.com; t=1458807918; h=From:To:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=k52lZP6AG9gmjrBgo09hjJk0brdWJt7i2n1hDOLE6mo=; b=TVt7lE+ubBAOs6wX3opPm6fa8yOokRqVbMpeEAXOB1m3zHSOwAANJE/klid+mrzg wEWRJIW6jZMQYQMmwbk3j2JwoZ7y6AeAuXk1eC3UTfDqex8dC5xv2W0NUQZK+PH/lIt 7a1v4EhD03KdGC6NCzEkx+tAMgOAJEaLAT9cV3xo= In-Reply-To: <01020153a7ba4e07-f326395b-63df-4f8a-b378-8f387b02d0bd-000000@eu-west-1.amazonses.com> X-SES-Outgoing: 2016.03.24-54.240.7.12 Feedback-ID: 1.eu-west-1.YYPRFFOog89kHDDPKvTu4MK67j4wW0z7cAgZtFqQH58=:AmazonSES Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano Helped-by: Eric Sunshine Signed-off-by: Pranit Bauva --- The previous version of the patch are: - [v8] $gmane/288820 - [v7] $gmane/288820 - [v6] $gmane/288728 - [v5] $gmane/288728 - [v4] $gmane/288652 - [v3] $gmane/288634 - [v2] $gmane/288569 - [v1] $gmane/287540 Changes with respect to the previous patch: - Compare with -1 as only -1 value is used for unspecified behavior. - Write clean tests --- Documentation/config.txt | 4 ++++ Documentation/git-commit.txt | 3 ++- builtin/commit.c | 13 ++++++++++- t/t7507-commit-verbose.sh | 51 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 69 insertions(+), 2 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 2cd6bdd..1d0ec2e 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -1110,6 +1110,10 @@ commit.template:: "`~/`" is expanded to the value of `$HOME` and "`~user/`" to the specified user's home directory. +commit.verbose:: + A boolean or int to specify the level of verbose with `git commit`. + See linkgit:git-commit[1]. + credential.helper:: Specify an external helper to be called when a username or password credential is needed; the helper may consult external diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt index 9ec6b3c..d474226 100644 --- a/Documentation/git-commit.txt +++ b/Documentation/git-commit.txt @@ -290,7 +290,8 @@ configuration variable documented in linkgit:git-config[1]. what changes the commit has. Note that this diff output doesn't have its lines prefixed with '#'. This diff will not be a part - of the commit message. + of the commit message. See the `commit.verbose` configuration + variable in linkgit:git-config[1]. + If specified twice, show in addition the unified diff between what would be committed and the worktree files, i.e. the unstaged diff --git a/builtin/commit.c b/builtin/commit.c index b3bd2d4..db65c03 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -113,7 +113,9 @@ static char *edit_message, *use_message; static char *fixup_message, *squash_message; static int all, also, interactive, patch_interactive, only, amend, signoff; static int edit_flag = -1; /* unspecified */ -static int quiet, verbose, no_verify, allow_empty, dry_run, renew_authorship; +static int config_verbose = -1; /* unspecified */ +static int verbose = -1; /* unspecified */ +static int quiet, no_verify, allow_empty, dry_run, renew_authorship; static int no_post_rewrite, allow_empty_message; static char *untracked_files_arg, *force_date, *ignore_submodule_arg; static char *sign_commit; @@ -1505,6 +1507,11 @@ static int git_commit_config(const char *k, const char *v, void *cb) sign_commit = git_config_bool(k, v) ? "" : NULL; return 0; } + if (!strcmp(k, "commit.verbose")) { + int is_bool; + config_verbose = git_config_bool_or_int(k, v, &is_bool); + return 0; + } status = git_gpg_config(k, v, NULL); if (status) @@ -1654,6 +1661,10 @@ int cmd_commit(int argc, const char **argv, const char *prefix) argc = parse_and_validate_options(argc, argv, builtin_commit_options, builtin_commit_usage, prefix, current_head, &s); + + if (verbose == -1) + verbose = (config_verbose == -1) ? 0 : config_verbose; + if (dry_run) return dry_run_commit(argc, argv, prefix, current_head, &s); index_file = prepare_index(argc, argv, prefix, current_head, 0); diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh index cf95efb..66deac3 100755 --- a/t/t7507-commit-verbose.sh +++ b/t/t7507-commit-verbose.sh @@ -9,6 +9,12 @@ test $(wc -l out && +test $(wc -l message <<'EOF' subject @@ -100,4 +106,49 @@ test_expect_success 'verbose diff is stripped out with set core.commentChar' ' test_i18ngrep "Aborting commit due to empty commit message." err ' +test_expect_success 'commit.verbose true and --verbose omitted' ' + test_set_editor "$PWD/check-for-diff" && + git -c commit.verbose=true commit --amend +' + +test_expect_success 'commit.verbose true and --verbose' ' + test_set_editor "$PWD/check-for-diff" && + git -c commit.verbose=true commit --amend --verbose +' + +test_expect_success 'commit.verbose true and -v -v' ' + test_set_editor "$PWD/check-for-double-diff" && + git -c commit.verbose=true commit --amend -v -v +' + +test_expect_success 'commit.verbose true and --no-verbose' ' + test_set_editor "$PWD/check-for-diff" && + test_must_fail git -c commit.verbose=true commit --amend --no-verbose +' + +test_expect_success 'commit.verbose false and --verbose' ' + test_set_editor "$PWD/check-for-diff" && + git -c commit.verbose=false commit --amend --verbose +' + +test_expect_success 'commit.verbose false and -v -v' ' + test_set_editor "$PWD/check-for-double-diff" && + git -c commit.verbose=false commit --amend -v -v +' + +test_expect_success 'commit.verbose false and --verbose omitted' ' + test_set_editor "$PWD/check-for-diff" && + test_must_fail git -c commit.verbose=false commit --amend +' + +test_expect_success 'commit.verbose false and --no-verbose' ' + test_set_editor "$PWD/check-for-diff" && + test_must_fail git -c commit.verbose=false commit --amend --no-verbose +' + +test_expect_success 'status ignores commit.verbose=true' ' + git -c commit.verbose=true status >actual && + ! grep "^diff --git" actual +' + test_done -- https://github.com/git/git/pull/218