From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B49641F953 for ; Fri, 29 Oct 2021 14:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbhJ2Ogj convert rfc822-to-8bit (ORCPT ); Fri, 29 Oct 2021 10:36:39 -0400 Received: from elephants.elehost.com ([216.66.27.132]:24686 "EHLO elephants.elehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhJ2Ogi (ORCPT ); Fri, 29 Oct 2021 10:36:38 -0400 X-Virus-Scanned: amavisd-new at elehost.com Received: from Mazikeen (cpe00fc8d49d843-cm00fc8d49d840.cpe.net.cable.rogers.com [99.229.22.139] (may be forged)) (authenticated bits=0) by elephants.elehost.com (8.15.2/8.15.2) with ESMTPSA id 19TEY4hL061717 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 29 Oct 2021 10:34:04 -0400 (EDT) (envelope-from rsbecker@nexbridge.com) Reply-To: From: To: "'Theo de Raadt'" Cc: "'Alejandro Colomar \(man-pages\)'" , "'Libc-alpha'" , "'linux-man'" , , References: <73ac38a2-c287-4cc1-4e9c-0f9766ac4c0c@gmail.com> <00d501d7ccbe$0169c340$043d49c0$@nexbridge.com> <63238.1635515736@cvs.openbsd.org> <00e401d7cccf$ccde0d40$669a27c0$@nexbridge.com> <73029.1635517278@cvs.openbsd.org> In-Reply-To: <73029.1635517278@cvs.openbsd.org> Subject: RE: Is getpass(3) really obsolete? Date: Fri, 29 Oct 2021 10:33:58 -0400 Organization: Nexbridge Inc. Message-ID: <00e701d7ccd2$058b9070$10a2b150$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 16.0 Content-Language: en-ca Thread-Index: AQIurXUz3siHir4QEPyFWZm7FNZOgwHZ6oOZAi9B6dkCYbJFUgFa6lunAtQjv/Kq53cCQA== Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org October 29, 2031 10:21 AM, Theo de Raadt will write: > wrote: > > > > > getpass() is obsolete in POSIX.2. However, some platforms still > > > > are on > > POSIX.1, > > > so replacing it instead of providing a configure detection/switch > > > for it > > might > > > cause issues. > > > > > > > > > The community finally had the balls to get rid of gets(3). > > > > > > getpass(3) shares the same flaw, that the buffer size isn't passed. > > > This has been an issue in the past, and incorrectly led to > > readpassphrase(3) > > > > > > readpassphrase(3) has a few too many features/extensions for my > > > taste, but > > at > > > least it is harder to abuse. > > > > readpassphrase is not generally supported. This will break builds on > > many platforms. > > Of course moving forward takes a long time. If a better API is supplied then > there is a choice in 10 years. If a better API is not supplied, then 10 years from > now this conversation can get a reply. I checked the API 10 years from now (check the above date) at it's still not there 😉 In the meantime, compatibility is important. I checked the latest release (last week's) on my platform and readpassphrase() is not available. Let's please put a compatibility layer in.