From: Ben Peart <peartben@gmail.com>
To: David Turner <David.Turner@twosigma.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Cc: "gitster@pobox.com" <gitster@pobox.com>,
"benpeart@microsoft.com" <benpeart@microsoft.com>,
"pclouds@gmail.com" <pclouds@gmail.com>,
"johannes.schindelin@gmx.de" <johannes.schindelin@gmx.de>,
"peff@peff.net" <peff@peff.net>
Subject: Re: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files.
Date: Mon, 15 May 2017 21:15:13 -0400 [thread overview]
Message-ID: <00db0fd9-e873-79f4-0497-0fec6c98d937@gmail.com> (raw)
In-Reply-To: <d195af80f27e4fea85a96d6435b36139@exmbdft7.ad.twosigma.com>
On 5/15/2017 5:21 PM, David Turner wrote:
>
>> -----Original Message-----
>> From: Ben Peart [mailto:peartben@gmail.com]
>> Sent: Monday, May 15, 2017 3:14 PM
>> To: git@vger.kernel.org
>> Cc: gitster@pobox.com; benpeart@microsoft.com; pclouds@gmail.com;
>> johannes.schindelin@gmx.de; David Turner <David.Turner@twosigma.com>;
>> peff@peff.net
>> Subject: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to
>> speed up detecting new or changed files.
>
>> @@ -342,6 +344,8 @@ struct index_state {
>> struct hashmap dir_hash;
>> unsigned char sha1[20];
>> struct untracked_cache *untracked;
>> + time_t last_update;
>> + struct ewah_bitmap *bitmap;
>
> The name 'bitmap' doesn't tell the reader much about what it used for.
>
>> +static int update_istate(const char *name, void *is) {
>
> Rename to mark_file_dirty? Also why does it take a void pointer? Or return int (rather than void)?
>
Thanks for the feedback. I'll do some renaming and change the types passed.
>> +void refresh_by_fsmonitor(struct index_state *istate) {
>> + static has_run_once = FALSE;
>> + struct strbuf buffer = STRBUF_INIT;
>
> Rename to query_result? Also I think you're leaking it.
>
Good catch! I missed the leak there. Fixed for the next roll.
next prev parent reply other threads:[~2017-05-16 1:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 19:13 [PATCH v1 0/5] Fast git status via a file system watcher Ben Peart
2017-05-15 19:13 ` [PATCH v1 1/5] dir: make lookup_untracked() available outside of dir.c Ben Peart
2017-05-16 5:01 ` Junio C Hamano
2017-05-15 19:13 ` [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files Ben Peart
2017-05-15 21:21 ` David Turner
2017-05-16 1:15 ` Ben Peart [this message]
2017-05-16 0:22 ` brian m. carlson
2017-05-16 0:34 ` Jeff King
2017-05-16 1:55 ` Ben Peart
2017-05-16 2:51 ` Jeff King
2017-05-16 17:17 ` Ben Peart
2017-05-16 17:49 ` Jeff King
2017-05-16 19:13 ` Johannes Sixt
2017-05-17 14:26 ` Ben Peart
2017-05-17 18:15 ` Johannes Sixt
2017-05-18 4:52 ` Jeff King
2017-05-16 21:41 ` Jonathan Tan
2017-05-17 3:35 ` Ben Peart
2017-05-15 19:13 ` [PATCH v1 3/5] fsmonitor: add test cases for fsmonitor extension Ben Peart
2017-05-16 4:59 ` Junio C Hamano
2017-05-16 14:28 ` Ben Peart
2017-05-15 19:13 ` [PATCH v1 4/5] Add documentation for the fsmonitor extension. This includes the core.fsmonitor setting, the query-fsmonitor hook, and the fsmonitor index extension Ben Peart
2017-05-15 19:13 ` [PATCH v1 5/5] Add a sample query-fsmonitor hook script that integrates with the cross platform Watchman file watching service Ben Peart
2017-05-15 19:50 ` David Turner
2017-05-15 20:10 ` Ben Peart
2017-05-16 5:00 ` [PATCH v1 0/5] Fast git status via a file system watcher Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00db0fd9-e873-79f4-0497-0fec6c98d937@gmail.com \
--to=peartben@gmail.com \
--cc=David.Turner@twosigma.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).