From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: "'Eric Sunshine'" <sunshine@sunshineco.us>,
"'Git List'" <git@vger.kernel.org>
Subject: RE: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes
Date: Wed, 13 Feb 2019 16:03:30 -0500 [thread overview]
Message-ID: <009101d4c3df$9616d8b0$c2448a10$@nexbridge.com> (raw)
In-Reply-To: <xmqqr2cbbdz6.fsf@gitster-ct.c.googlers.com>
On February 13, 2019 16:01, Junio C Hamano wrote:
> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
>
> > My second attempt was to create the generate_zero_bytes function to
> > replace exactly what the second dd was doing but not user /dev/zero.
>
> Yes, and I think the patch does that ;-) It was just the original
>
> dd if=/dev/zero of=... bs=1 seek=$there count=$this_many
>
> would have been impossible to rewrite with the new generate_zero_bytes
> helper unless $there weren't seeking to the end of the file.
>
> But the other dd before the one the patch rewrites truncates the file to
make
> that seek=$there seeking to the end of the file, so simply appending
output
> from genereate_zero_bytes is sufficient and correct conversion. I wanted
to
> explain that for future readers who may wonder if the patch is doing the
> exact conversion.
Sounds like we need a documentation patch in the actual test suite rather
than in the commit <ducking>.
Cheers,
Randall
next prev parent reply other threads:[~2019-02-13 21:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 18:59 [Patch v1 0/3] 2.21.0-rc0 test fixes resulting from use of /dev/zero randall.s.becker
2019-02-09 18:59 ` [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function randall.s.becker
2019-02-10 2:05 ` Eric Sunshine
2019-02-10 19:19 ` Randall S. Becker
2019-02-12 0:37 ` Jeff King
2019-02-12 1:17 ` Eric Sunshine
2019-02-12 2:47 ` randall.s.becker
2019-02-09 18:59 ` [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes randall.s.becker
2019-02-10 2:07 ` Eric Sunshine
2019-02-12 17:18 ` Junio C Hamano
2019-02-13 17:25 ` Junio C Hamano
2019-02-13 18:18 ` Randall S. Becker
2019-02-13 21:00 ` Junio C Hamano
2019-02-13 21:03 ` Randall S. Becker [this message]
2019-02-09 18:59 ` [Patch v1 3/3] t5562: replace /dev/zero with a pipe from generate_zero_bytes randall.s.becker
2019-02-10 2:12 ` Eric Sunshine
2019-02-12 17:24 ` Junio C Hamano
2019-02-12 20:50 ` Johannes Sixt
2019-02-13 17:26 ` Junio C Hamano
2019-02-15 16:42 ` [PATCH] t5562: do not depend on /dev/zero Max Kirillov
2019-02-15 17:13 ` Randall S. Becker
2019-02-15 18:00 ` Junio C Hamano
2019-02-15 18:10 ` Randall S. Becker
2019-02-15 18:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009101d4c3df$9616d8b0$c2448a10$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).