From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id E88C01F404 for ; Wed, 28 Feb 2018 20:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934142AbeB1UEP (ORCPT ); Wed, 28 Feb 2018 15:04:15 -0500 Received: from elephants.elehost.com ([216.66.27.132]:61847 "EHLO elephants.elehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934011AbeB1UEO (ORCPT ); Wed, 28 Feb 2018 15:04:14 -0500 X-Virus-Scanned: amavisd-new at elehost.com Received: from gnash (CPE00fc8d49d843-CM00fc8d49d840.cpe.net.cable.rogers.com [99.229.179.249]) (authenticated bits=0) by elephants.elehost.com (8.15.2/8.15.2) with ESMTPSA id w1SK47R8009646 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 28 Feb 2018 15:04:08 -0500 (EST) (envelope-from rsbecker@nexbridge.com) From: "Randall S. Becker" To: "'Jonathan Nieder'" Cc: "'demerphq'" , "'Jeff King'" , "'Eric Wong'" , "'Git'" , "'Joachim Schmitz'" , "=?iso-8859-1?Q?'=C6var_Arnfj=F6r=F0_Bjarmason'?=" References: <005501d3b025$c0057ce0$401076a0$@nexbridge.com> <20180228001616.GJ174036@aiede.svl.corp.google.com> <20180228040718.GA9043@whir> <20180228050034.GA373@sigill.intra.peff.net> <20180228074251.GA11673@dcvr> <20180228074918.GA32127@sigill.intra.peff.net> <003901d3b0b7$0a144280$1e3cc780$@nexbridge.com> <20180228174402.GC251290@aiede.svl.corp.google.com> <005901d3b0c0$f5acd370$e1067a50$@nexbridge.com> <20180228185152.GE251290@aiede.svl.corp.google.com> In-Reply-To: <20180228185152.GE251290@aiede.svl.corp.google.com> Subject: RE: [Problem] test_must_fail makes possibly questionable assumptions about exit_code. Date: Wed, 28 Feb 2018 15:04:01 -0500 Message-ID: <006901d3b0cf$4a3f7d30$debe7790$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-ca Thread-Index: AQJEpadERfpX5LkwuayU7lmWnKekrgHW5ptIArDwK6kB6BkubwJEbisnAR6VsxoBc3aoQAIARwqYArfRsxIBum2kDQI9KHGRojih4yA= Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On February 28, 2018 1:52 PM, Jonathan Nieder wrote: > Randall S. Becker wrote: > > On February 28, 2018 12:44 PM, Jonathan Nieder wrote: > >> Randall S. Becker wrote: > > >>> The problem is actually in git code in its test suite that uses perl > >>> inline, not in my test code itself. > [...] > >> Can you elaborate with an example? My understanding was that > >> test_must_fail is only for running git. > [...] > > Have a look at a recent t1404 as a sample. Line 615 is the one causing > > the platform grief, because it triggers a 'die'. However, the > > particular test case #54, had no difference on platform with > > test_must_fail or !, which has the same underlying EBADF completion after > digging and digging. > > Sorry to be dense: what I see on that line is > > test_must_fail git update-ref -d $prefix/foo >out 2>err && My bad, I think. I'm going to go looking through my notes and get back on which line in the test was the issue. I assumed from your response that it might have been the test_must_fail, which is throughout the git test suite. Obviously it isn't the line failing in this case. Stay tuned.