From: <randall.s.becker@rogers.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>, "'Randall S. Becker'" <rsbecker@nexbridge.com>
Subject: RE: [PATCH v4 2/4] config.mak.uname: support for modern HPE NonStop config.
Date: Thu, 3 Jan 2019 14:58:39 -0500 [thread overview]
Message-ID: <006501d4a39e$b99fe0d0$2cdfa270$@rogers.com> (raw)
In-Reply-To: <xmqqimz5h6et.fsf@gitster-ct.c.googlers.com>
On January 3, 2019 14:45, Junio C Hamano wrote:
> To: randall.s.becker@rogers.com
> Cc: git@vger.kernel.org; Randall S. Becker <rsbecker@nexbridge.com>
> Subject: Re: [PATCH v4 2/4] config.mak.uname: support for modern HPE
> NonStop config.
>
> randall.s.becker@rogers.com writes:
>
> > @@ -470,8 +489,13 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
> > NO_MKDTEMP = YesPlease
> > # Currently libiconv-1.9.1.
> > OLD_ICONV = UnfortunatelyYes
> > - NO_REGEX = YesPlease
> > + NO_REGEX=NeedsStartEnd
> > NO_PTHREADS = UnfortunatelyYes
> >
> > # Not detected (nor checked for) by './configure'.
> > # We don't have SA_RESTART on NonStop, unfortunalety.
>
> The hunk header claims that the preimage has 8 lines while the postimage
> has 13 lines, adding 5 new lines in total. But that is not what we can
see in
> the hunk.
>
> It is unclear to me if the numbers on the hunk header are bogus, or the
patch
> text was truncated, so I cannot use these two patches with confidence.
The
> first hunk had the same issue, and 1/4 too.
>
> I do not see v4 3/4 and v4 4/4, either. It's not like you are the only
person
> who sends patches to the mailing list, and not having the patches as
> responses to a cover letter for proper threading makes it very hard to see
> which patches belong to the same series and if all the necessary patches
in a
> series have become available.
> Is it possible to arrange that to happen?
>
> Thanks.
I will reissue the whole package for you. I think I hacked it badly. Will
get to it after $DAYJOB is done.
next prev parent reply other threads:[~2019-01-03 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 20:02 [PATCH v4 2/4] config.mak.uname: support for modern HPE NonStop config randall.s.becker
2019-01-03 19:45 ` Junio C Hamano
2019-01-03 19:58 ` randall.s.becker [this message]
2019-01-03 21:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006501d4a39e$b99fe0d0$2cdfa270$@rogers.com' \
--to=randall.s.becker@rogers.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).