From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: <git@vger.kernel.org>
Cc: "'Joachim Schmitz'" <jojo@schmitz-digital.de>
Subject: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.
Date: Tue, 27 Feb 2018 18:50:25 -0500 [thread overview]
Message-ID: <005501d3b025$c0057ce0$401076a0$@nexbridge.com> (raw)
Hi all,
After months of arguing with some platform developers on this subject, the
perl spec was held over my head repeatedly about a few lines that are
causing issues. The basic problem is this line (test-lib-functions.sh, line
633, still in ffa952497)
> elif test $exit_code -gt 129 && test $exit_code -le 192
> then
> echo >&2 "test_must_fail: died by signal $(($exit_code -
128)):
According to the perl spec http://perldoc.perl.org/functions/die.html, die
basically takes whatever errno is, mods it with 256 and there you go. EBADF
is what is used when perl reads from stdin and calls die - that's standard
perl. In most systems, you end up with something useful, when EBADF is 9.
But when it is 4009, you get a garbage answer (4009 mod 256 a.k.a. 169).
However, only 128-165 are technically reserved for signals, rather than all
the way up to 192, which may be true in some places but not everywhere.
The advice (I'm putting that nicely) I received was to use exit so that the
result is predictable - unlikely to be useful in the 15K test suites in git.
However, dropping this to 165 conditionally might help.
I'm looking for what approach to take here, because I don't think I'm going
to get perl fixed any time soon, or the error number range on the platform
fixed ... ever.
This is causing only two breaks that I have lived with and probably still
could. Consider me begging for a suggestion.
Sincerest,
Randall
-- Brief whoami:
NonStop developer since approximately 211288444200000000
UNIX developer since approximately 421664400
-- In my real life, I talk too much.
next reply other threads:[~2018-02-27 23:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:50 Randall S. Becker [this message]
2018-02-28 0:16 ` [Problem] test_must_fail makes possibly questionable assumptions about exit_code Jonathan Nieder
2018-02-28 4:07 ` Eric Wong
2018-02-28 5:00 ` Jeff King
2018-02-28 7:42 ` Eric Wong
2018-02-28 7:49 ` Jeff King
2018-02-28 14:55 ` Randall S. Becker
2018-02-28 16:51 ` demerphq
2018-03-01 7:36 ` Jeff King
2018-03-01 8:16 ` demerphq
2018-03-01 14:28 ` Randall S. Becker
2018-03-01 15:08 ` Jeff King
2018-03-01 15:30 ` demerphq
2018-02-28 16:22 ` Junio C Hamano
2018-02-28 16:46 ` demerphq
2018-02-28 17:10 ` Randall S. Becker
2018-02-28 17:19 ` demerphq
2018-02-28 17:20 ` demerphq
2018-02-28 17:32 ` Randall S. Becker
2018-02-28 17:44 ` Jonathan Nieder
2018-02-28 18:21 ` Randall S. Becker
2018-02-28 18:51 ` Jonathan Nieder
2018-02-28 20:04 ` Randall S. Becker
2018-02-28 22:02 ` Randall S. Becker
2018-02-28 23:16 ` Jonathan Nieder
2018-03-01 7:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005501d3b025$c0057ce0$401076a0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=jojo@schmitz-digital.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).