From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: RE: [RFE] install-doc-quick.sh should accept a commit-ish
Date: Wed, 6 Dec 2017 11:48:33 -0500 [thread overview]
Message-ID: <004001d36eb2$10f8ef20$32eacd60$@nexbridge.com> (raw)
In-Reply-To: <xmqqtvx3hkst.fsf@gitster.mtv.corp.google.com>
On December 6, 2017 11:40 AM, Junio C Hamano wrote:
>"Randall S. Becker" <rsbecker@nexbridge.com> writes:
>> Having the git-manpages repo available is fantastic for platforms that
>> cannot easily build documentation on demand, for example, when too
>> many dependencies that do not build properly.
>> It would be really nice to have a version of install-doc-quick.sh to
either:
>> 1. Use whatever version is checked out in git-manpages; or
>> 2. Use the proper commit associated with the git commit being
>> installed (0a8e923 for v2.6.0 , as an example); or
>> 3. Allow the commit to be passed through the Documentation Makefile on
demand so that any version of documentation can be installed.
>Do you mean something like this so that you can say "not the tip of the
master branch but this one?"
> Documentation/install-doc-quick.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>diff --git a/Documentation/install-doc-quick.sh
b/Documentation/install-doc-quick.sh
>index 327f69bcf5..83764f7537 100755
>--- a/Documentation/install-doc-quick.sh
>+++ b/Documentation/install-doc-quick.sh
>@@ -3,8 +3,9 @@
> repository=${1?repository}
> destdir=${2?destination}
>+head=${3+master}
>+GIT_DIR=
>-head=master GIT_DIR=
> for d in "$repository/.git" "$repository"
> do
> if GIT_DIR="$d" git rev-parse refs/heads/master >/dev/null 2>&1
Providing I can pass that through make via something like quick-install-man
head=commit-ish, that's what I'm hoping.
Cheers,
Randall
prev parent reply other threads:[~2017-12-06 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 15:57 [RFE] install-doc-quick.sh should accept a commit-ish Randall S. Becker
2017-12-06 16:40 ` Junio C Hamano
2017-12-06 16:48 ` Randall S. Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004001d36eb2$10f8ef20$32eacd60$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).