list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: <>
To: <>
Subject: RE: [BUG] Git 2.38.0-rc1 t1800 message text comparison
Date: Fri, 23 Sep 2022 16:43:21 -0400	[thread overview]
Message-ID: <003501d8cf8d$21ce5ba0$656b12e0$> (raw)

On September 22, 2022 3:03 PM, I wrote:
>On September 22, 2022 3:02 PM, I wrote:
>>Rc1 is looking good except for this test.
>>We get a diff as follows:
>>-fatal: cannot run bad-hooks/test-hook: ...
>>+fatal: cannot exec 'bad-hooks/test-hook': Permission denied
>>It looks like the pattern
>>sed -e s/test-hook: .*/test-hook: .../
>>needs to be a bit extended. Adding
>>sed -e s/exec/run/ | send -e s/["']//g
>>might help clear off the other noise.

A patch that might work is as follows:

diff --git a/t/ b/t/
index 43fcb7c0bf..9a723631a2 100755
--- a/t/
+++ b/t/
@@ -173,7 +173,10 @@ test_expect_success 'git hook run a hook with a bad
shebang' '
                -c core.hooksPath=bad-hooks \
                hook run test-hook >out 2>err &&
        test_must_be_empty out &&
-       sed -e "s/test-hook: .*/test-hook: .../" <err >actual &&
+       quot=`echo "\047"` &&
+       sed -e "s/exec/run/" <err | \
+               sed -e "s/$quot//g" | \
+               sed -e "s/test-hook: .*/test-hook: .../" >actual &&
        test_cmp expect actual

This does not require setting up a prerequisite for NonStop and the
technique might make the MING code easier but adding a change from spawn to


      parent reply	other threads:[~2022-09-23 20:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 19:01 [BUG] Git 2.28.0-rc1 t1800 message text comparison rsbecker
2022-09-22 19:02 ` [BUG] Git 2.38.0-rc1 " rsbecker
2022-09-23 20:43 ` rsbecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003501d8cf8d$21ce5ba0$656b12e0$' \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).