From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Jeff King'" <peff@peff.net>
Cc: "'git mailing list'" <git@vger.kernel.org>
Subject: RE: [BUG] Weird breakages in t1450 #2 on NonStop
Date: Fri, 12 Jan 2018 10:47:39 -0500 [thread overview]
Message-ID: <001c01d38bbc$b04a05b0$10de1110$@nexbridge.com> (raw)
In-Reply-To: <20180112143912.GB9088@sigill.intra.peff.net>
On January 12, 2018 9:39 AM, Jeff King wrote:
> On Thu, Jan 11, 2018 at 04:39:04PM -0500, Randall S. Becker wrote:
>
> > > executed because the test_commit fails with a non-zero git commit
> > > completion code. There is no rn---- (actual r n 252 252 252 252) in
> > > the objects directory - even the 'rn' does not correspond to
> > > anything.. I am suspecting an unterminated string that ran into
> > > freed memory somewhere, but that's speculative.
> >
> > Does anyone recall fixing this one at or near
> > dfe46c5ce6e68d682f80f9874f0eb107e9fee797? There was a rewrite of
> > sha1_file.c including link_alt_odb_entry where I am finding memory
> > corruptions. I think I'm chasing something that was already fixed some
> > time after 2.13.5 but the common parent to where I am is pretty far
> > back compared to master.
>
> I did a lot of work on link_alt_odb_entry() in the past year or so, and I seem
> to recall seeing some cases where we could run into unterminated memory
> in the error message.
>
> Maybe dc732bd5cb (read_info_alternates: read contents into strbuf, 2017-
> 09-19)?
In that case, I think I'm going to jump right to 2.16.0-rc2. I think I would have preferred 2.15.2 - but there isn't one yet 😉
Cheers,
Randall
-- Brief whoami:
NonStop developer since approximately 211288444200000000
UNIX developer since approximately 421664400
-- In my real life, I talk too much.
prev parent reply other threads:[~2018-01-12 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 14:45 [BUG] Weird breakages in t1450 #2 on NonStop Randall S. Becker
2018-01-11 21:39 ` Randall S. Becker
2018-01-12 14:39 ` Jeff King
2018-01-12 15:47 ` Randall S. Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001c01d38bbc$b04a05b0$10de1110$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).