From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>
Cc: "'Junio C Hamano'" <gitster@pobox.com>,
"'Duy Nguyen'" <pclouds@gmail.com>,
"'Jonathan Nieder'" <jrnieder@gmail.com>,
"'Stefan Beller'" <sbeller@google.com>,
"'Git Mailing List'" <git@vger.kernel.org>,
<git-packagers@googlegroups.com>,
"'Han-Wen Nienhuys'" <hanwen@google.com>
Subject: RE: [PATCH] Makefile: enable DEVELOPER by default
Date: Mon, 6 Aug 2018 15:20:29 -0400 [thread overview]
Message-ID: <001b01d42dba$8cd1e580$a675b080$@nexbridge.com> (raw)
In-Reply-To: <87wot3s87t.fsf@evledraar.gmail.com>
On August 6, 2018 1:42 PM, Ævar Arnfjörð Bjarmason wrote:
> On Mon, Aug 06 2018, Randall S. Becker wrote:
>
> > On August 6, 2018 12:40 PM, Ævar Arnfjörð Bjarmason wrote:
> >> On Sat, Aug 04 2018, Junio C Hamano wrote:
> >>
> >> > Duy Nguyen <pclouds@gmail.com> writes:
> >> >
> >> >> On Sat, Aug 4, 2018 at 8:11 AM Jonathan Nieder
> >> >> <jrnieder@gmail.com>
> >> wrote:
> >> >>> My main concern is not about them but about other people building
> >> >>> from source in order to run (instead of to develop) Git, and by
> >> >>> extension, the people they go to for help when it doesn't work.
> >> >>> I have lots of bitter experience of -Werror being a support
> >> >>> headache and leading to bad workarounds when someone upgrades
> >> >>> their compiler and the build starts failing due to a new warning it has
> introduced.
> >> >>
> >> >> Even old compilers can also throw some silly, false positive
> >> >> warnings (which now turn into errors) because they are not as
> >> >> smart as new ones.
> >> >
> >> > I agree with both of the above. I do not think the pros-and-cons
> >> > are in favor of forcing the developer bit to everybody, even though
> >> > I am sympathetic to the desire to see people throw fewer bad
> >> > changes that waste review bandwidth by not compiling or passing its
> >> > own tests at us.
> >>
> >> I agree.
> >>
> >> Responding to the thread in general, perhaps people would like this
> >> more if we turned DEVELOPER=1 DEVOPTS=no-error on by default?
> >>
> >> That's basically why I added it in 99f763baf5 ("Makefile: add a
> >> DEVOPTS to suppress -Werror under DEVELOPER", 2018-04-14), because I
> >> wanted the abilty to have verbose informative output without the
> >> build dying on some older systems / compilers.
> >>
> >> It's fine and understandable if you're someone who's just building a
> >> package on some older system if you get a bunch of compiler warnings,
> >> but more annoying if you have to dig into how to disable a default -
> Werror.
> >
> > I am the platform maintainer for HPE NonStop and need to make sure I'm
> > not packaging DEV builds to anyone
>
> Perhaps confusingly, the DEVELOPER=1 flag in git is not like the developer
> flag in some other projects. It's purely there to turn on extra compiler
> warnings (by default, fatal), it doesn't e.g. turn on extra asserts, tracing, or
> suppress stripping of the binaries.
>
> So if we enabled some variant of it by default it would be fine to ship the
> result of that to your users, e.g. I ship DEVELOPER=1 builds to users.
That works for me. I generally consider warnings to be errors in my builds anyway, by policy (except when I have no choice in the matter and the warning is explainable).
Cheers,
Randall
-- Brief whoami:
NonStop developer since approximately 211288444200000000
UNIX developer since approximately 421664400
-- In my real life, I talk too much.
next prev parent reply other threads:[~2018-08-06 19:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 2:00 [PATCH] Makefile: enable DEVELOPER by default Stefan Beller
2018-08-04 2:02 ` Stefan Beller
2018-08-04 6:09 ` Jonathan Nieder
2018-08-04 6:38 ` Duy Nguyen
2018-08-04 17:19 ` Junio C Hamano
2018-08-06 16:40 ` Ævar Arnfjörð Bjarmason
2018-08-06 17:02 ` Jeff King
2018-08-06 17:04 ` Randall S. Becker
2018-08-06 17:11 ` Jonathan Nieder
2018-08-06 18:59 ` Jeff King
2018-08-06 17:39 ` Ævar Arnfjörð Bjarmason
2018-08-06 18:38 ` Stefan Beller
2018-08-06 17:02 ` Randall S. Becker
2018-08-06 17:41 ` Ævar Arnfjörð Bjarmason
2018-08-06 19:20 ` Randall S. Becker [this message]
2018-09-01 21:01 ` Kaartic Sivaraam
2018-08-05 2:42 ` Eric Sunshine
2018-08-05 3:17 ` Jonathan Nieder
2018-08-05 3:33 ` Eric Sunshine
2018-08-05 4:58 ` Eric Sunshine
2018-08-05 7:57 ` Jonathan Nieder
2018-08-31 8:33 ` [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning Eric Sunshine
2018-08-31 11:54 ` Ævar Arnfjörð Bjarmason
2018-08-31 18:31 ` Eric Sunshine
2018-08-31 17:00 ` Jonathan Nieder
2018-08-31 20:59 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001b01d42dba$8cd1e580$a675b080$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=avarab@gmail.com \
--cc=git-packagers@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).