From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Max Kirillov'" <max@max630.net>, <git@vger.kernel.org>
Cc: "'Johannes Schindelin'" <Johannes.Schindelin@gmx.de>,
"'Junio C Hamano'" <gitster@pobox.com>
Subject: RE: [PATCH] t5562: do not depend on /dev/zero
Date: Fri, 15 Feb 2019 12:13:42 -0500 [thread overview]
Message-ID: <001601d4c551$d0f24c30$72d6e490$@nexbridge.com> (raw)
In-Reply-To: <20190215164237.12250-1-max@max630.net>
On February 15, 2019 11:43, Max Kirillov wrote:
> It was reported [1] that NonStop platform does not have /dev/zero.
>
> The test uses /dev/zero as a dummy input. Passing case (http-backed failed
> because of too big input size) should not be reading anything from it. If
http-
> backend would erroneously try to read any data returning EOF probably
> would be even safer than providing some meaningless data.
>
> Replace /dev/zero with /dev/null to avoid issues with platforms which do
not
> have /dev/zero.
>
> [1] https://public-inbox.org/git/20190209185930.5256-4-
> randall.s.becker@rogers.com/
>
> Reported-by: Randall S. Becker <rsbecker@nexbridge.com>
> Signed-off-by: Max Kirillov <max@max630.net>
> ---
> By the way, I don't think this requires such sofisticated fix. In the
success
> case the input would not be read at all.
> You could replace it with /dev/null, the in failure (not immediate fail)
git
> would fail due to truncated input or something.
>
> Also, as you experience hang issue [2] in earlier tests, this one should
not
> have contributed to it.
>
> [2] https://public-
> inbox.org/git/001901d4c22b$194bfe60$4be3fb20$@nexbridge.com/
> t/t5562-http-backend-content-length.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5562-http-backend-content-length.sh
b/t/t5562-http-backend-
> content-length.sh
> index 90d890d02f..436c261c86 100755
> --- a/t/t5562-http-backend-content-length.sh
> +++ b/t/t5562-http-backend-content-length.sh
> @@ -150,7 +150,7 @@ test_expect_success 'CONTENT_LENGTH overflow
> ssite_t' '
> GIT_HTTP_EXPORT_ALL=TRUE \
> REQUEST_METHOD=POST \
> CONTENT_LENGTH="$NOT_FIT_IN_SSIZE" \
> - git http-backend </dev/zero >/dev/null 2>err &&
> + git http-backend </dev/null >/dev/null 2>err &&
> grep "fatal:.*CONTENT_LENGTH" err
FTR, this particular subtest is not the one that is hanging. This subtest
passes on NonStop with any and all (now) 4 solutions that have been floating
around.
Cheers,
Randall
next prev parent reply other threads:[~2019-02-15 17:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 18:59 [Patch v1 0/3] 2.21.0-rc0 test fixes resulting from use of /dev/zero randall.s.becker
2019-02-09 18:59 ` [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function randall.s.becker
2019-02-10 2:05 ` Eric Sunshine
2019-02-10 19:19 ` Randall S. Becker
2019-02-12 0:37 ` Jeff King
2019-02-12 1:17 ` Eric Sunshine
2019-02-12 2:47 ` randall.s.becker
2019-02-09 18:59 ` [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes randall.s.becker
2019-02-10 2:07 ` Eric Sunshine
2019-02-12 17:18 ` Junio C Hamano
2019-02-13 17:25 ` Junio C Hamano
2019-02-13 18:18 ` Randall S. Becker
2019-02-13 21:00 ` Junio C Hamano
2019-02-13 21:03 ` Randall S. Becker
2019-02-09 18:59 ` [Patch v1 3/3] t5562: replace /dev/zero with a pipe from generate_zero_bytes randall.s.becker
2019-02-10 2:12 ` Eric Sunshine
2019-02-12 17:24 ` Junio C Hamano
2019-02-12 20:50 ` Johannes Sixt
2019-02-13 17:26 ` Junio C Hamano
2019-02-15 16:42 ` [PATCH] t5562: do not depend on /dev/zero Max Kirillov
2019-02-15 17:13 ` Randall S. Becker [this message]
2019-02-15 18:00 ` Junio C Hamano
2019-02-15 18:10 ` Randall S. Becker
2019-02-15 18:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001601d4c551$d0f24c30$72d6e490$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).