From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Jeff King'" <peff@peff.net>
Cc: <git@vger.kernel.org>, "'Duy Nguyen'" <pclouds@gmail.com>
Subject: RE: [Possible Breakage] t1308 - Bad return value from test-tool
Date: Sat, 9 Feb 2019 13:08:01 -0500 [thread overview]
Message-ID: <000501d4c0a2$683b78f0$38b26ad0$@nexbridge.com> (raw)
In-Reply-To: <20190209042404.GA18286@sigill.intra.peff.net>
On February 8, 2019 23:24, Jeff King wrote:
> On Fri, Feb 08, 2019 at 04:42:19PM -0500, Randall S. Becker wrote:
>
> > t1308 has me perplexed - this is an old breakage on the NonStop
> > platform, that I have just gotten around to checking with the new bash
> > version we have. When running sub-test 23, the following was reported:
> >
> > Value not found for "foo.bar"
> > test_expect_code: command exited with 1, we wanted 2 test-tool config
> > configset_get_value foo.bar a-directory
> >
> > However, when I looked inside t/helper/test-config.c, every path
> > reporting "Value not found" has a goto exit1 not exit2. It seems, from
> > the code, that the test is actually incorrect and should be expecting
> > 1 not 2, and that it is working properly on NonStop (but the test fails as a
> result).
>
> We're expecting it to report an error reading the directory, not "value not
> found". Which would yield code 2.
>
> It sounds like you might need to set FREAD_READS_DIRECTORIES in your
> config.mak.
Setting FREAD_READS_DIRECTORIES = UnfortunatelyYes
still results in
Value not found for "foo.bar"
test_expect_code: command exited with 1, we wanted 2 test-tool config configset_get_value foo.bar a-directory
not ok 23 - proper error on directory "files"
#
# echo "Error (-1) reading configuration file a-directory." >expect &&
# mkdir a-directory &&
# test_expect_code 2 test-tool config configset_get_value foo.bar a-directory 2>output &&
# grep "^warning:" output &&
# grep "^Error" output >actual &&
# test_cmp expect actual
#
I don't think that helped. While fopen can open a directory, fread does not return any data in this platform. readdir or nftw/ftw are pretty much the only options. However, the code still goes down the goto exit1 path in this situation.
Perplexed,
Randall
next prev parent reply other threads:[~2019-02-09 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 21:42 [Possible Breakage] t1308 - Bad return value from test-tool Randall S. Becker
2019-02-09 4:24 ` Jeff King
2019-02-09 18:08 ` Randall S. Becker [this message]
2019-02-09 23:32 ` Jeff King
2019-02-10 0:15 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501d4c0a2$683b78f0$38b26ad0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).