From: Joey Salazar <jgsal@protonmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [OUTREACHY][PATCH v2] t7006: Use test_path_is_* functions in test script
Date: Wed, 21 Oct 2020 22:21:59 +0000 [thread overview]
Message-ID: <-fqjNpjuA1NlG29AeRtBDgTHlHbtljRImPvtORqdjK7QXE7fOn8GyzCWlgYj-eZvfj_sNPuCjHoh70xUyfusx1myQYR9HzfiM14M-96cBL0=@protonmail.com> (raw)
In-Reply-To: <xmqqft675jjv.fsf@gitster.c.googlers.com>
Will do, thank you.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, October 21, 2020 3:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Joey Salazar jgsal@protonmail.com writes:
>
> > Hi Phillip, Junio,
> > Thank you for your reviews and support, they're much appreciated and I'm happy the patch looks ok.
> >
> > > I'll probably have to hand-edit the authorship before applying
> > > (check the From: of the e-mail) so that the identity on the
> > > signed-off-by trailer matches the author, but other than that the
> > > patch looks quite good to me, too.
> >
> > My big apologies Junio, I mistook "authorship" to mean my `git config --global user.name` and `git config --global user.email` settings.
> > Should I resend the patch email?
>
> No need to apologize and no need to resend. You may want to send a
> patch to yourself to prepare your procedure, but that is something
> you can do without sending patches to the list.
>
> Thanks.
next prev parent reply other threads:[~2020-10-21 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 19:53 [OUTREACHY][PATCH v2] t7006: Use test_path_is_* functions in test script Joey S
2020-10-21 13:25 ` Phillip Wood
2020-10-21 18:42 ` Junio C Hamano
2020-10-21 21:42 ` Joey Salazar
2020-10-21 21:57 ` Junio C Hamano
2020-10-21 22:21 ` Joey Salazar [this message]
2020-10-26 20:50 ` Jonathan Nieder
2020-10-26 21:24 ` Junio C Hamano
2020-10-26 21:46 ` Joey Salazar
2020-10-26 22:02 ` Jonathan Nieder
2020-10-26 23:00 ` Joey Salazar
2020-10-27 0:04 ` Joey Salazar
2020-10-27 0:14 ` Jonathan Nieder
2020-10-27 23:45 ` Joey Salazar
2020-10-28 0:19 ` Jonathan Nieder
2020-10-28 2:45 ` Joey Salazar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='-fqjNpjuA1NlG29AeRtBDgTHlHbtljRImPvtORqdjK7QXE7fOn8GyzCWlgYj-eZvfj_sNPuCjHoh70xUyfusx1myQYR9HzfiM14M-96cBL0=@protonmail.com' \
--to=jgsal@protonmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).