From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2A9611F8C6 for ; Fri, 6 Aug 2021 14:30:23 +0000 (UTC) Received: from localhost ([::1]:51292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC0re-0007JZ-05 for normalperson@yhbt.net; Fri, 06 Aug 2021 10:30:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC0rL-0007I3-Nq for bug-gnulib@gnu.org; Fri, 06 Aug 2021 10:30:05 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:37442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC0rJ-0004x8-3o for bug-gnulib@gnu.org; Fri, 06 Aug 2021 10:30:03 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 176EHKO3007890 for ; Fri, 6 Aug 2021 14:29:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2021-07-09; bh=Hz7GvelG3uMMwC327F5XVx2g/AknZah2JvYaAYryBL8=; b=YwOWRZlI/zQ2Pb/XQg+tVlqusp1U/AJk1WuWxjG61qHJqPIMfDwnf0dlq2iXqFhs0HSv NMAfEvC7wHp7NT8Nxglk7paWmaFiCv32s4XY1ppwSjpsKVMKZakPCL7dHsdsF4v7KQ7P bkBtjYWGL4HUBpPAj0Z7id9pnlCUYd2NvW9hhGWfl9E18coIZp7EsE3OxiYOI6+WkyR2 Yra58mcRw5hKpdc9OdKSpKy5l5r3G5XxAiLFHhphd4hW6jHfP2mg/NUXOoOAXfrSZyzs fjfXNF1DFi5Ogl45MIA5qgjN1TrRZNqtqwQabMpKVoqqYL0V5xY1YiCw8DY59GpCoprk 2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2020-01-29; bh=Hz7GvelG3uMMwC327F5XVx2g/AknZah2JvYaAYryBL8=; b=JliEOFLwtTnMz5oOHcPlBzcVhjJa3mTTyGKLonAJqY35uHF6eolQenmgXLgj41ur1hZW WoCmc/nS8y5IXO/C5WvLLEbor2E/skAOgrMayKbydkwaSpPrHxUCY9l7JzNVKcYXyN4I JqxysjcYxVFsMbllr/KyHPNYaAZXHI7i2qUHWhB8A3Xh0VgamXX8sT0dflg/8zvLp6rn m4CgbJTfZqevDe2Lo7PYVkof7NlDHYpD74pAdD0NGmow3JOXVZcbc1VAgL8dtVzsEx/C sbkmTrInIbj7pZh4fMi1624E6WbY2m8RXo2KEn/Ch8KfPjKMyvkNn4zD5Kg4aOVue8Ro aA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3a9661r4c3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Aug 2021 14:29:58 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 176EFdTI127061 for ; Fri, 6 Aug 2021 14:29:57 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by userp3020.oracle.com with ESMTP id 3a5ga2bq8f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Aug 2021 14:29:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KanOfnZvqcyg1TJLi9JD4omE8qrpDRAdIrYc3Naap49LkHE11QsZ4obqv7TmJV16BG8NxJBqETqzzViNdENzdHLdhemASS5W3TRMuVqaLryKZl66YcHtKiBg+fDyZe0QztZYsmW09ofoUhRvFmk0AXxuEdTF4fG6SFaDQg5nSsoh7bpAtGMjT6b9yaw7gYzdopKLSouqdZkP6ifGlXf8wvvOoAS6YH5ntEshdjUi73nmjccSIHuuuTmIgJISjVeTrrlix546Je9Az6c3T3pF8n+kUrCGG2quGoqnd261Zn7HF3bCH3ZkYdAePaEEHKunxTB5DAhMRpOY0MmbB4WFqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hz7GvelG3uMMwC327F5XVx2g/AknZah2JvYaAYryBL8=; b=F2peCxPHxHBVtLsyDtcgaRfHygq4oCWZ/pqdiFQH2p7DbnG+ECEBoe0gUFUPcfxvjdxuEbJCKiExmubUUPpiWc3yIf1Gq4e9zticvprda6uw6vI/FPEafFQaI1lLtpqFLsj1KFF8v88Do4DrLqb6dKQQ+AHiuuvO/eUejg7vGqFvbLeb1xHrTLzTU5Zqx/58kRH/cCLoNiqGqknN8oTofT1ALrGU4dPNTmUyAxs/iJtFv8NiZ6csLxXj9qgMP+7gTLgQ85raMs/cxFSnIaWanFxXBBCX9MaoI2CRfP6muT3sgz1VlLvcLEEKFNI43fjvL0rXARF4hX/eNloGPulSdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hz7GvelG3uMMwC327F5XVx2g/AknZah2JvYaAYryBL8=; b=S6YY/uH5Ay1SRAYZr9G+iRd0mE0YErKMqBnp7YPI6OweIDVkvcKaANfMT1iFXTvGEAA+709XlVd52MiZa9CfSJPp9niCiCtrO6fru17ZtsvPQ/sNXPfOVecg2X+XiT5BaxOek0aSDD5Z8LMzATp59CyByGqsMKaSBAcU+b2/Wfk= Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=oracle.com; Received: from BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) by BLAPR10MB4964.namprd10.prod.outlook.com (2603:10b6:208:30c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15; Fri, 6 Aug 2021 14:29:55 +0000 Received: from BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::5099:fac3:f345:c877]) by BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::5099:fac3:f345:c877%5]) with mapi id 15.20.4394.019; Fri, 6 Aug 2021 14:29:55 +0000 From: Darren Kenny To: bug-gnulib@gnu.org Subject: Re: [PATCH 0/3] Some Coverity fixes from GRUB In-Reply-To: References: Date: Fri, 06 Aug 2021 15:29:46 +0100 Message-ID: Content-Type: text/plain X-ClientProxiedBy: DB9PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:10:1da::27) To BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from oracle.com (46.7.162.180) by DB9PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:10:1da::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Fri, 6 Aug 2021 14:29:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb35fe3b-8895-4dae-6e11-08d958e6a8bd X-MS-TrafficTypeDiagnostic: BLAPR10MB4964: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7HNRMmvuYHV3ZmgXcIe4BJdWpawnSXbdJxSfgWewN83GQ8QZrf4lDq988zAimbFf7Oru75BwcRefKMAqxmL2c7QyzxUImtOuKGfZ61JkuCVILFmdS03G4gNpTjiYRabIdlRzOrdPCSehvJg8G7tv05iQNsffck70EJf5aJY4RoW98ZULYkWmQIRwc4Mke/jL8GlfdT33Wwn5mWaLF0tH4+HUtCasBaZIbU/Luswt9N9/eSuBRETxWOPU34JbkpuaG9Lb61tCJoundmY0zxbqRxthdaY/5SxDaZGCDOaFCZ37fO7yN/xlWmU5u3Cxkknam/chLDQVxVUKKJgt+IxYUDY6POIP1XQd4MLucnupkHjpkwMHC0cgSELvuythi6E/ZMQKzHoA97NPuElk601Ls13gciMpgNT6C2zMLcuxHL3IBupfBB/btZJAmVnZ1gWZJDfjpcA87VYpPuaaQK7qX4yndElwjOYDk5q0oP0nt4BHeJfLR9VN1LLKboqVZP0kOvGBUHIDHV0Fndg9Vp2Mb0p3mSCs8+DZJGRFWhFp9toh1sC7JSnQE10tbly3/tU0emxS5GOvVK03VoWt9uoEQNF+uqy8IKjZnHdGPb1/eGl45GPzxIsyiqmXjgHepCfXRXSDQDFI/WhgbVhU/UD6Cr7w4myIRk7lBwAf4hBRgQ6uct6lQy0g+qR4H+5O5t9uwPVdI567b0+6c8n8FTOu2g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5138.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8886007)(8936002)(316002)(83380400001)(66476007)(86362001)(44832011)(66556008)(6916009)(26005)(4326008)(107886003)(66946007)(38350700002)(7696005)(38100700002)(55016002)(8676002)(5660300002)(956004)(52116002)(2616005)(6666004)(508600001)(36756003)(2906002)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3X2XxRGvVgzFMnSf77JwFFs8McwcRnunhKtPGuq6iSy+6HSH8OauVC+Fb4CQ?= =?us-ascii?Q?gbzAQLqLdfdVcCWvZudMQXtlSesUb9nG8bi9V4SgTf0ClIIql4lV/ZfvTEpU?= =?us-ascii?Q?7/2B5jfDx60zixP7mE0pwB4rbC7JtRdpIOhd6EtnLF+bTzxqUYDVyPEu1Th0?= =?us-ascii?Q?fdgxNHvqfesce0ejlxVOE9gtF/zmxaMOs3GU4DcRWXt/MBZ2ISTvYsSpNBPg?= =?us-ascii?Q?CCV+9nAN3bbzE/ADgKvImvvnjYOfY2wOibzn11sSAf5vvBx36cbBobZ8vE7c?= =?us-ascii?Q?aifRn7RNHEaWT0BHSelaDSisiVP9b+CXmz3IhJLQvXhhM9ex+jVQBdvswKZz?= =?us-ascii?Q?/O0YoulqPiwiadLzubwZtCNBkC3V44OGHvw3K0AyueR68n8eXKuALX29shOj?= =?us-ascii?Q?RKREnc/aEgLcCFx8CuOAcNHX1aP+0No/KePz0vumnqhRoSy5/kS31lC3ZBOR?= =?us-ascii?Q?dIGjgukJusOwEkj8jCyTBnPsNb+uxLRq60jOs5VkruelV4CQyAgjTM1KkVfR?= =?us-ascii?Q?onbOZ6v561+qNlAeDufj5Ug6PDBN4NwqPFScO2l4Qew9TvVI9BwkSRR/e+CW?= =?us-ascii?Q?2M680vBi1rXURzLV0ouN9pvDyM0bpsoekDGHEOKqUptRFUEvcEcebj0LEkCU?= =?us-ascii?Q?x2aczJP4SAgxQxhscupCrejhLR30aJPMUSTsdFTVaSEs3D5f4cWKfVJ6Ocv3?= =?us-ascii?Q?VAFB+p1oXgW7nN40ycy7Wm69xi648j5c5Xy91kJarl7WqyrRj3rONuHLqjNR?= =?us-ascii?Q?1tsG5g6PDVwJxA0UiHyDlUNqI4glXd9e5XpePGheEpMLd68INAjqByYAtsZq?= =?us-ascii?Q?/YhBdoRfgiNy8UfuU0M7kr5VbPQq2WxGhxRhA0P3BwM3vQmBsDRjytQnONNH?= =?us-ascii?Q?m3F90Q0uFxLDv7yI2ItsD3kWTuzYGnEhL4w51W/iWHUaGcT4I9jGcRn9o6rp?= =?us-ascii?Q?zA9bNDOB7BnikVPu2jFp5l23M2GqCZXauTYQHxKAcAziFIZneTPrgjeoj2WN?= =?us-ascii?Q?8uU4R4KIIc+hjw8xzBhuKBKrv6iWULbRln3IS4JTEZriMWpoLLW+UHlp35j/?= =?us-ascii?Q?tXQDXFXMTjUOjQMRF9+Aa/rrDGRuYnOugL4lmdcje6PmtVkQEmfEewDNQ5Dj?= =?us-ascii?Q?mxv55phBGVSgs1RvJlmyy1NSEiVWnrNzVQkGfLtGty3JWnkaQWPc93y2Qkze?= =?us-ascii?Q?Yz9DtbxUxm2vn3NeMUcffLduX+XZomzrb6YhJOTRiTAETXjklciKqaxe+1Ij?= =?us-ascii?Q?oGUgledBcU9Y4QmLoZT5UJ3J7mD+c3nRAIZzp/lDa+bZ/xjqn4SkwE3xI94n?= =?us-ascii?Q?xkhvnRb1nYw95RCpyOMmNcbG?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb35fe3b-8895-4dae-6e11-08d958e6a8bd X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5138.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2021 14:29:54.8834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d1fO5o3TX8x3wtiJGEEeG27SaY2TFzmovEoFpRx708YmI8O+hIDSNYzRTKcU7oszPTDDjQGSYpUzoDVxoh99lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4964 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10068 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108060100 X-Proofpoint-GUID: xXmL6U8k9tsSA47q6442FhnbDw6Gvwyf X-Proofpoint-ORIG-GUID: xXmL6U8k9tsSA47q6442FhnbDw6Gvwyf Received-SPF: pass client-ip=205.220.177.32; envelope-from=darren.kenny@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Kiper Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi, I've not heard anything on the first or third patches in this series, is there any possiblity that these can be take in to gnulib? Bruno has already taken patch 2 into the gnulib tree, thanks. If there is anything more that is needed to get them in, please let me know since we would like to be able to bring in the latest gnulib version to GRUB, and remove these patches from the GRUB tree. Thanks, Darren. On Friday, 2021-06-18 at 15:44:20 UTC, Darren Kenny wrote: > During the recent GRUB releases, I took a look at some Coverity issues that > were found in the gnulib sources that GRUB is using as part of its build. > > A couple of these issues still exist in the current gnulib master branch > so I've put the fixes for these together to in this patchset. > > I did a build using the command: > > ./gnulib-tool \ > --with-tests \ > --dir=/tmp/gnulib-test \ > --test argp base64 error fnmatch getdelim \ > getline gettext-h gitlog-to-changelog \ > mbswidth progname realloc-gnu \ > regex save-cwd > > which is fairly close to the list of modules that GRUB is using and there > were not test failures. > > Thanks, > > Darren. > > Darren Kenny (3): > lib/regexec: Fix possible null-dereference > lib/argp-help: Fix possible dereference of a NULL state > lib/regexec: Resolve unused variable > > lib/argp-help.c | 3 ++- > lib/regexec.c | 7 +++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > -- > 2.18.4