From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D8C401F466 for ; Thu, 30 Jan 2020 15:36:06 +0000 (UTC) Received: from localhost ([::1]:34282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixBrR-0007kO-DP for normalperson@yhbt.net; Thu, 30 Jan 2020 10:36:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58312) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixBrF-0007ia-2L for bug-gnulib@gnu.org; Thu, 30 Jan 2020 10:35:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixBrD-0001eJ-W7 for bug-gnulib@gnu.org; Thu, 30 Jan 2020 10:35:52 -0500 Received: from mout.gmx.net ([212.227.15.19]:49477) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixBrD-0001bb-IE for bug-gnulib@gnu.org; Thu, 30 Jan 2020 10:35:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580398549; bh=DFoyKSHbxydP5GlaVAjo8aRk7lN59jbxZjMh4cmofGQ=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=fHmXAp/cBxFbZqX3UP4fWxJQwlkD7/4GEPmQPqwAOZ0EiI9RazGLPOQj+kReoDElH A5Qw48ynf6sLua6X9qVLGWxdS1FsbmcHYdOyGjg//M35mzJndhv25B2k5EQH2G7SlC Z0u8gAAqGZ/O9EQ5F4z17nVctugNY49zg8K9vW9U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.111.218] ([31.17.216.109]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M9FnZ-1itagU238h-006KbD; Thu, 30 Jan 2020 16:35:49 +0100 Subject: Re: clang-10 warning in hash.c To: Bruno Haible , bug-gnulib@gnu.org References: <3695940.OeVvW2AmiG@omega> From: =?UTF-8?Q?Tim_R=c3=bchsen?= Autocrypt: addr=tim.ruehsen@gmx.de; prefer-encrypt=mutual; keydata= mQINBFOsE5ABEADD/k0t8to+R0kPhr2k7d0P/p1SYgxkwSaYgdv4/MgO/yEbQDMsqs1mw88m WnFKKdbH4QUSqCj21SiiJVrcoY7dNNapkKNiaMNCylAxkLtDw9/up0AVdkJ/7iHvrKlwIb3S BQV1oJYBrXF9rzFBtkW9NhLc+DzloeHfPtABCIi0XoIOGSDn+RQvppe/13phBj+2fd5ILNWi HfKIrr6228TynSPqy7H4z5DYcnYIJ7f7FO+MgaZjj28GFCyCFz7DMJsR/JX8CDsaOHvBsBRt BIKSQ7ce9KtAnemsmyGVkaHpGvxo3gaWj8pROIiQRbDYfXXvMbpTYh/OTxbbx3SgBNjk3fH6 ZjYZXuz+1kjJ9aajRKWvhZbMCjKEGjm3n+PrYdd2o9W6j5+aOhSWDs54z7froPmt291NdykF 4kHb3W3SwGaIACV3/ZorrwG8wHhnV8dEwqTrE6xcTIwr2+C07yFDKrSgTbZsjEb6RbZA9SKs j6+ct8TrAxVPAigj7eMdWcF8yxxQCCZci8UIx9hyHAfr4fKCYl0KlG3SoZ8kTKiB0AvjsK+Q owE7gKuHeKOvEn8cb2DiBWjDfJoTO19xhzm51jxcDneIkVoeSg5QJqtiQZybyhf7vP9vl1fS 9O8I9y1uR2lCx7UkWAGTTVTtzs+O47125jsj/BjLMECT/Ub33QARAQABtCBUaW0gUsO8aHNl biA8dGltLnJ1ZWhzZW5AZ214LmRlPokCVAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBByyfbyYYUstWEFkbQgwLbaiZwQoBQJcdtynBQkMjTAXAAoJEAgwLbaiZwQo6DoP /Ah7ARec12d6Aw7vMu/Nbd0eewQt5fwlvXoYoHmpk5uVPhPboUYwtpYFtRlzsq28i7LYtdIZ R2YUXkyMba9YnTjSPeDsK5la/W58QdhdWH69T4AgtdMNyt5kRiYaheuTs5A0MQIFPMjTcqhq 265ceVz/umkk/9tq1daP4/WY4LIRWOGqJOATIObxHRGWU8rohnkc0/3uNCxM0SfXPFrkV5WH LwhLrfE0/edNkJEDpoJViogvu6gFztlejgtB/3N5jlquqSrfih7B5flBBm9ANDPCFtq3K+KJ 62vZj7qrsDM/nrNH8+vbG+iWqbjvFkXP41nUzZca+3BEnP99Ew5bOCX63uYRGHpfRS6nTthk QA6eg/LOVo6yizT0Yoo39Y/93ZE8RB79TEsi5zz6smoUUkHQm5nrBqqUPNfSO9uZwbUhDrSB PKMnfIiOWNzMLTu1ywwdgv2bUjybsTBJVb3IYQMeYj9P/mNHRc706ZIjj0rFbumYVRQe7Fv+ Vff6fPaFhBb83CxCUvwDJ6gF/pPtt78NvUIPCFnLtFkVGdKQe9RQAGa3TxZYRVlo7FcAYYfX dS5PChHkZvocC4ak+Yy1QqdmYNtFqirYrggBdsMdC6DqrEfI4dXzVwh34bNiB+bg7RkOsHr9 vBDwOKhyFujW8WsVlTV/XaGMdbAapq2gZFGLuQINBFOsE5ABEADrLQL3bP7+M6PTCjuVbqqH BDhBAKEEuxKffwDz1AJKfRhvqTYIKQqgZwaIzXdbOkmPrTEgWHJKbwssaRmdBVRSYkE2DXLE cnuxqAgNyc5RMoVHWIE4jFNkxmrN6ZcVWel2OwCo9A6bzUftKKYJRPAYou4nmv87+CdKT16J V40dMG/phLyPINByy9wThIodpJQX/H1O6OCsMM/ZQJQ8zJCXbCCCe/c5gcg6+RJLsNa1CjIj QH0F1XZuncxz3nvKLxXLuQG8HCcU5GxW/z2byjEkoJrlakmcwUzuih7IuFrvSaexb8so2N6u 5H8vm+SBkCwUc28lBsKECOJUeH28CBcMmFuRKFgF/fBpRiXDKI8Fl3IRm5vFIfL6oIBJBSDf unfZ5FPXup5fVGT9k0dhBlD48zDQ22kVVmRkpctxGwd3yE4BM9/sQ3nK4HwrB9+9X2RqxbAz wz8LGvRE7/rusBg9HaO8kIOO/7NjutCvJkHGPfJSF7i9XvBcoQpkTIJFPaxupk7TCFOVDAzU Yh82MzNq89SVe49017/nuXzKJ3SAtok7xDYVsXXriYgnmouL7f+cDXdXmLIxPZN6LKkwKb9/ rU0/9xPuvxS25zCSgjig8/SFEdSt6wvs94npSn6RcmVxi5VN1Ni4IMRgQn7hXpGKATlM6CQ3 2V7QBJN24mFECQARAQABiQI7BBgBCgAmAhsMFiEEHLJ9vJhhSy1YQWRtCDAttqJnBCgFAlx2 3MEFCQyNMDEACgkQCDAttqJnBCivgg/3cc22sESKwJrAc7cfjhxIXvqPseJAnk2lKLuPxfG0 zIozDBPQedz7ACLH0gKGZWzF4qZRLBrEflzM/KXFtkdLhNE6Ezx91X429eCwnki+wfyeDT9X c4neT73Gnx5eD8xKq4QjR7GIUNQFSuLF4BnePyboQYpPRcLuWfUCucnYjdq0abWstPaIp6pj VYmkJUnKv/99rE1NP8+cyxCLKlrV7sQtH5GLaZsCyxJhHKZ+uE0DRfNox3/Dk6tg3MfPLDZz sd7x2ZgT5zTlj0fswuHSMHKkRJXnaHzhjXiF+4FGZk+MsHCW29wS6a8AbW7KRpzGmsdjroKZ mgs8YQnRVlgYKIIp2xkjMhxE7ZVJOW5v2RcTWh9wNB9vMJdgWijnki8+0L7R0aOO1KZRxWjO no6VS2hFwu2Usu1/5XEinl0iVa+iPbq/Yt3omWXD5N20uIO2hGakj/sw87ndzdZRdy6ANZCT 4WrjxWsR/qF2xiJF8gArgG8G2VZk0O3fUEaAISlnETJsvTGBQs4KAQkwiX4QjtG1Oa5RDOod jPEChMBomPeNEDk+vsosjV0Q24t0m4wdrUlgK9skQ3hw/pbqUc27TB4/0FHQ4KNNnyGuQLB6 Gzkku0EgHlNaOS4Htab28LM9cOyPJC5t2XCfQiR477unMkNjgwSjQET9gPWtmTDjvQ== Message-ID: Date: Thu, 30 Jan 2020 16:35:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <3695940.OeVvW2AmiG@omega> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="73C0JU5XTNyfqFmkDx5nDROC8w0UKmFlz" X-Provags-ID: V03:K1:8SxrVAI77T0KVopYB3H2Xvp59/NMAImnjVHiYBgA4xQjNnRMDE8 sMi9YYw5UNv2s/gxS0a7PWp/r+tLpcmAdvgIfEf9+756b9deqWVcb8UYr+Oa+9FZGf3/HHY PsDc0j80ZbKtr+QHFyxpJMvwoYCi+n2w1MI84M5O88kZvNAGmZYXMyFPAIfLOR+RTr7/fb1 nsOXFKzQYDcNgJmFZTQyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:SaMSxr+J+R8=:eb2Hyp/gFbeTgQ0RJ+nLfy FwAVXenoQ+EMKSRyjcGUH6FJlvdtwIdPpfrz4EqZy5kRxjLHPMIV4OSrRddbGe05tdV37SAiM Urt3+2srRc+mOc5xW6zewsseJKf/z+R/h+pY6wSZ9VXuNQedsKzIglokb39S3leHSmC6JJZkR 9w63xQkcLFKK9BxCN602lSK/KebZ/MObaQJPZtguQ7NGO1D5PqX+YlxRbCGm2j071o9xMnrXh +eaPJiO6HO0HIT03PaE8NfRuxkaDIy2iOdt4nRPjFdGVkNB1HNrv95ZGmGawMwcrUlcCy7oq0 +wm14Lb2zpv2eGvBm8wRH9oKIUK1w3//11lbztzDrirnSJJZcl8YV9EniRR/I7n/sAHb6ReEq GtnZJ+eY7U11Bv1q4Jdlwt+5lcruIqbhkCWzlDVI2Y1ModoPDDGvINUr70eaGYQf40u3v/Kpb 1Oy22OFei2kMygLZUedCk6FylOrLVfUX3PjT+6NE78gLpaedxRTcx6XP0hyyHOMKZGYHw5Wub UgH/t87f/u8GAm3CgbkU3dgjPl6PLW1vBNRZvmf4h8D190VGd2lknI03EtpRfAzu9m6ae/rEP B5tjeS98VrRpRfPtpDkpaZLAGGX6RTezWkLEUnkx6+DtsC4IH5bDPXkrMzytpY2bjb5h2Y9BN Bm3odEd9uHATXLhfqR4th66qNk9UD3LQlkKJXuZMkhdCppeMLZwL3ic8yn8gn/S99N/433bQd VVsVWk0hT5YfGgi08SfnaYu6MV8UqREd/JUNodRMYFVkzzry0Lr0fUL4hCVhIVO96700qYx9H RGGBVFsgTYGzjZIfaQk4vPZsjNsVjbvfRalShpaoF1kHvHDEncfaRPkgGulOUgz5m7KSdvL6/ PPTpImJ1au3rOF+ZYgu0AGvWN1Os7p3V6eYm/WwYWZwjYJ+GsqkHH5lP49fOZogRpGMq+43zL cPHpdKuAd2AMD62D3SlPRJaj6zx6T7AspvwDHHohDYKZTVJSA6pms7p1vvJxBxMjQogCf3C6q FRyrQ0olq8Dyf/ymO2uaxBsmjrwGK9vxcqei1EoYDN3jZGeGwWP9leA9a/R3wdZ6AkbTyXS7l bDlnqc4p4uluOoyaK//R+gH0zhN4NwdPlYzwtIxvSn2rfxHUWor26LAH+wJTEQYiUNJDY4StG rwmNjH7pHuXHZLVqQXK/3apLT7OV9RqM8Fq85IFwyQByAu27AXO+bY4xIhH0qRsul1l+S0Q+S VBGVmDTTPMS/OuTzV X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.19 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --73C0JU5XTNyfqFmkDx5nDROC8w0UKmFlz Content-Type: multipart/mixed; boundary="vVDtbwA0dYiYtKLvTorHW6YWcXwEBwwu5"; protected-headers="v1" From: =?UTF-8?Q?Tim_R=c3=bchsen?= To: Bruno Haible , bug-gnulib@gnu.org Message-ID: Subject: Re: clang-10 warning in hash.c References: <3695940.OeVvW2AmiG@omega> In-Reply-To: <3695940.OeVvW2AmiG@omega> --vVDtbwA0dYiYtKLvTorHW6YWcXwEBwwu5 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Bruno, On 1/27/20 2:09 PM, Bruno Haible wrote: >> Not sure if the compiler is correct here, but maybe worth a look: >> >> hash.c:549:11: error: implicit conversion from 'unsigned long' to >> 'float' changes value from 18446744073709551615 to 1844674407370955161= 6 >> [-Werror,-Wimplicit-int-float-conversion] >> if (SIZE_MAX <=3D new_candidate) >> ^~~~~~~~ ~~ >> /usr/include/stdint.h:227:22: note: expanded from macro 'SIZE_MAX' >> # define SIZE_MAX (18446744073709551615UL) >> ^~~~~~~~~~~~~~~~~~~~~~ >=20 > This warning is pointless, because > - Since the next float below 18446744073709551616 =3D 0x1000000000000= 0000 > would be 18446742974197923840 =3D 0xFFFFFF000000= 0000 > the comparison result is the same for the two values ...615 and ...= 616. > - The compiler inserts the implicit conversion only because of the '<= =3D' > operator. > IMO you should file a ticket with the clang people. >=20 > Inserting a cast to 'double' >=20 > if ((double) SIZE_MAX <=3D (double) new_candidate) >=20 > would not help, because > the next double-float below 18446744073709551616 =3D 0x1000000000000000= 0 > would be 18446744073709549568 =3D 0xFFFFFFFFFFFFF80= 0 Thanks for the understandable explanation ! Sadly, bugs.llvm.org disabled self-registration. So they won't get a bug report from me (looks like they want to encapsulate from the rest of the world). Instead -Wno-implicit-int-float-conversion will be added to the clang options. Regards, Tim --vVDtbwA0dYiYtKLvTorHW6YWcXwEBwwu5-- --73C0JU5XTNyfqFmkDx5nDROC8w0UKmFlz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHLJ9vJhhSy1YQWRtCDAttqJnBCgFAl4y99QACgkQCDAttqJn BCgEbQ/+JDrQmjSmCJZKTfzxNzdzR05CoIzpm+kYHx3/PIHKMyhcpASQEC73ffvq dHFSbUYPT2b5GX4zn0xWaCpu2KEK05K+uxDWnAmFZnPEB7FSswYKupNu3WjY2sEm e3dmz5EzDji3GAX9NlrQh8SXIdAWXUJiTHr/UEetVm7rV93RwI1XQd+spZR6ohKu qVJvxLqUked1fdtJz+egUDEHurrxpIvq51rb/bexL5roOXNUCSPQZCtMwSGBIPgw cnZcObZN7PVbA7icyMF99WIpjFegvhREk9D9Rm0vdvv+Izbti+5jXEUxYGTCRNvZ JvzLogDnmIn/NH71s06IGKzIjqBIsp4BdbTmD6TaVg41IgOW7mvmKiHMxaYQ2CB3 NrD6Ep5TjrOMj4oDgBL7HIcwiRHZbhGTqleuKc3cc4L4TnG8N+QKqQkW+CAnEl/A aE/NrwYylmiR4ZcuLf26bB39hmnkBBD+li1bdyd5hLXlKzkcd2cOAjK0fmfyuU6j f1eKwp0+SYaIMGXfzF22undJcRnded+L+uaB5Jx9MoHlaJO2xNw08Uvu12S9iNbT bLLeis6NSU3iu69TjK82lA+KcOLPxBn+Clz+xF3e0bxQOJSpJQPYjBa8sLJwTf4l JkQ79GJyx9X4b9MqgzqcIkQEDPuRWuvsKqYz3d/bEpTNBel/v/A= =c5rd -----END PGP SIGNATURE----- --73C0JU5XTNyfqFmkDx5nDROC8w0UKmFlz--