From: Paul Eggert <eggert@cs.ucla.edu>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: [PATCH] getopt: pacify gcc -Wanalyzer-null-dereference
Date: Thu, 21 Dec 2023 20:59:31 -0800 [thread overview]
Message-ID: <ea379292-689d-4475-ab24-1368fe152ee8@cs.ucla.edu> (raw)
In-Reply-To: <9463500.2WqB4rESCP@nimes>
On 2023-12-18 05:04, Bruno Haible wrote:
> Paul Eggert wrote:
>> * lib/getopt.c (process_long_option): Simplify logic slightly.
>> This pacifies gcc -flto -Wanalyzer-null-dereference when compiling
>> GNU tar on x86-64 with gcc 13.2.1 20231205 (Red Hat 13.2.1-6).
> This appears to trade a false alarm for another false alarm. Namely,
> now Coverity reports:
>
> 270 }
> 271 if (ambig_set)
>>>> CID 1574557: Memory - corruptions (ARRAY_VS_SINGLETON)
>>>> Using "ambig_set" as an array. This might corrupt or misinterpret adjacent memory locations.
> 272 ambig_set[option_index] = 1;
>
> I guess we can ignore it?
Yes, let's do that. We're already ignoring what must be hundreds of
Coverity false positives, and there's little harm in ignoring one more.
next prev parent reply other threads:[~2023-12-22 4:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 20:09 [PATCH] getopt: pacify gcc -Wanalyzer-null-dereference Paul Eggert
2023-12-18 13:04 ` Bruno Haible
2023-12-22 4:59 ` Paul Eggert [this message]
2024-01-18 0:12 ` Bruno Haible
2024-01-18 1:26 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea379292-689d-4475-ab24-1368fe152ee8@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).