From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-5.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9725F1F47C for ; Thu, 5 Jan 2023 01:19:48 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=cs.ucla.edu header.i=@cs.ucla.edu header.a=rsa-sha256 header.s=78364E5A-2AF3-11ED-87FA-8298ECA2D365 header.b=qxI0yeFF; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDEuo-0008To-GE; Wed, 04 Jan 2023 20:19:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDEum-0008Tb-MO for bug-gnulib@gnu.org; Wed, 04 Jan 2023 20:19:28 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDEuk-0000jw-GO for bug-gnulib@gnu.org; Wed, 04 Jan 2023 20:19:28 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DE7F316004F; Wed, 4 Jan 2023 17:19:22 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MkzBl3GKpaSL; Wed, 4 Jan 2023 17:19:22 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 17059160064; Wed, 4 Jan 2023 17:19:22 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 17059160064 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1672881562; bh=2mZOoXIyAoMmi0pFRXAWSfzxKaAu6WwdUtH1Wo5QkOI=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding; b=qxI0yeFF+eCnKIH1UNxnF8gnpIkeveGPlVcVVpECKxfX1NrLK9OUR6+ysSIqe0ezf Km3L1hQHfNlbI/JksLM/vXYDyKFXxWT6L1x8Af9Osg1rhQQMqJ9H7hEUAgBfPgoHA2 pW66I7EHUsxx4pLxb/96ANur2vvD9BKVVCcbUqP4= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 60pFtCR3X9Wm; Wed, 4 Jan 2023 17:19:21 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DE91B16004F; Wed, 4 Jan 2023 17:19:21 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 17:19:21 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: Ondrej Valousek , Bruno Haible , "bug-gnulib@gnu.org" References: <20230104143425.1235741-1-ondrej.valousek.xm@renesas.com> <10191473.L8ug28u51p@nimes> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -59 X-Spam_score: -6.0 X-Spam_bar: ------ X-Spam_report: (-6.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-1.708, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org On 2023-01-04 12:54, Ondrej Valousek wrote: > LIB_HAS_ACL has value only if glibc does not know getxattr() system call. It has nothing to do with libattr (yes, it's bit confusing). No kidding. This stuff is waaaayy too complicated. > Why don't we solve the linker problem with the "--as-needed" option? --as-needed isn't portable, but Gnulib has a lib-ignore module that should be more portable. I suppose we could make the qcopy-acl module depend on the lib-ignore module, but we've never done anything like that before. Another possibility would be to implement a new variable LIB_XATTR_FALLBACK (or perhaps a better name), that acts like LIB_ACL if the xattr library is absent and the acl library is present, and is empty otherwise. Perhaps Bruno has an opinion here. I'm not sure how well lib-ignore would work for packages that build libraries rather than apps. > It depends on a kernel ACL implementation. On Linux the ACLs make the permissions only more opened (hence my code would be fine). > In contrast, on Solaris/ZFS, the opposite could happen. Ouch, in that case perhaps we should not use the new code on Solaris. Solaris is a dead end now anyway, no point trying to make it go faster. What about OpenZFS on GNU/Linux? That's more important. > NetApp NFSv4 server even allows you to break RFC7530 the way that chmod 0 will still allow the inherited ACLs to be applied. We should be OK there, right? We do the chmod 0 first.