From: "Tim Rühsen" <tim.ruehsen@gmx.de>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org
Subject: Re: Fix memleak in getdelim.m4
Date: Wed, 20 May 2020 23:59:18 +0200 [thread overview]
Message-ID: <e97c6577-7167-2b02-8b67-8e1a63701811@gmx.de> (raw)
In-Reply-To: <3816106.4I1b13x7fG@omega>
[-- Attachment #1.1: Type: text/plain, Size: 1976 bytes --]
Hi Bruno,
On 18.05.20 21:44, Bruno Haible wrote:
> Hi Tim,
>
>>> The way to determine the answer is:
>>> 1. Create a test dir of all gnulib modules.
>>> 2. Configure it with --config-cache.
>>> 3. Configure it with --config-cache and your sanitizer options.
>>> 4. Compare the generated config.cache and config.status files.
>>
>> I am short on time and would like to prevent being distracted too much
>
> Everyone here is probably in the same situation...
>
>> If you could give me a quick instruction on how to do 1.
>
> I typically use this command:
>
> rm -rf ../testdir-all; ./gnulib-tool --create-testdir --dir=../testdir-all --single-configure
>
>> I'll happily
>> go for steps 2-4. I already have a fresh cloned gnulib locally.
>
> Thanks! We can then go through the findings one by one.
With my getdelim patch applied, this is the summary of sanitizer findings:
$ egrep 'SUMM|checking' config.log|grep -B1 SUMM
configure:14038: checking for working C stack overflow detection
SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change
conftest.c:379:30 in
--
configure:36833: checking whether memmem works
SUMMARY: UndefinedBehaviorSanitizer: invalid-null-argument
conftest.c:513:32 in
--
configure:55268: checking whether fchownat works with AT_SYMLINK_NOFOLLOW
SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change
conftest.c:812:50 in
configure:55326: checking whether fchownat works with an empty file name
SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change
conftest.c:817:37 in
--
configure:67322: checking whether glob lists broken symlinks
SUMMARY: AddressSanitizer: 37 byte(s) leaked in 2 allocation(s).
--
configure:94107: checking for working re_compile_pattern
SUMMARY: AddressSanitizer: 20072 byte(s) leaked in 116 allocation(s).
The lzip'ed tar archive with all 4 files is 137k. Is it ok to send it
here or do you better like via PM ?
Regards, Tim
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-20 22:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 10:43 Fix memleak in getdelim.m4 Tim Rühsen
2020-05-18 11:50 ` Bruno Haible
2020-05-18 18:21 ` Tim Rühsen
2020-05-18 19:44 ` Bruno Haible
2020-05-19 21:47 ` Tim Rühsen
2020-05-19 22:46 ` Bruno Haible
2020-05-20 18:45 ` Tim Rühsen
2020-05-21 14:22 ` relicense module 'group-member' Bruno Haible
2020-05-21 14:44 ` Eric Blake
2020-05-21 15:10 ` Jim Meyering
2020-05-21 19:46 ` Bruno Haible
2020-05-21 19:27 ` Paul Eggert
2020-05-21 14:23 ` Fix memleak in getdelim.m4 Bruno Haible
2020-05-20 21:59 ` Tim Rühsen [this message]
2020-05-21 14:26 ` Bruno Haible
2020-05-21 16:11 ` Tim Rühsen
2020-05-21 19:31 ` Bruno Haible
2020-05-22 14:03 ` Tim Rühsen
2020-05-22 15:25 ` Bruno Haible
2020-05-22 20:46 ` Tim Rühsen
2020-05-23 17:51 ` Fix exponentl.m4 test Bruno Haible
2020-05-23 18:48 ` Fix calloc.m4 test Bruno Haible
2020-05-23 20:26 ` Paul Eggert
2020-05-23 21:53 ` Bruno Haible
2020-05-24 0:51 ` Paul Eggert
2020-05-24 7:53 ` Bruno Haible
2020-06-06 8:19 ` Bruno Haible
2020-05-23 19:18 ` Fix invalid use of __builtin_isnanf and __builtin_isnanl Bruno Haible
2020-05-23 20:18 ` Fix calloc-gnu configure results Bruno Haible
2020-05-23 20:47 ` Fix memleak in getdelim.m4 Bruno Haible
2020-05-24 8:39 ` Tim Rühsen
2020-05-21 15:15 ` SA_RESETHAND Bruno Haible
2020-05-21 20:10 ` SA_RESETHAND Paul Eggert
2020-05-21 20:59 ` SA_RESETHAND Bruno Haible
2020-05-21 15:22 ` Fix sanitizer error in fchownat.m4 Bruno Haible
2020-05-21 17:42 ` Fix memleak in glob.m4 Bruno Haible
2020-05-21 18:31 ` Fix memleak in regex.m4 Bruno Haible
2020-05-21 18:40 ` Fix memleak in getdelim.m4 Bruno Haible
2020-05-21 19:30 ` Paul Eggert
2020-05-21 19:38 ` Bruno Haible
2020-05-21 14:32 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e97c6577-7167-2b02-8b67-8e1a63701811@gmx.de \
--to=tim.ruehsen@gmx.de \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).