From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6A6921F55B for ; Mon, 18 May 2020 10:44:23 +0000 (UTC) Received: from localhost ([::1]:40798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jadFu-0000OF-2b for normalperson@yhbt.net; Mon, 18 May 2020 06:44:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jadFM-0000O7-LV for bug-gnulib@gnu.org; Mon, 18 May 2020 06:43:48 -0400 Received: from mout.gmx.net ([212.227.15.18]:56265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jadFL-0006gY-1j for bug-gnulib@gnu.org; Mon, 18 May 2020 06:43:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1589798625; bh=Q7nuk6EvrjnLWhQRbmiqd26ljL5ugX2ExQQ/F9j63m0=; h=X-UI-Sender-Class:From:To:Subject:Date; b=cNmmJMV4fWoAtXHDTDM1Y0SF0HJF6JdrKORa0WCxRNcfOb8/LkBbtWIDaftnTwBAV fczubsCQry7x4lWPNYbT8aIN4qozmAg/cYCUiqTAcL/kP1AUhKqPjQJKuDbQXxGf2Z bmqslPu8j1PsI5iR8zIOHdRNsPZH+RJZWs0rqdCc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.70] ([95.214.226.173]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKKZ3-1jLzZu0qdD-00LnXR for ; Mon, 18 May 2020 12:43:45 +0200 From: =?UTF-8?Q?Tim_R=c3=bchsen?= Autocrypt: addr=tim.ruehsen@gmx.de; prefer-encrypt=mutual; keydata= mQINBFOsE5ABEADD/k0t8to+R0kPhr2k7d0P/p1SYgxkwSaYgdv4/MgO/yEbQDMsqs1mw88m WnFKKdbH4QUSqCj21SiiJVrcoY7dNNapkKNiaMNCylAxkLtDw9/up0AVdkJ/7iHvrKlwIb3S BQV1oJYBrXF9rzFBtkW9NhLc+DzloeHfPtABCIi0XoIOGSDn+RQvppe/13phBj+2fd5ILNWi HfKIrr6228TynSPqy7H4z5DYcnYIJ7f7FO+MgaZjj28GFCyCFz7DMJsR/JX8CDsaOHvBsBRt BIKSQ7ce9KtAnemsmyGVkaHpGvxo3gaWj8pROIiQRbDYfXXvMbpTYh/OTxbbx3SgBNjk3fH6 ZjYZXuz+1kjJ9aajRKWvhZbMCjKEGjm3n+PrYdd2o9W6j5+aOhSWDs54z7froPmt291NdykF 4kHb3W3SwGaIACV3/ZorrwG8wHhnV8dEwqTrE6xcTIwr2+C07yFDKrSgTbZsjEb6RbZA9SKs j6+ct8TrAxVPAigj7eMdWcF8yxxQCCZci8UIx9hyHAfr4fKCYl0KlG3SoZ8kTKiB0AvjsK+Q owE7gKuHeKOvEn8cb2DiBWjDfJoTO19xhzm51jxcDneIkVoeSg5QJqtiQZybyhf7vP9vl1fS 9O8I9y1uR2lCx7UkWAGTTVTtzs+O47125jsj/BjLMECT/Ub33QARAQABtCBUaW0gUsO8aHNl biA8dGltLnJ1ZWhzZW5AZ214LmRlPokCVAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBByyfbyYYUstWEFkbQgwLbaiZwQoBQJcdtynBQkMjTAXAAoJEAgwLbaiZwQo6DoP /Ah7ARec12d6Aw7vMu/Nbd0eewQt5fwlvXoYoHmpk5uVPhPboUYwtpYFtRlzsq28i7LYtdIZ R2YUXkyMba9YnTjSPeDsK5la/W58QdhdWH69T4AgtdMNyt5kRiYaheuTs5A0MQIFPMjTcqhq 265ceVz/umkk/9tq1daP4/WY4LIRWOGqJOATIObxHRGWU8rohnkc0/3uNCxM0SfXPFrkV5WH LwhLrfE0/edNkJEDpoJViogvu6gFztlejgtB/3N5jlquqSrfih7B5flBBm9ANDPCFtq3K+KJ 62vZj7qrsDM/nrNH8+vbG+iWqbjvFkXP41nUzZca+3BEnP99Ew5bOCX63uYRGHpfRS6nTthk QA6eg/LOVo6yizT0Yoo39Y/93ZE8RB79TEsi5zz6smoUUkHQm5nrBqqUPNfSO9uZwbUhDrSB PKMnfIiOWNzMLTu1ywwdgv2bUjybsTBJVb3IYQMeYj9P/mNHRc706ZIjj0rFbumYVRQe7Fv+ Vff6fPaFhBb83CxCUvwDJ6gF/pPtt78NvUIPCFnLtFkVGdKQe9RQAGa3TxZYRVlo7FcAYYfX dS5PChHkZvocC4ak+Yy1QqdmYNtFqirYrggBdsMdC6DqrEfI4dXzVwh34bNiB+bg7RkOsHr9 vBDwOKhyFujW8WsVlTV/XaGMdbAapq2gZFGLuQINBFOsE5ABEADrLQL3bP7+M6PTCjuVbqqH BDhBAKEEuxKffwDz1AJKfRhvqTYIKQqgZwaIzXdbOkmPrTEgWHJKbwssaRmdBVRSYkE2DXLE cnuxqAgNyc5RMoVHWIE4jFNkxmrN6ZcVWel2OwCo9A6bzUftKKYJRPAYou4nmv87+CdKT16J V40dMG/phLyPINByy9wThIodpJQX/H1O6OCsMM/ZQJQ8zJCXbCCCe/c5gcg6+RJLsNa1CjIj QH0F1XZuncxz3nvKLxXLuQG8HCcU5GxW/z2byjEkoJrlakmcwUzuih7IuFrvSaexb8so2N6u 5H8vm+SBkCwUc28lBsKECOJUeH28CBcMmFuRKFgF/fBpRiXDKI8Fl3IRm5vFIfL6oIBJBSDf unfZ5FPXup5fVGT9k0dhBlD48zDQ22kVVmRkpctxGwd3yE4BM9/sQ3nK4HwrB9+9X2RqxbAz wz8LGvRE7/rusBg9HaO8kIOO/7NjutCvJkHGPfJSF7i9XvBcoQpkTIJFPaxupk7TCFOVDAzU Yh82MzNq89SVe49017/nuXzKJ3SAtok7xDYVsXXriYgnmouL7f+cDXdXmLIxPZN6LKkwKb9/ rU0/9xPuvxS25zCSgjig8/SFEdSt6wvs94npSn6RcmVxi5VN1Ni4IMRgQn7hXpGKATlM6CQ3 2V7QBJN24mFECQARAQABiQI7BBgBCgAmAhsMFiEEHLJ9vJhhSy1YQWRtCDAttqJnBCgFAlx2 3MEFCQyNMDEACgkQCDAttqJnBCivgg/3cc22sESKwJrAc7cfjhxIXvqPseJAnk2lKLuPxfG0 zIozDBPQedz7ACLH0gKGZWzF4qZRLBrEflzM/KXFtkdLhNE6Ezx91X429eCwnki+wfyeDT9X c4neT73Gnx5eD8xKq4QjR7GIUNQFSuLF4BnePyboQYpPRcLuWfUCucnYjdq0abWstPaIp6pj VYmkJUnKv/99rE1NP8+cyxCLKlrV7sQtH5GLaZsCyxJhHKZ+uE0DRfNox3/Dk6tg3MfPLDZz sd7x2ZgT5zTlj0fswuHSMHKkRJXnaHzhjXiF+4FGZk+MsHCW29wS6a8AbW7KRpzGmsdjroKZ mgs8YQnRVlgYKIIp2xkjMhxE7ZVJOW5v2RcTWh9wNB9vMJdgWijnki8+0L7R0aOO1KZRxWjO no6VS2hFwu2Usu1/5XEinl0iVa+iPbq/Yt3omWXD5N20uIO2hGakj/sw87ndzdZRdy6ANZCT 4WrjxWsR/qF2xiJF8gArgG8G2VZk0O3fUEaAISlnETJsvTGBQs4KAQkwiX4QjtG1Oa5RDOod jPEChMBomPeNEDk+vsosjV0Q24t0m4wdrUlgK9skQ3hw/pbqUc27TB4/0FHQ4KNNnyGuQLB6 Gzkku0EgHlNaOS4Htab28LM9cOyPJC5t2XCfQiR477unMkNjgwSjQET9gPWtmTDjvQ== To: bug-gnulib@gnu.org Subject: Fix memleak in getdelim.m4 Message-ID: Date: Mon, 18 May 2020 12:43:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BInJknCBCRnIWN0c8VTPjL3crZdr7EFPY" X-Provags-ID: V03:K1:njv/hvxygP7vFgZdX42qfW7iu+TnmjbCoupdwptb12/K86hpYiR PCCSffSb2ywBsGJ4nhSfqnbwwh0+zXCPDrTqldcFZqAr+49QgULND7O1ssUF2RyIIuIh/Bx QzxUCRH+WRODJgM0B3ubD94e2WUVynTi9+D9Uu7C9oel+VdsoCyJTy53OlyiLQUmiGzNNsb DBEGpUnGe7L4v5EjGEcsw== X-UI-Out-Filterresults: notjunk:1;V03:K0:+wC8EBfXIi0=:Ob27k7Eo+R4E2heiX0OpcE JKz4RgSfEPXfJKb+wImSwDy/zReohAOO0Z89w/wFy5xY3CPJn4bMJJvH0Uoo04sDa7G+IgMUC AospX68eBq1RXgAkPfW9Qf+2jhgp/uxdUmsQ3aN3tebuN03mDjjRtrFd4Ywyb+YDpvii/DrlD nvs7AOpTuyri44YbDbOPOdQc+qITfKvYkW0t3dQrq9rZCqyUhNwU6Ni3uU9xW7ZpAEUfLZlLY REhR2jP/WKXIpUYjWpo8vk1dJsUUFZgD+abiN0ZwBjaY8i4keLXvRCRTamAmPNHJmRP5NhCxH P34Jomitudm3xRSKLY/plFr3NHZ/GahiBdSONwKqOHQQF32sKvyCRk1HQXi1rPZe4SxFGb+rq XbgMITVrS0hpPZUSlwMdiVOKkJtbbgLbKu78TnZsLKJ+7zBW2/v4ZhF4c+QlqCk01ynfIRxBQ kGcjUbUkaV6XreMeCVRR5puZF8quoQgz/qNiydILDkaokB+qNANgNPJNlpNST94MbyS0oOk9V Nxk1NQJPPpoJiPVG6LkKlwaYi0R9wQ9+OvvmD7pWkfb2kAAJxReaJMXzarkZmZpII2Km7QcmZ FUQH2Vryf+VJOxRBQ4cvRC/sXkxMUuqFyeRLKDQXEjHeWeK4LeJDLIrz9njo0ROH/6wbt72Y8 gYIsmQ+BazqfbxiyjBcEGji3Zak0U8zU+8nAmTkQqfxABDCseTp5Ery15+l7pyqNUKEcUbbOS pVPSYSZ+dUG6RF+XS0GdTmAEgY9zcA2N9fnPXWg2K26QpDmmIH4AiHJ95yidl0c3j4iGm7ERA gz14hSLs/jYWmbW80AL9URnWvjxIf2Jn3B1TaH6UiwCuKViTak2poU0gIFW2A5ck2NYijKAYU jNv8O4MM73WkYr/SVOV3LdWb8bL5pb4dF3J6028J0TLGRgnUKeSJ83C/uhp+VTAcfjXrA3jPY DCSdmqCi8gmWx0M/wHwvlQYYSYtbR+Gmu1xrJIaKFHWE3YMhgkbQQMjqAcRG9YGlc27VRrA8s EGIbMtBsHAMgjBVlG+XPyoQ4taioDf5GpMmUgBZvEK2niG4KRMX+ft4L++cmkps2n3QG+ki6W OW8OOqz0A48eBwV7FaFOUp2q+OxNPMeBD6UtreC6esWlnKrubieZCEH5VJ8EvcXJbA+23+gEN p2arwAH8R0zRq4jM4BkG28M28NbFX3lU0Nv2rLQijiF6gzPfjL/DedILV546/hqjX3oGrx93r KV/pY3p0LV0X1mWYv Received-SPF: pass client-ip=212.227.15.18; envelope-from=tim.ruehsen@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/18 06:43:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BInJknCBCRnIWN0c8VTPjL3crZdr7EFPY Content-Type: multipart/mixed; boundary="Lubb2hd005mwilJjrkTRQnZXbaxKcLraC" --Lubb2hd005mwilJjrkTRQnZXbaxKcLraC Content-Type: multipart/mixed; boundary="------------09EFF1E4C9802CF4728ACBEC" Content-Language: en-US This is a multi-part message in MIME format. --------------09EFF1E4C9802CF4728ACBEC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable With leak sanitizer on, the test for getdelim fails due to a memory leak.= The attached patch fixes it. (Please feel free to amend.) Regards, Tim Output from config.log: configure:26259: checking for working getdelim function configure:26325: gcc-10 -o conftest -O1 -g -fno-omit-frame-pointer -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize =3Dundefined,bool,alignment,null,enum,address,leak,nonnull-attribute -fno-sanitize-recover=3Dall -fsanitize-address-use-afte r-scope conftest.c >&5 configure:26325: $? =3D 0 configure:26325: ./conftest =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D551573=3D=3DERROR: LeakSanitizer: detected memory leaks Direct leak of 120 byte(s) in 1 object(s) allocated from: #0 0x7fb818f56e8f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.6+0xa9e8f) #1 0x7fb8183f51bf in _IO_getdelim /build/glibc-WZtAaN/glibc-2.30/libio/iogetdelim.c:62 #2 0x7fb8198dd72f () SUMMARY: AddressSanitizer: 120 byte(s) leaked in 1 allocation(s). configure:26325: $? =3D 1 configure: program exited with status 1 --------------09EFF1E4C9802CF4728ACBEC Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-memleak-in-getdelim-C-code-to-pacify-leak-saniti.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-Fix-memleak-in-getdelim-C-code-to-pacify-leak-saniti.pa"; filename*1="tch" =46rom 0b9451c7c8919121df67b71fdd2f993605c1abc1 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Tim=3D20R=3DC3=3DBChsen?=3D Date: Mon, 18 May 2020 12:36:16 +0200 Subject: [PATCH] Fix memleak in getdelim C code to pacify leak sanitizer --- ChangeLog | 4 ++++ m4/getdelim.m4 | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 9551d9934..2f7d6d4bb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2020-05-18 Tim R=C3=BChsen + + * m4/getdelim.m4: Fix memleak. + 2020-05-17 Bruno Haible =20 Clarify intended usage of the license file modules. diff --git a/m4/getdelim.m4 b/m4/getdelim.m4 index 9f4c7f6e9..ac3917b11 100644 --- a/m4/getdelim.m4 +++ b/m4/getdelim.m4 @@ -1,4 +1,4 @@ -# getdelim.m4 serial 14 +# getdelim.m4 serial 15 =20 dnl Copyright (C) 2005-2007, 2009-2020 Free Software Foundation, Inc. dnl @@ -42,6 +42,7 @@ AC_DEFUN([gl_FUNC_GETDELIM], int len =3D getdelim (&line, &siz, '\n', in); if (!(len =3D=3D 4 && line && strcmp (line, "foo\n") =3D=3D 0)) { free (line); fclose (in); return 2; } + free (line); } { /* Test result for a NULL buffer and a non-zero size. --=20 2.26.2 --------------09EFF1E4C9802CF4728ACBEC-- --Lubb2hd005mwilJjrkTRQnZXbaxKcLraC-- --BInJknCBCRnIWN0c8VTPjL3crZdr7EFPY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHLJ9vJhhSy1YQWRtCDAttqJnBCgFAl7CZuAACgkQCDAttqJn BCh9kRAAt/bAQNX6kc9tFrIOQn2jL4otcPHAPj/4JnsCrLjLSnoB00I3uB4PI21i GhfTd/B/rrI+/5McbaCIjOr4aOe2ka5ffH+oVZtJbNyn2mkScNYiJAjZEtLy9/I1 /eTt+xssA7KMNF3hVx0aRlaj0jDSFtkuAN8Q2JW/B6NneTAYDqtLb4SE5wr6og4L 00KuiByiOczGpRqKipcbx/W6JhURnQJBmRLx7dZjssCtuWIisEWpQTmZupzkiptt HbDRyGjGzktDf2jjgkfbkXSqmJO9l4EZ+MHkixBHA1B0wefP6dDrzzHkBJ+78rpf pC7m4IDkoafD96BDPpsGHgqtBk1Pc2PK8K29BmETqWD3vyrhHuPTR7ufjBZ+0/xW OAX/e4KOTcU7rcIRvtXATV0q1HoBx1eiXA3Qtx+bIm8MyiOAfEAK3iQBDCkvxG6q 9fKZ+D6W4BTT+1vf28p583Mm4DAyIyBcCfcWX6mkWo2AfuFGu1tg5sNT6KywaoxK v8uBNbQe9adSYy/UnRTCEGS5jeuHNvgSwju7EQRQc3aOLcXFmMrUwMffdjErSHHi mxhlmk7eeuDU87t6Y+x6VUNH2RAl6YWnq8l5PQmRkCTLJsJn2zybv1/kBKsfs1F/ x4bquU3I3dbD3LjRXZLa/7j09uNk/AQk7xiObEU28gNZqupuRp0= =2QAD -----END PGP SIGNATURE----- --BInJknCBCRnIWN0c8VTPjL3crZdr7EFPY--