From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-5.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7D2771F953 for ; Fri, 26 Nov 2021 00:10:26 +0000 (UTC) Received: from localhost ([::1]:50630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqOor-0005Vb-AG for normalperson@yhbt.net; Thu, 25 Nov 2021 19:10:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqOom-0005VT-I6 for bug-gnulib@gnu.org; Thu, 25 Nov 2021 19:10:20 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:60529) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqOok-0002vv-FQ for bug-gnulib@gnu.org; Thu, 25 Nov 2021 19:10:20 -0500 Received: from [192.168.101.10] ([91.1.221.176]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mqrjz-1mDCBP2EhV-00mu0k; Fri, 26 Nov 2021 01:10:02 +0100 Content-Type: multipart/mixed; boundary="------------Wqkh9NH85fMsRnRrtdER8yB0" Message-ID: Date: Fri, 26 Nov 2021 01:10:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: tests: dis/allow '.' in PATH? Content-Language: en-US To: Paul Eggert , Kamil Dudka References: <7efa54e6-e6dc-822b-8eaa-18177a52b0a1@bernhard-voelker.de> <5769878.lOV4Wx5bFT@nbkamil> <2f575bd5-8259-1e27-10eb-428060a2e34e@bernhard-voelker.de> <4340739c-a574-65e4-ec60-d27df4f961f8@cs.ucla.edu> From: Bernhard Voelker In-Reply-To: <4340739c-a574-65e4-ec60-d27df4f961f8@cs.ucla.edu> X-Provags-ID: V03:K1:7zKI+KWACC6FcOEB7yaUd/2Zs3VIVXp8zSZpuDoFJ/Qw+5qUbLp WIJ/kQXrGIqGRu8UZzKxN9UIq211wo54aV9JEbfd/E/vtzn4p6fQcLFiIeo7jaYZj0rrTnZ s1XxPnek52XWr1dscw3KsN/ZCI9M3HklsUpe13zbYAOtTG/f7fWdyZrySRZKZeUnw1dgKiI s1fi9yJaS90w9q9Tggl6A== X-UI-Out-Filterresults: notjunk:1;V03:K0:AUDWjX6coK8=:0ea4yBRSgP7gNpNjtwdsIa QG2wiH6Y71QsyDzUEGnrLrgdABpwVICos5rWXSrkM3vlJaOBn8TBt5a+x7292vn/eywL6Y82r o8Z+wtIS1DMcnGs4uOmwyy2EyXbT330YBY42eZMo4uNGMcmf0LOR9j53ui8rpNrUV+Ydi9fEl Vv0NtcaQAbXZKGsw9gMe0Afc2KBwnQMy0cxOgHyI67c8Hk/uW5LUoBvj+NGZGzwa+0259QCjK xjC+Cirhak98PAvKbfqE4Upu+lGKqn6t97waYJV5ei1xIGTd1FmStTthghVKlgx6Fo+VQoPg6 VchB2L9Zo2YLSjoh3Zc5XdjXOjl8xSp5vwFyDG6Iyr3nAr6ahECqiSkC0tqvuC/Ijd5yz3lou DJGOdDP2k0CqRJOCQU0vcJTDg1pwK9RSS4ENgCPLQPoPz4Rjavf1+z5GSiKanIkpcZ/yszlMy bMg4SfoWrdtfKdaT3PlD2dQZmRAwl+EN8Sb+Ww5F4WZ1JUAuftzrfvkshoRtDcSez+99xzKDA ekcNeR4qmKH9MDyjRNfdNATmkgHC9RmPE/wXFJk2U/37D4qTxtL6SGAsPJNFAznM9zjm+OhAm amopkf4hBdd3PJsUFsKk+38lbcSSmrCQUyZ7ATmXhsDkiYf4xN9dWfxDip4niRXJfpPQdE5qE bPcDgaglQ3bwiSE0rLKJB8i0AxQJfeNpASOQLQw2w/093jzgHaLdFORyqLZtpNBwe+esEMtNy eY93hPIuyEQnQut0 Received-SPF: none client-ip=217.72.192.73; envelope-from=mail@bernhard-voelker.de; helo=mout.kundenserver.de X-Spam_score_int: -59 X-Spam_score: -6.0 X-Spam_bar: ------ X-Spam_report: (-6.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-4.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" This is a multi-part message in MIME format. --------------Wqkh9NH85fMsRnRrtdER8yB0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/25/21 00:54, Paul Eggert wrote: > On 11/24/21 15:03, Bernhard Voelker wrote: > Something like the following untested code. This removes all relative > names from PATH, not just '.'. Good idea. Looking at some code from coreutils, I also suggest to test if the entries exist. > saved_IFS=$IFS > IFS=: > new_PATH= > for dir in $PATH; do > case $dir in > /*) new_PATH=$new_PATH${new_PATH:-:}$dir;; _______________________________________^^ This operator doesn't do what we need here. PFA the revised patch. Thanks & have a nice day, Berny --------------Wqkh9NH85fMsRnRrtdER8yB0 Content-Type: text/x-patch; charset=UTF-8; name="0001-test-framework-sh-remove-unsafe-entries-from-PATH.patch" Content-Disposition: attachment; filename*0="0001-test-framework-sh-remove-unsafe-entries-from-PATH.patch" Content-Transfer-Encoding: base64 RnJvbSBkNTA5MTJiNmM2MDczMjQ3NmJiMjk1NWQ5NDdiYWNiNzNhYWEyZDU5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuaGFyZCBWb2Vsa2VyIDxtYWlsQGJlcm5oYXJk LXZvZWxrZXIuZGU+CkRhdGU6IFdlZCwgMjQgTm92IDIwMjEgMjM6NTk6MDAgKzAxMDAKU3Vi amVjdDogW1BBVENIXSB0ZXN0LWZyYW1ld29yay1zaDogcmVtb3ZlIHVuc2FmZSBlbnRyaWVz IGZyb20gUEFUSAoKUnVubmluZyB0ZXN0cyB3aXRoICcuJyBpbiB0aGUgUEFUSCBtYXkgeWll bGQgdW5zcGVjaWZpZWQgcmVzdWx0cywKYW5kIGlzIGRlZW1lZCB1bnNhZmUgcGVyIHNlLiAg VGhpcyBpbmNsdWRlcyBlbXB0eSBlbnRyaWVzIGFzIHdlbGwKd2hpY2ggYXJlIHRyZWF0ZWQg bGlrZSBhICcuJyBlbnRyeSBhcyBwZXIgUE9TSVguCgoqIHRlc3RzL2luaXQuc2ggKHNldHVw Xyk6IEFkZCBzbmlwcGV0IHRvIHJlbW92ZSByZWxhdGl2ZSBhbmQgbm9uLQphY2Nlc3NpYmxl IGVudHJpZXMgZnJvbSB0aGUgUEFUSCBlbnZpcm9ubWVudCB2YXJpYWJsZS4KLS0tCiBDaGFu Z2VMb2cgICAgIHwgIDkgKysrKysrKysrCiB0ZXN0cy9pbml0LnNoIHwgMTcgKysrKysrKysr KysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZTc1MmIyMzguLmVmYmU2Yzg4OCAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBA CisyMDIxLTExLTI1ICBCZXJuaGFyZCBWb2Vsa2VyICA8bWFpbEBiZXJuaGFyZC12b2Vsa2Vy LmRlPgorCisJdGVzdC1mcmFtZXdvcmstc2g6IHJlbW92ZSB1bnNhZmUgZW50cmllcyBmcm9t IFBBVEgKKwlSdW5uaW5nIHRlc3RzIHdpdGggJy4nIGluIHRoZSBQQVRIIG1heSB5aWVsZCB1 bnNwZWNpZmllZCByZXN1bHRzLAorCWFuZCBpcyBkZWVtZWQgdW5zYWZlIHBlciBzZS4gIFRo aXMgaW5jbHVkZXMgZW1wdHkgZW50cmllcyBhcyB3ZWxsCisJd2hpY2ggYXJlIHRyZWF0ZWQg bGlrZSBhICcuJyBlbnRyeSBhcyBwZXIgUE9TSVguCisJKiB0ZXN0cy9pbml0LnNoIChzZXR1 cF8pOiBBZGQgc25pcHBldCB0byByZW1vdmUgcmVsYXRpdmUgYW5kIG5vbi0KKwlhY2Nlc3Np YmxlIGVudHJpZXMgZnJvbSB0aGUgUEFUSCBlbnZpcm9ubWVudCB2YXJpYWJsZS4KKwogMjAy MS0xMS0yNCAgUGF1bCBFZ2dlcnQgIDxlZ2dlcnRAY3MudWNsYS5lZHU+CiAKIAlyZWdleDog bWVyZ2UgZnJvbSBnbGliYwpkaWZmIC0tZ2l0IGEvdGVzdHMvaW5pdC5zaCBiL3Rlc3RzL2lu aXQuc2gKaW5kZXggOWVmODM0ODg4Li5hOTc1NTkyZmYgMTAwNjQ0Ci0tLSBhL3Rlc3RzL2lu aXQuc2gKKysrIGIvdGVzdHMvaW5pdC5zaApAQCAtNDI2LDYgKzQyNiwyMyBAQCBzZXR1cF8g KCkKICAgZm9yIHNpZ18gaW4gMSAyIDMgMTMgMTU7IGRvCiAgICAgZXZhbCAidHJhcCAnRXhp dCAkKGV4cHIgJHNpZ18gKyAxMjgpJyAkc2lnXyIKICAgZG9uZQorCisgICMgUmVtb3ZlIHJl bGF0aXZlIGFuZCBub24tYWNjZXNzaWJsZSBkaXJlY3RvcmllcyBmcm9tIFBBVEgsIGluY2x1 ZGluZyAnLicKKyAgIyBhbmQgWmVyby1sZW5ndGggZW50cmllcy4KKyAgc2F2ZWRfSUZTPSIk SUZTIgorICBJRlM9OgorICBuZXdfUEFUSD0KKyAgc2VwXz0KKyAgZm9yIGRpciBpbiAkUEFU SDsgZG8KKyAgICBjYXNlICIkZGlyIiBpbgorICAgICAgLyopIHRlc3QgLWQgIiRkaXIvLiIg fHwgY29udGludWUKKyAgICAgICAgICBuZXdfUEFUSD0iJHtuZXdfUEFUSH0ke3NlcF99JHtk aXJ9IgorICAgICAgICAgIHNlcF89JzonOzsKKyAgICBlc2FjCisgIGRvbmUKKyAgSUZTPSIk c2F2ZWRfSUZTIgorICBQQVRIPSIkbmV3X1BBVEgiCisgIGV4cG9ydCBQQVRICiB9CiAKICMg VGhpcyBpcyBhIHN0dWIgZnVuY3Rpb24gdGhhdCBpcyBydW4gdXBvbiB0cmFwICh1cG9uIHJl Z3VsYXIgZXhpdCBhbmQKLS0gCjIuMzQuMAoK --------------Wqkh9NH85fMsRnRrtdER8yB0--