From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E88D91F47C for ; Sun, 15 Jan 2023 01:52:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=cs.ucla.edu header.i=@cs.ucla.edu header.a=rsa-sha256 header.s=78364E5A-2AF3-11ED-87FA-8298ECA2D365 header.b=VS9PlYur; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGsBx-0003vq-En; Sat, 14 Jan 2023 20:52:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGsBt-0003um-Pj for bug-gnulib@gnu.org; Sat, 14 Jan 2023 20:52:11 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGsBp-0006ME-EC for bug-gnulib@gnu.org; Sat, 14 Jan 2023 20:52:07 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 798C8160040; Sat, 14 Jan 2023 17:52:02 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Ruo9m9rlDytA; Sat, 14 Jan 2023 17:52:00 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1B714160041; Sat, 14 Jan 2023 17:52:00 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 1B714160041 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1673747520; bh=zbK2d7Byw8hmjkQtOMJ4I+jQ3BoOqWPvZnNq2Rys/ag=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:From; b=VS9PlYurxcF/XCrCnBEBkaG3ZU288e3GZ40C9MzSBCrOhg81NU83gYhrMvAVL8XFD eA8y7bqAtg+xvo+OhSaxWWb9nAfPiGQezOwVG+qbfFHOkcV3R05Pb4KU29W8M7ufKe rmzpBFGOPzPF0OGqk/GrzGxGY20YaxWE9RXekwOs= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9S4llKi9mxzu; Sat, 14 Jan 2023 17:51:59 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C853C160040; Sat, 14 Jan 2023 17:51:59 -0800 (PST) Content-Type: multipart/mixed; boundary="------------PJxXwUlRVLXhXKWxGeVOMqiF" Message-ID: Date: Sat, 14 Jan 2023 17:51:59 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2] Define alignof_slot using _Alignof when using C11 or newer Content-Language: en-US To: Khem Raj References: <20230115012007.2175339-1-raj.khem@gmail.com> Cc: bug-gnulib@gnu.org From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <20230115012007.2175339-1-raj.khem@gmail.com> Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org This is a multi-part message in MIME format. --------------PJxXwUlRVLXhXKWxGeVOMqiF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-01-14 17:20, Khem Raj wrote: > +/* GCC releases before GCC 4.9 had a bug in _Alignof. See GCC bug 52023 > +. > + clang versions < 8.0.0 have the same bug. */ > +#elif (!defined __STDC_VERSION__ || __STDC_VERSION__ < 201112 \ > + || (defined __GNUC__ && __GNUC__ < 4 + (__GNUC_MINOR__ < 9) \ > + && !defined __clang__) \ > + || (defined __clang__ && __clang_major__ < 8)) We already have two copies of that stuff elsewhere (in lib/stdalign.in.h and m4/stdalign.m4), for reasons that currently escape me. Let's not balloon the number of copies to three. I installed the attached smaller patch which should do the trick for C. Is there a similar problem with C++. --------------PJxXwUlRVLXhXKWxGeVOMqiF Content-Type: text/x-patch; charset=UTF-8; name="0001-alignof-port-to-strict-C23.patch" Content-Disposition: attachment; filename="0001-alignof-port-to-strict-C23.patch" Content-Transfer-Encoding: base64 RnJvbSAyZDQwNGM3ZGQ5NzRjYzY1Zjg5NDUyNmY0YTFiNzZiYzFkY2Q4ZDgyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDE0IEphbiAyMDIzIDE3OjQ4OjE4IC0wODAwClN1YmplY3Q6IFtQQVRD SF0gYWxpZ25vZjogcG9ydCB0byBzdHJpY3QgQzIzCgpQcm9ibGVtIHJlcG9ydGVkIGJ5IEto ZW0gUmFqIGluOgpodHRwczovL2xpc3RzLmdudS5vcmcvci9idWctZ251bGliLzIwMjMtMDEv bXNnMDAxMTEuaHRtbAoqIGxpYi9hbGlnbm9mLmggKGFsaWdub2Zfc2xvdCkgWyFfX2NwbHVz cGx1c106IFVzZSBDMjMtc3R5bGUgYWxpZ25vZi4KKiBtb2R1bGVzL2FsaWdub2YgKERlcGVu ZHMtb24pOiBBZGQgc3RkYWxpZ24uCi0tLQogQ2hhbmdlTG9nICAgICAgIHwgNiArKysrKysK IGxpYi9hbGlnbm9mLmggICB8IDQgKystLQogbW9kdWxlcy9hbGlnbm9mIHwgMSArCiAzIGZp bGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMDkwMGM1NGMxZC4uZmE2ODQxMzFk YiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDEx IEBACiAyMDIzLTAxLTE0ICBQYXVsIEVnZ2VydCAgPGVnZ2VydEBjcy51Y2xhLmVkdT4KIAor CWFsaWdub2Y6IHBvcnQgdG8gc3RyaWN0IEMyMworCVByb2JsZW0gcmVwb3J0ZWQgYnkgS2hl bSBSYWogaW46CisJaHR0cHM6Ly9saXN0cy5nbnUub3JnL3IvYnVnLWdudWxpYi8yMDIzLTAx L21zZzAwMTExLmh0bWwKKwkqIGxpYi9hbGlnbm9mLmggKGFsaWdub2Zfc2xvdCkgWyFfX2Nw bHVzcGx1c106IFVzZSBDMjMtc3R5bGUgYWxpZ25vZi4KKwkqIG1vZHVsZXMvYWxpZ25vZiAo RGVwZW5kcy1vbik6IEFkZCBzdGRhbGlnbi4KKwogCXRlc3QtZnJhbWV3b3JrLXNoOiB3b3Jr IGFyb3VuZCBBSVggNy4yIGRpZmYgYnVncwogCSogdGVzdHMvaW5pdC5zaCAoY29tcGFyZV9k ZXZfbnVsbF8pOiBSdW4gZGlmZiBpbiB0aGUgQyBsb2NhbGUuCiAJQUlYIDcuMiBkaWZmIG1l c3NlcyB1cCBpbiBVVEYtOCBsb2NhbGVzOyBmb3IgZXhhbXBsZSwKZGlmZiAtLWdpdCBhL2xp Yi9hbGlnbm9mLmggYi9saWIvYWxpZ25vZi5oCmluZGV4IDUwNWFkOTdhYTQuLjJkZWQxYzc4 ODQgMTAwNjQ0Ci0tLSBhL2xpYi9hbGlnbm9mLmgKKysrIGIvbGliL2FsaWdub2YuaApAQCAt MjIsMTQgKzIyLDE0IEBACiAvKiBhbGlnbm9mX3Nsb3QgKFRZUEUpCiAgICBEZXRlcm1pbmUg dGhlIGFsaWdubWVudCBvZiBhIHN0cnVjdHVyZSBzbG90IChmaWVsZCkgb2YgYSBnaXZlbiB0 eXBlLAogICAgYXQgY29tcGlsZSB0aW1lLiAgTm90ZSB0aGF0IHRoZSByZXN1bHQgZGVwZW5k cyBvbiB0aGUgQUJJLgotICAgVGhpcyBpcyB0aGUgc2FtZSBhcyBhbGlnbm9mIChUWVBFKSBh bmQgX0FsaWdub2YgKFRZUEUpLgorICAgVGhpcyBpcyB0aGUgc2FtZSBhcyBhbGlnbm9mIChU WVBFKS4KICAgIE5vdGU6IFRoZSByZXN1bHQgY2Fubm90IGJlIHVzZWQgYXMgYSB2YWx1ZSBm b3IgYW4gJ2VudW0nIGNvbnN0YW50LAogICAgZHVlIHRvIGJ1Z3MgaW4gSFAtVVggMTAuMjAg Y2MgYW5kIEFJWCAzLjIuNSB4bGMuICAqLwogI2lmIGRlZmluZWQgX19jcGx1c3BsdXMKICAg dGVtcGxhdGUgPGNsYXNzIHR5cGU+IHN0cnVjdCBhbGlnbm9mX2hlbHBlciB7IGNoYXIgX19z bG90MTsgdHlwZSBfX3Nsb3QyOyB9OwogIyBkZWZpbmUgYWxpZ25vZl9zbG90KHR5cGUpIG9m ZnNldG9mIChhbGlnbm9mX2hlbHBlcjx0eXBlPiwgX19zbG90MikKICNlbHNlCi0jIGRlZmlu ZSBhbGlnbm9mX3Nsb3QodHlwZSkgb2Zmc2V0b2YgKHN0cnVjdCB7IGNoYXIgX19zbG90MTsg dHlwZSBfX3Nsb3QyOyB9LCBfX3Nsb3QyKQorIyBkZWZpbmUgYWxpZ25vZl9zbG90KHR5cGUp IGFsaWdub2YgKHR5cGUpCiAjZW5kaWYKIAogLyogYWxpZ25vZl90eXBlIChUWVBFKQpkaWZm IC0tZ2l0IGEvbW9kdWxlcy9hbGlnbm9mIGIvbW9kdWxlcy9hbGlnbm9mCmluZGV4IDQzNDVl YWNhMTIuLmM3OGFiNGEzYzUgMTAwNjQ0Ci0tLSBhL21vZHVsZXMvYWxpZ25vZgorKysgYi9t b2R1bGVzL2FsaWdub2YKQEAgLTUsNiArNSw3IEBAIEZpbGVzOgogbGliL2FsaWdub2YuaAog CiBEZXBlbmRzLW9uOgorc3RkYWxpZ24KIAogY29uZmlndXJlLmFjOgogCi0tIAoyLjM3LjIK Cg== --------------PJxXwUlRVLXhXKWxGeVOMqiF--