bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: "Pádraig Brady" <P@draigBrady.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Gnulib bugs <bug-gnulib@gnu.org>, coreutils@gnu.org
Subject: Re: coreutils and GCC -fanalyzer
Date: Sat, 11 Jul 2020 15:26:20 +0100	[thread overview]
Message-ID: <c15467cb-5fec-71b7-ef3c-67ae730a26be@draigBrady.com> (raw)
In-Reply-To: <d9f850e2-f328-0969-bfad-598b3cef0d9e@cs.ucla.edu>

On 11/07/2020 01:58, Paul Eggert wrote:
> On 7/10/20 2:21 PM, Pádraig Brady wrote:
>>
>> I'd be inclined to not enable -fanalyzer by default.
>> At least not until it matures more.
>> -fanalyzer didn't find any actual issues in coreutils,
> 
> Yes, the only bug I found related to coreutils:
> 
> https://gmplib.org/list-archives/gmp-bugs/2020-July/004844.html
> 
> is a bug in library code that coreutils never triggers.
> 
>> I'd be inclined to not enable -fanalyzer by default.
> 
> I installed the attached patch into coreutils; will that do? The basic idea is
> that you get -fanalyzer only if you configure with the new
> --enable-gcc-warnings=expensive option.

That's better, for coreutils at least.
It's good that you included all fanalyzer related options set by gnulib,
as that allows projects to more easily control those themselves.

thanks!
Pádraig


      reply	other threads:[~2020-07-11 14:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <edfafbde-9e71-f8a9-600d-23cdfaee52a5@cs.ucla.edu>
     [not found] ` <77400f8a-59ca-6d02-e5b1-e01ba0619237@draigBrady.com>
     [not found]   ` <a554e905-fa73-6618-90d7-ae3cb136e19d@cs.ucla.edu>
     [not found]     ` <e551aac0-e2fe-920a-d0ea-ca80695283d0@draigBrady.com>
     [not found]       ` <4aa67590-a0c3-603d-d2b1-f0751a28df29@cs.ucla.edu>
     [not found]         ` <3a074086-47f7-638f-50a8-cd7ceb46a11a@draigBrady.com>
2020-05-23 16:08           ` coreutils and GCC -fanalyzer Paul Eggert
2020-05-23 16:22             ` Tim Rühsen
2020-07-02  0:26             ` Paul Eggert
2020-07-10 21:21               ` Pádraig Brady
2020-07-10 21:37                 ` Jeffrey Walton
2020-07-11  0:58                 ` Paul Eggert
2020-07-11 14:26                   ` Pádraig Brady [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c15467cb-5fec-71b7-ef3c-67ae730a26be@draigBrady.com \
    --to=p@draigbrady.com \
    --cc=bug-gnulib@gnu.org \
    --cc=coreutils@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).