From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id ED76D1F4B4 for ; Thu, 21 Jan 2021 18:22:42 +0000 (UTC) Received: from localhost ([::1]:57536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2ebR-0000Jh-RP for normalperson@yhbt.net; Thu, 21 Jan 2021 13:22:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2ebA-0000EG-2S for bug-gnulib@gnu.org; Thu, 21 Jan 2021 13:22:25 -0500 Received: from mail-bn8nam12on2123.outbound.protection.outlook.com ([40.107.237.123]:42240 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2eb8-0002tp-2C for bug-gnulib@gnu.org; Thu, 21 Jan 2021 13:22:23 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fb6RdGYTfsSicuijTObJj2n2qSo8BvwPIrrdBONdqGBDyEs5tdjx44s4FnknW0ZnrclSS81NQYHEcfIaG8iHxmDrE6ib1DvUKOXFVZG3uuMRoE18Qh209cSGr3719uWM10pPjnqDg+NS1Mon5UCSgpI4e0uiaf71zylBldtTc1ClcWxrx4ZqqOcjyXhuFBqSGr3nbFyCx5w9PkkbjfyeSUbfPlO3FMkmPaYP2axetYXOT2GFU6bl/GHPJQZJvlm//CwHpr4jvpB9o61yiqX56y5cxgLkTVv5jmeIVbP+Ycv3RyVS2eI1CQM2iQdeYnfo2ZdfDV5VGTzW8HqAoRdsVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hO2kMOtrtd0GSSeawao98OxMzCszhIRGDVDiJ+4QSdQ=; b=TmqcyMAAkqaEWiYmNtZxgEFaFTM7KVD3ye8OdpvhQ3UT1c2cykAywarn9jXXESYNXGI8VrSCMAtp/OW+Hd8RfHhzdzY41bna2ucO7WYozQ5bQPRsKdbG9P3r+UV6FEiNlWrUtOYlH7iBsdRSd9UY12e5pHkcCSI7rUztfdm0tpqRZYtkFhuR598mLPW8KLecfQW9JRjoSzf7DzPaqFx3atRv5w8WjOax2TutNRsVQaPPf9vHdzdgTSTjbU7EOiRIgzgV0ODGha/5ofccHnnHlSNgrBrypuy4YRzbk5eZziMgiZg6Lu2k3PZ7WiD8z7JNy7bsypVLqfl416xDrBav6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hO2kMOtrtd0GSSeawao98OxMzCszhIRGDVDiJ+4QSdQ=; b=Wecu8hYtZqB5LZbQ0j3OYaH0OMYsbrW3s9k2ZXDnwHb5GOT0PCsIX+dCdz3NScOyuty5nqIBfDpBqTz1A91P+AHYTtakZij3O1cPrHKGdraGUDFNj3wML233Da4tsLt3PYvfYdLB7b4Rm4dl7evV24VaNWH/rkfiIiw8ruAKH4U= Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN6PR04MB0531.namprd04.prod.outlook.com (2603:10b6:404:97::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.13; Thu, 21 Jan 2021 18:21:46 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::f071:e174:ef12:375c]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::f071:e174:ef12:375c%6]) with mapi id 15.20.3784.013; Thu, 21 Jan 2021 18:21:46 +0000 Subject: Re: ptsname_r on Cygwin To: Bruno Haible , bug-gnulib@gnu.org References: <3482750.exAXJ2mfqj@omega> From: Ken Brown Message-ID: Date: Thu, 21 Jan 2021 13:21:44 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 In-Reply-To: <3482750.exAXJ2mfqj@omega> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [65.112.130.200] X-ClientProxiedBy: BN9PR03CA0063.namprd03.prod.outlook.com (2603:10b6:408:fc::8) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.13.22.4] (65.112.130.200) by BN9PR03CA0063.namprd03.prod.outlook.com (2603:10b6:408:fc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Thu, 21 Jan 2021 18:21:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d92a585f-b51d-46bd-c461-08d8be396916 X-MS-TrafficTypeDiagnostic: BN6PR04MB0531: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: is0B64WJjn2/NgsUh05+QEkRkdH+Bwzo5aJp91OMD6VhjXku1AjiowISUMm36KZwSg2WBe7b0NPEpiuAPUVvQB9faVHBAwtMgxS9xMaSuVUCfJJaiPWijmzGyhbaxBDkOJbiWvMlzFvFQUbWsmGn34rNcXoG+0CLU8lF7Euu3yd+vX0HmVATN/g7nq0OLhwCyordlTW2d5CaRHyxvaYiV34Ze6cTMH4JJZzsuz8/dYhGUU0eNx2G3SONtScXVlAOKUME2rd2GlYZQcne1w66Pkbps8JzGGNZDOTXBKZ/DrQi2lurkEo+yyYvlAdXF9nmYwHH/0O0VGs5D5N7fK8pFX/7ciR6YzlBep/EGC5lF7JVu1zN+dnCPrecGWOeu4hvpyifMWr/WsF+BlbTuk2Q7i8h3FqVFEgSTgcksqhWD5QhsJ5uo8ceRl7dTxzEqOpV2sysLV2csDREvIg/S25X9VnKp857Qww7yr4yjQ8XPKlC2n3zDhOTDbzoqpKN63378B/0WzgeKhoz4bIgaMSO3v2ZpyIFiqH+HijpP2lW8YL+bWokubXtEua1YdzyArYHetgS+jkKC2F9+/3+eIccfA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(186003)(66946007)(6486002)(83380400001)(2906002)(53546011)(5660300002)(36756003)(16576012)(316002)(26005)(86362001)(7116003)(31686004)(16526019)(31696002)(2616005)(956004)(66476007)(478600001)(52116002)(786003)(75432002)(8936002)(8676002)(66556008)(966005)(45980500001)(43740500002)(460985005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?Windows-1252?Q?2Ps4JQG/DpWuZLyzghu92YOyV+/CBAJPiszdUNe7cfPrnxDqr5YCmyJk?= =?Windows-1252?Q?puUrsQhflRzPcG0su2FjBDoT8VJnLkPjxxkq8rbZUrLNEJe6eFQq8yxI?= =?Windows-1252?Q?qJwueSND7tuKqGiFVql6fwWiit8IM1UIgaeLs13MvWECP7vufJLbvJWN?= =?Windows-1252?Q?tFbJEiX1IEnP4IaEjiMV1C9HTMMkKMvwQhgWQ+DpLoyUxiBMoJ2iTuF5?= =?Windows-1252?Q?0rYGm7Ni6M4FSRDhsnWh2GLY7CeraC+vZyN6t2UQ69ISQzsQK8VcfaHA?= =?Windows-1252?Q?3G9p01p/UtLR0+nR4V1GpRO0JV05cUqHlQkLAR/bFW7bxnv2Pde+GkuT?= =?Windows-1252?Q?Lrqyp5wqf1AwI4d7Q+MCbcSbXR42j49ctgSXACmVrSaRrNv/0PGlBUtt?= =?Windows-1252?Q?PIk9CLN2Kq/KQ+Pw3eeGSYlOBgsYOjlMtQLFtH4wcytIs7qlO6UQU6tJ?= =?Windows-1252?Q?BbCh5zcR2zIuYWeW9LO1aKXKVJa4rKPsZsBS5Z/udu5erfnzGT8og68/?= =?Windows-1252?Q?mwTR6OpTfmWxUxwJMxFxG/OvryTn7+m0AS/JLV9TykWBUhphgRhSMgQf?= =?Windows-1252?Q?jLD68BNq86uszHnTHgEzuuRRdTQQ+ttP33wH4oO1DOJ4UCULE1YWkR+/?= =?Windows-1252?Q?EtMTAGdmZUmCi6tUIT5X1d21D3B25WriA3o7stqClX/Kg+ECspZ11JZz?= =?Windows-1252?Q?PgQSBdebvOwh03QQLBiTvf6GeERBFJa7NS+oEwpyYt8jHJNBsf1bK0Ki?= =?Windows-1252?Q?Z3a0f6GkaPoNc0jMp1AFjoVVgLwrmfCK/O+xzz7yJ3OhTYyfLf1OtnYw?= =?Windows-1252?Q?Zi24yVAL19YukmlSGX8HgrTBlrrBGh92rHiujiRFoOn00q4MBK7LVlmw?= =?Windows-1252?Q?k9lGDOnzAnNQv4GAHBIjWQX0jNte0Ae4CGZzWtlP8/q/zcuMftlXj73z?= =?Windows-1252?Q?i+XxSB1ROLA5tU89MlqiGmnzUem4ijb52b6epxWEV9bB+VXrybFLBUNV?= =?Windows-1252?Q?lYST2jSPJniCOYkcQ0s6tpQ4NXJ94pFvJrqF+tpkVflJqQlsvNb0r7jd?= =?Windows-1252?Q?FTh3bBtHRoFj/K/5?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: d92a585f-b51d-46bd-c461-08d8be396916 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2021 18:21:46.0387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e6EQ9mdAggfWiVx62vwLlgOxc1s/RRoo5Q4P+DNHg9vVkn/9XNS6AFnG2Z2Qi4+AQG+kH1T1d6RKlERyoiD7PA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0531 Received-SPF: pass client-ip=40.107.237.123; envelope-from=kbrown@cornell.edu; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Bruno, On 1/20/2021 1:31 AM, Bruno Haible wrote: > Hi Ken, > > On Cygwin 2.9 (64-bit) I see a test failure in test-ptsname_r.c, here: > > { > char buffer[256]; > int result; > > result = ptsname_r (-1, buffer, sizeof buffer); > ASSERT (result != 0); // <======================== HERE > ASSERT (result == EBADF || result == ENOTTY); > } > > While https://www.kernel.org/doc/man-pages/online/pages/man3/ptsname_r.3.html > says that ptsname_r, upon failure, should return an error code, on Cygwin, > it returns 0 and stores the empty string in 'buffer'. > > This causes 2 test failures of Gnulib tests: > > > FAIL: test-ptsname > ================== > > ../../gltests/test-ptsname.c:76: assertion 'result == NULL' failed > FAIL test-ptsname.exe (exit status: 134) > > FAIL: test-ptsname_r > ==================== > > ../../gltests/test-ptsname_r.c:126: assertion 'result != 0' failed > FAIL test-ptsname_r.exe (exit status: 134) Thanks for the report. I've submitted a patch that fixes this: https://cygwin.com/pipermail/cygwin-patches/2021q1/010995.html Ken