From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E9E9E1F45A for ; Sat, 29 Oct 2022 22:20:38 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="i/v0eziV"; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oouBf-0007Jx-Ct; Sat, 29 Oct 2022 18:20:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oouBd-0007IB-5K; Sat, 29 Oct 2022 18:20:17 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oouBb-0005jc-Io; Sat, 29 Oct 2022 18:20:16 -0400 Received: by mail-wr1-x42f.google.com with SMTP id h9so11057670wrt.0; Sat, 29 Oct 2022 15:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=TolCUxtHMPLqeyQyh0GdgjsQJOG5wvcL54XhymI+Ds8=; b=i/v0eziVeDwWFK8D/bRb07y//1PlWjkVa1YsB+YSup99l1MZhRoFJTIMlS3qVUkQPG 6Jo+10SQDUeqN+daAMZDzt3am+ZYQdM+41pkWkwwmz+GcOQntEb4pET0sUBgeLwxE7r9 bffuniSsvC+U2MW9SGBJVuI7UcIcxvQvzEF+sVc05avkG1gTw3j4aOaifcK4IQhfdqEZ ImrX0k9dFhcgGL3sbxU566uuZ93eUQrb0N5ihn8q4OI9rKV0B/FyCImi3XBxV00wponV OcWnkQ6Jc0CSHGrHq4yI3g7314tL5i/8+PXEIznaZMzvypX0qa/SvEqJQTSV6zaxjHj0 tuzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TolCUxtHMPLqeyQyh0GdgjsQJOG5wvcL54XhymI+Ds8=; b=nbi+XzOKVOa+DEvZzB6B+mOilGbcwh49RQ5v4MZ4rJrMO/pjZBGY2eVvYmdXh39NhZ K2PHczRqZ6cx0kW1EospW65wbfExajXJm5Bng5r6wWtjEwk/lorkFse4er8UcwGga7CI ww6r/wv3jmvF2QVs+XeQd+q0NA/9NC7d4vYri+F9lfy9d5kwxYaFsQ3Bcjk/xw35WEWu ar4OZ0+/J/P3Z8m4XBULv57UHH2HCUcgO+1EMPe15JS1quf1G9BahqB/4VQNGQDWU1ap Gr2FAkpQjoXxq2yWjka84LLMMy0Ys9BRJkjejfaxQlDN/ew6q+NPgDvsJSZOFU6+KxvR k8qw== X-Gm-Message-State: ACrzQf1EMfE8KuExypXhS6fGUV1Zqy1pzIwzJvViMAVS76M4hC3/ykPx Q3ZgxC/RVtyX22BCItEXsxs= X-Google-Smtp-Source: AMsMyM7JJNfSVSU5nfK2mKxEbYHcA50TBAm7WmXVIxRLfaW0ATtllBGzA7ImljmnBylYdxTpPwL6VQ== X-Received: by 2002:a5d:62cd:0:b0:236:6ea0:a609 with SMTP id o13-20020a5d62cd000000b002366ea0a609mr3162952wrv.508.1667082013200; Sat, 29 Oct 2022 15:20:13 -0700 (PDT) Received: from localhost (241.84.90.146.dyn.plus.net. [146.90.84.241]) by smtp.gmail.com with ESMTPSA id j10-20020a5d464a000000b002365cd93d05sm2439030wrs.102.2022.10.29.15.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Oct 2022 15:20:12 -0700 (PDT) From: Gavin Smith X-Google-Original-From: Gavin Smith Date: Sat, 29 Oct 2022 23:20:12 +0100 To: Bruno Haible Cc: bug-gnulib@gnu.org, bug-texinfo@gnu.org Subject: Re: Avoid gnulib redefinitions - MDA Message-ID: Mail-Followup-To: Gavin Smith , Bruno Haible , bug-gnulib@gnu.org, bug-texinfo@gnu.org References: <1791297.4MS8fQxZnU@nimes> <8965388.O52NOvI7LO@nimes> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8965388.O52NOvI7LO@nimes> Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=gavinsmith0123@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-gnulib" Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org On Sun, Oct 30, 2022 at 12:09:50AM +0200, Bruno Haible wrote: > Gavin Smith wrote: > > so it sounds like we are better off using #undef before > > including the Perl headers to avoid depending on undocumented > > functionalities. Thanks. > > Using #undef means to decline all corrections done by Gnulib. > These are documented in the manual. In our case, using #undef only avoids a compilation warning about symbols being redefined. Perl itself redefines fdopen and other functions, on MS-Windows at least. (I haven't checked why.) We don't use fdopen, but if we did, it's very likely we would need to use Perl's redefinition for the module to build properly. I don't think we'd be able to use Gnulib redefinitions in any case. The one redefined function from Perl that we do use is "free". Apparently it's necessary to use Perl's version here (on MS-Windows), otherwise there can be weird errors.