From: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
To: Paul Eggert <eggert@cs.ucla.edu>,
"bug-gnulib@gnu.org" <bug-gnulib@gnu.org>,
"kdudka@redhat.com" <kdudka@redhat.com>
Subject: RE: [PATCH] ACL handling simplification + support for NFSv4
Date: Mon, 2 Jan 2023 08:15:52 +0000 [thread overview]
Message-ID: <TYXPR01MB1854DC7DB3B086C0B4A5904CD9F79@TYXPR01MB1854.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <54db8d31-9d85-aa09-4113-0d403f83cacc@cs.ucla.edu>
> What happens if you try to copy ACLs from a filesystem using NFSv4 ACLs to one using POSIXish ACLs, or vice versa?
It fails, we can't do ACL conversion.
> Why is this call needed? Won't a successful attr_copy_file mean that the chmod_or_fchmod is unnecessary? I.e., can't we do the chmod_or_lchmod only if the attr_copy_file fails with a particular errno value that says "this file lacks extended attributes"?
No. ACL only substitute the lower mode bits, we still need to copy the (possible) sticky bits. We also need to copy mode in case no ACL (i.e. no xattrs to copy) presented.
> When these functions fail, what are their errno values and should we treat any of them specially? (I can't easily find documentation for these functions.)
It returns -1, so it behaves the same way as the original function - we do not need to treat it differently.
prev parent reply other threads:[~2023-01-02 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 9:18 [PATCH] ACL handling simplification + support for NFSv4 Ondrej Valousek
2022-12-31 9:00 ` Paul Eggert
2023-01-02 8:15 ` Ondrej Valousek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYXPR01MB1854DC7DB3B086C0B4A5904CD9F79@TYXPR01MB1854.jpnprd01.prod.outlook.com \
--to=ondrej.valousek.xm@renesas.com \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=kdudka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).