From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B192A1F47C for ; Fri, 13 Jan 2023 08:39:11 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=Bb+Gtkqp; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGFaZ-0007Z5-Ap; Fri, 13 Jan 2023 03:39:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFZa-0007Ua-UH for bug-gnulib@gnu.org; Fri, 13 Jan 2023 03:38:05 -0500 Received: from mail-tycjpn01on20706.outbound.protection.outlook.com ([2a01:111:f403:7010::706] helo=JPN01-TYC-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGFZY-0003bg-Tl for bug-gnulib@gnu.org; Fri, 13 Jan 2023 03:38:02 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=imvyJessp+IpTs8uSdaCRIL6BDb9eWOlOkVfY8z8lw29aTjhJ5nbd91fKAV1vbd/+NzF6QWkBGrcBCh079L2iw6MqzDSqYKh/JqI8IwMlifz92nsXQdl5CwXUvI+ukJjixmYyeL6h5DZNY5bOxnjXx6ug4UXTATO+cC6rsZZfNKS8a+D541mOtKj/ax0yJQxu6g4ckYbyc0VhO4lFFvzRgp/n8VPSPj16aXhSZXds9RJBCWYf5SSF0J8l/9p4e2l/D366d0l/21FoP/0cRFH6K6UVM+xI6pzG7ryIYJUvSFHgKuU8q+61htIviB0/Lqsu5Igstgycu9Exqy4n4I8nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O6GkSRaqq5bhPRRFbMCKmQIYWuMu1ZapyC8wF6UjToQ=; b=CzZ/TE6rGmsPwB3xriBEm1XjVAsdqF906w+fm5YhI1twzLkwja0CDYoc5r1hT9EjVBRa2U4LrNbZdaLPpB6yXk9BXQnseQ6TIsICYKiV+VfJJazdY2puTw/IIM8dhUODPYYjB4UnavLVrifTvjuC+EwVVg31HHcPNFIylE64jwuswiqiRontMisgeTiX3YB1z9zYBnmn9riiUKt+zMkhiDyhWWMkjGDWxB7NS9y8oXS+rMCj2dx0HPEPD93cwZcYtRSCEj8pndJ+BCp9PsGLIdclY+tUBRlJ6PQivydviTEvcVo2cWyGH0WNCPSgoaDOdxk3bdRLScWUsBokwbaPdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O6GkSRaqq5bhPRRFbMCKmQIYWuMu1ZapyC8wF6UjToQ=; b=Bb+GtkqpuHkAHAGjPC6F5ZbNna6BjCdHODDJz+m0161/o0KJfXPQg42gkTMnn1RB1f8W6gVXvvFxpp92O0VwXkYGHqgbFYgFTssswFEbuLXmMKu41PRJkIbQqG/vwhC+wm0ukg+SL4d0OcxEKK8sq73/pH6ELOF7SQxzmVimYjg= Received: from TYXPR01MB1854.jpnprd01.prod.outlook.com (2603:1096:403:d::19) by OS0PR01MB5921.jpnprd01.prod.outlook.com (2603:1096:604:ba::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 08:32:48 +0000 Received: from TYXPR01MB1854.jpnprd01.prod.outlook.com ([fe80::588e:988e:be0a:2538]) by TYXPR01MB1854.jpnprd01.prod.outlook.com ([fe80::588e:988e:be0a:2538%6]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 08:32:48 +0000 From: Ondrej Valousek To: Bruno Haible , "bug-gnulib@gnu.org" Subject: RE: [PATCH] Use xattr (Linux) in qcopy-acl.c Thread-Topic: [PATCH] Use xattr (Linux) in qcopy-acl.c Thread-Index: AQHZIEm/0GtwAM3LiUSSLrpeKTj90K6OVh6AgABPJYCAAA/AOoAA0soAgAAAywCAABjEgIAAj7UAgAjHAACAAlREAIAAutUAgAAFEQCAAAUd8A== Date: Fri, 13 Jan 2023 08:32:48 +0000 Message-ID: References: <20230104143425.1235741-1-ondrej.valousek.xm@renesas.com> <3701455.LLGZZu3JSb@nimes> <2140227.aZlQVXGZEW@nimes> <2683844.dfDbWCQSTr@nimes> In-Reply-To: <2683844.dfDbWCQSTr@nimes> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYXPR01MB1854:EE_|OS0PR01MB5921:EE_ x-ms-office365-filtering-correlation-id: d37eafe3-4d43-4ea9-f4ee-08daf540c086 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: djF051FQTCeaDZOxlIGzG4FxaRIWlWdNk3EDmpCXk3yvyTqQ5cSVq4Mz62HuNt+LpDmCjTfGJB+bWl8Gs7v7qFTgE266E/y/+PKZ86zeKrkkyIuFfxlfU2MTsO5fMa/UklK8HvuDb9SX3iqyXQ8h73kn/IlXlmMFKhZhPG46K/w6IrtzORJljthuIgTy8lb6Q2rbTqmcmOcaXwe5oJcA/+/W3lMWx7pJuW1A7GkGVrR2ovgx/hFMOCvtqnFrazVVMUWOxRUHDskHHRxVr3aTmVlRf33wwES6jqDrdvmh9/5u17Sn2TdD+FcTbHvsktq4j9QdaR+wx0FwxeGEeoe8u07Bqy/PXgfTu77KIZV9XMa/H3HAUEJkwuqA4Cr4INpTtx1JFAmGFEvzcJUo02uoR3sNxEuXFf1QRK8hXG24F2oLsZTlMYMEppjjL5Q3ZzRxNi3QqQwUQ2n76c115LSnP9Sn6aEyPriKfxv74N9q6v1SslhUmLzlRFsR/u+ZW6DxrKxS/yns8DvBYb9GRf6KjevOWJjpBPxr52fv+oheiqk4pQkFSL/Sp3ruZ2gg0M66tKRCi/KZg9LNqe3wXMNxgaJnHMUeoOKW/96vWF+66MJm4+e4gEuAk0uV7kK5c9z3TLjNNbKLsTP8juXKJ3WObl5ItwNuoTXne5pp37q3oAhNKjalbcslgjZaNcCFNt3vgoJgRJErODzGTOUepGhb7Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYXPR01MB1854.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(451199015)(122000001)(38100700002)(66556008)(66946007)(76116006)(64756008)(8676002)(66476007)(55016003)(86362001)(186003)(7696005)(33656002)(71200400001)(316002)(38070700005)(66446008)(478600001)(9686003)(26005)(110136005)(2906002)(6506007)(53546011)(52536014)(8936002)(4744005)(41300700001)(5660300002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?MA0XGZEY3iHlbcx+uWHo2wEeBvX46dbgejOfY/4SZHE6N2+j3h4XnABuPf?= =?iso-8859-1?Q?ELjzq8Y9So+OAAZJWMTCzpBCfcf7nYDQGSJdI6FwBURxJTdV3GpT9nw8eH?= =?iso-8859-1?Q?YF+icR+L9aa6Nvfc6T++a6ElVB3Q5medBOa+pt0Qm6YSZqWe/xlzWTF1OY?= =?iso-8859-1?Q?A6lqn7gZ8dAZZEO0aR0edhERMX8TBeE1pjZKYib7IH+B4tAxz4Dq8A1DJ4?= =?iso-8859-1?Q?OCu+RAVGPcFjnr9AnuRTst3MyAnhorrYN8YuEnqx9+4KkxHkdcpdVYbL4u?= =?iso-8859-1?Q?+LinTg5fapAajdv4YZsIQ/VvskTa7oXrZNwk5gDhiHCBvitVjG9zku/TDa?= =?iso-8859-1?Q?eH+2dj2D2iCnHLxR97Qg+/YQHGF1vrrSkvDGgnxKwScVcNLABDAO8Ddkse?= =?iso-8859-1?Q?OBYuBAVSgow7j4eWkZOQL62F9Tlw9lMZUrBKcb9maH6rLBQQ7gxwEH5V9w?= =?iso-8859-1?Q?I3RQ+KIHtElG8fZ0o0sxubsH8Aa8iDTkSOTGyM+qKs02AJTB3R9ssUjuYI?= =?iso-8859-1?Q?l775gCBdyf6iFDlWABq7QSEo/b9EY23rzw19kPZt4m5UsyPVbA4wsvgi5p?= =?iso-8859-1?Q?zrbROymc+jHPV0SJU+UIcXk+YrX4h+gW58z2KpXzEOOSc2U00VJVRj3P08?= =?iso-8859-1?Q?HviVPDbfMLbhDyyBWftw5n33j+OK8ute9xQ1hfnnwj3BLJtUOkktNrCQHd?= =?iso-8859-1?Q?vrcPuUPwGvmT9UX4g5hTWLHH+c7Bn2PV2EnIJjo3/sVi7MdMbvXWaBf3Pp?= =?iso-8859-1?Q?5CQzv87MFyboaDwxFxt80dDOjOdYzhc40c0KxWISmThmsIwIxXoc0MOhm3?= =?iso-8859-1?Q?J32eYtoBm/SbNcPBYP4ldM7qz//MptJqcJdNzkiP4yt6ODeJGfcTdu+Gj+?= =?iso-8859-1?Q?05J3V3I7gDjlxKAw/Qp8pPsTM/6kotWYaLjJClSGp8qX+i2+O95c0T+qii?= =?iso-8859-1?Q?1VZtxhEj/OvEAczy3SFp4zrNzRmSBcpPdSlB1XsyEOzmBYsLR8nHRmPQwv?= =?iso-8859-1?Q?u+dO35Hsp2OTv6ZxLbJCT3s6pX0HiOfZhF2P7G+e0vPMp82041KU/wv2zf?= =?iso-8859-1?Q?fE1yYE+LsyNk9drXN16LCj8wM6dOuXEOVhHtmcNziRXkPCvndBW0Q/Giav?= =?iso-8859-1?Q?bRVwkn9LwFrVhseQ0RHRSKKR9UrTLuiZWrPvYD24WGiZFXnRXBMBuIJf9F?= =?iso-8859-1?Q?JWOUcG+F2HLMoCvGxhpcWcD4VIAETQPZURPHTIXlzgfd/dm5Owu4REpDdh?= =?iso-8859-1?Q?rcqp8G/adUzejt17ga7HOit7lylXMxgY0Qcsb6zXYQFh70kHfdOOso3l5e?= =?iso-8859-1?Q?RvN/R5hhAPQCV+1BjCRL9Wpwrme/h/htCqmwu1k0dypMCAQEcKeYthb/jT?= =?iso-8859-1?Q?g6Ab4yw4wcVcnps+k6zArBpLr5JRAF5013KdVm3xmR+30jnSrN+biod0l8?= =?iso-8859-1?Q?VRLAYEipzrLxCieXyqhaRn7S6+z52STqnMtq+lziIH3AXFEsENYaeUAGwa?= =?iso-8859-1?Q?9Z/v4c/M5AtJZUp+1+w4GB9p7VipkUZiYi1o/tgpSwNeVC/ukVpjmbiB//?= =?iso-8859-1?Q?4YdB1Q1oKud69l8sxRlwkkuYXp7crKhSjfoKjLYaxeRA7bv4TglEKrODR+?= =?iso-8859-1?Q?46CJE0Yjzt6FBoIK0DtPjpKXyynqQTsAA1UIECw7eLchybWm7xWyXMRg?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYXPR01MB1854.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d37eafe3-4d43-4ea9-f4ee-08daf540c086 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2023 08:32:48.2972 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qyqv2XxK6ZIwZeNfXJLkXpUrd330sUa40VvB8et6/Piz3nsSRYE5vWrk4Z70ohD9Zqzevul6KIc/uy9BuhLoJglB3/M6n2On7RUlxZhSOOM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS0PR01MB5921 Received-SPF: pass client-ip=2a01:111:f403:7010::706; envelope-from=ondrej.valousek.xm@renesas.com; helo=JPN01-TYC-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Hi Bruno, Ok thanks for the good finding - my bad. To be honest, I did not test the automake stuff, I only tested the function= ality via coreutils. In coreutils they have their own xattr.m4 which basically does the same. Do I need to resubmit another patch with your changes included? Thanks, Ondrej -----Original Message----- From: Bruno Haible =20 Sent: p=E1tek 13. ledna 2023 9:10 To: bug-gnulib@gnu.org; Ondrej Valousek Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c This part > Also, protect against unsafe use of a configure option value. is needed when the user does ./configure --enable-xattr=3D"no no" In this case we don't want to see an error during configuration: checking for opendir... yes ../configure: line 29819: test: too many arguments checking for raise... yes Always putting $use_attr in double-quotes achieves this. Bruno