From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7A66D1F5A0 for ; Sat, 4 Feb 2023 19:53:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOObJ-0002CA-85; Sat, 04 Feb 2023 14:53:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOObG-0002Bh-RG for bug-gnulib@gnu.org; Sat, 04 Feb 2023 14:53:26 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pOObD-0000yR-Kq for bug-gnulib@gnu.org; Sat, 04 Feb 2023 14:53:25 -0500 Content-Type: multipart/signed; boundary="Apple-Mail=_FC98FC2E-37E7-4F59-81E5-CCBDA546378F"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: coreutils/gnulib - fts.c dangling pointers & gcc 13.1 From: Sam James In-Reply-To: <7cc5a194-7cd8-e88e-c8fe-b7fa4df4af01@cs.ucla.edu> Date: Sat, 4 Feb 2023 19:53:06 +0000 Cc: Peter Frazier , bug-gnulib@gnu.org Message-Id: References: <7B6A1D32-7ECD-4DE0-9E0C-1955F9B756B5@gentoo.org> <7cc5a194-7cd8-e88e-c8fe-b7fa4df4af01@cs.ucla.edu> To: Paul Eggert X-Mailer: Apple Mail (2.3731.300.101.1.3) Received-SPF: pass client-ip=140.211.166.183; envelope-from=sam@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org --Apple-Mail=_FC98FC2E-37E7-4F59-81E5-CCBDA546378F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 4 Feb 2023, at 18:46, Paul Eggert wrote: >=20 > I manually inspected fts.c to look for violations of the C standard = that might draw GCC's attention, and installed the attached patches into = Gnulib. As you can see, they don't fix the technical violations of the C = standard. However, I hope they keep GCC happy. Please give them a try = with "GCC = 13.1".<0001-fts-pacify-GCC-13-Wuse-after-free.patch><0002-fts-pacify-GCC-1= 2-Wstrict-aliasing.patch> For what it's worth, with GCC 13.0.1 20230129, I get no warnings with = --enable-gcc-warnings, and the test suite passes. Ditto =3Dexpensive. But I don't get any with the previous commits either :) As for the patches, I'd consider using #pragma GCC ... to suppress = -Wuse-after-free for the "problematic" lines instead. It'd avoid the risk of either = optimisations or sanitisers respectively causing us pain in future. --Apple-Mail=_FC98FC2E-37E7-4F59-81E5-CCBDA546378F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY963ol8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kKhTAQDglkBbStnmlMDRWXfc0S/Mh+e26I5Tg16TrswvESMr1QD/dh/sBn/oikDI SdUK1aTv1MmZ3jnyzUI+nvR8jN3r0Ac= =pCqM -----END PGP SIGNATURE----- --Apple-Mail=_FC98FC2E-37E7-4F59-81E5-CCBDA546378F--