From: Sam James <sam@gentoo.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Peter Frazier <mrpeterfrazier@gmail.com>, bug-gnulib@gnu.org
Subject: Re: coreutils/gnulib - fts.c dangling pointers & gcc 13.1
Date: Sat, 4 Feb 2023 19:53:06 +0000 [thread overview]
Message-ID: <CF51D6F4-9291-4D36-9DB8-2747D461C699@gentoo.org> (raw)
In-Reply-To: <7cc5a194-7cd8-e88e-c8fe-b7fa4df4af01@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
> On 4 Feb 2023, at 18:46, Paul Eggert <eggert@cs.ucla.edu> wrote:
>
> I manually inspected fts.c to look for violations of the C standard that might draw GCC's attention, and installed the attached patches into Gnulib. As you can see, they don't fix the technical violations of the C standard. However, I hope they keep GCC happy. Please give them a try with "GCC 13.1".<0001-fts-pacify-GCC-13-Wuse-after-free.patch><0002-fts-pacify-GCC-12-Wstrict-aliasing.patch>
For what it's worth, with GCC 13.0.1 20230129, I get no warnings with --enable-gcc-warnings,
and the test suite passes. Ditto =expensive.
But I don't get any with the previous commits either :)
As for the patches, I'd consider using #pragma GCC ... to suppress -Wuse-after-free
for the "problematic" lines instead. It'd avoid the risk of either optimisations or sanitisers
respectively causing us pain in future.
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
next prev parent reply other threads:[~2023-02-04 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:24 coreutils/gnulib - fts.c dangling pointers & gcc 13.1 Peter Frazier
2023-02-03 22:11 ` Paul Eggert
2023-02-04 16:14 ` Sam James
2023-02-04 18:46 ` Paul Eggert
2023-02-04 19:53 ` Sam James [this message]
2023-02-04 20:20 ` Paul Eggert
2023-02-04 20:23 ` Sam James
2023-02-04 22:03 ` Paul Eggert
2023-02-04 22:10 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF51D6F4-9291-4D36-9DB8-2747D461C699@gentoo.org \
--to=sam@gentoo.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mrpeterfrazier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).