bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Roger Pack <rogerdpack@gmail.com>
To: bug-gnulib@gnu.org
Subject: Re: gettimeofday.c windows version?
Date: Sun, 11 Dec 2022 00:05:30 -0700	[thread overview]
Message-ID: <CAPfeOnu0bW=BhgKgusPxbESfzYEdyGnFGjN+=izP7R4gyKvz2g@mail.gmail.com> (raw)
In-Reply-To: <CAPfeOntYnn7+xLnzN8yis4o4aagRaikUqHA0-Kxd7Z5QMfBiWg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

On Sat, Dec 10, 2022 at 11:01 PM Roger Pack <rogerdpack@gmail.com> wrote:

> I received some complaints saying in mingw it was"requiring windows 8" for
> a certain library.
>
> "Entry point not found, GetSystemTimePreciseAsFileTime could not be
> located in the dynamic link library KERNEL32.dll".
>
> mingw appears to have the following:
>
> #define _WIN32_WINNT 0x502
> #define _WIN32_WINNT_WIN8 0x0602
>
> Perhaps the following patch?  Thanks! :)
>
> diff --git a/lib/gettimeofday.c b/lib/gettimeofday.c
> index 36c7920af..428cc4f30 100644
> --- a/lib/gettimeofday.c
> +++ b/lib/gettimeofday.c
> @@ -35,7 +35,7 @@
>  # undef LoadLibrary
>  # define LoadLibrary LoadLibraryA
>
> -# if !(_WIN32_WINNT >= _WIN32_WINNT_WIN8)
> +# if (_WIN32_WINNT >= _WIN32_WINNT_WIN8)
>
>  /* Avoid warnings from gcc -Wcast-function-type.  */
>  #  define GetProcAddress \
>

Oops looks like it might be more like the following. Thanks.

diff --git a/lib/gettimeofday.c b/lib/gettimeofday.c
index 36c7920af..fdc236883 100644
--- a/lib/gettimeofday.c
+++ b/lib/gettimeofday.c
@@ -35,7 +35,7 @@
 # undef LoadLibrary
 # define LoadLibrary LoadLibraryA

-# if !(_WIN32_WINNT >= _WIN32_WINNT_WIN8)
+# if (_WIN32_WINNT >= _WIN32_WINNT_WIN8)

 /* Avoid warnings from gcc -Wcast-function-type.  */
 #  define GetProcAddress \
@@ -94,7 +94,7 @@ gettimeofday (struct timeval *restrict tv, void *restrict
tz)
      <http://www.windowstimestamp.com/description>.  */
   FILETIME current_time;

-# if !(_WIN32_WINNT >= _WIN32_WINNT_WIN8)
+# if (_WIN32_WINNT >= _WIN32_WINNT_WIN8)
   if (!initialized)
     initialize ();
 # endif

[-- Attachment #2: Type: text/html, Size: 2878 bytes --]

  reply	other threads:[~2022-12-11 13:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  6:01 gettimeofday.c windows version? Roger Pack
2022-12-11  7:05 ` Roger Pack [this message]
2022-12-11 14:22 ` Bruno Haible
2022-12-11 15:09   ` Eli Zaretskii
2022-12-11 16:20     ` Bruno Haible
2022-12-11 16:56       ` Eli Zaretskii
2022-12-11 17:25         ` Eli Zaretskii
2022-12-11 18:25           ` Bruno Haible
2022-12-11 18:55             ` Eli Zaretskii
2022-12-12  7:17               ` Paul Eggert
2022-12-12 12:19                 ` Bruno Haible
2022-12-12 13:06                 ` Eli Zaretskii
2022-12-12 14:25                   ` Bruno Haible
2022-12-12 14:40                     ` Eli Zaretskii
2022-12-12 19:44                       ` Paul Eggert
2022-12-12 20:37                         ` Eli Zaretskii
2022-12-16 23:35                           ` Paul Eggert
2022-12-17  8:09                             ` Eli Zaretskii
2022-12-12 19:14                     ` Gisle Vanem
2022-12-23  8:38   ` Roger Pack
2022-12-23  8:46     ` Eli Zaretskii
2022-12-23 23:47     ` Paul Eggert
2022-12-24  6:46       ` Eli Zaretskii
2022-12-24  7:42         ` Paul Eggert
2022-12-24  8:34           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPfeOnu0bW=BhgKgusPxbESfzYEdyGnFGjN+=izP7R4gyKvz2g@mail.gmail.com' \
    --to=rogerdpack@gmail.com \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).