From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E38D91F4B5 for ; Mon, 18 Nov 2019 22:39:23 +0000 (UTC) Received: from localhost ([::1]:40226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWpg2-000895-HB for normalperson@yhbt.net; Mon, 18 Nov 2019 17:39:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46305) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWpft-00087e-46 for bug-gnulib@gnu.org; Mon, 18 Nov 2019 17:39:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWpfr-0004ZS-Tj for bug-gnulib@gnu.org; Mon, 18 Nov 2019 17:39:12 -0500 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]:34656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWpfr-0004XZ-NY for bug-gnulib@gnu.org; Mon, 18 Nov 2019 17:39:11 -0500 Received: by mail-oi1-x242.google.com with SMTP id l202so16999527oig.1 for ; Mon, 18 Nov 2019 14:39:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W56GzCvBEtLEuIK44N5CRkM4FCMJQMbadeF3/LcnPF0=; b=insSOFB5ExUPSM9uf+ZwKQGyh/CYuHXue/egYXCySRj7QI7jZlKHevo8D2C1v4vNOr qPvhFTMqdCe5xPXeXhdq/yOh6Ekb/s42xpYD93h4NBfPo/cPkGTcqNMSCsvbfyqpxv/x aqkXYXaqUTkJDOmp2TnnXTrQU14nMfuIdel3ruLc6bn9ZW/Jrj06J533iC5r8h4gYIl7 AXsb9SixGdOWApCI7Z7mgAjOoGf3PXR0SaQI9n0Yo88puenHAOXsFImdO9jbzbZU51Je ps4vcQVL5Ht5WlkuxfZJly35/StVZa2+TDFs8tg3/wS1u/U5fTW54RDO+1O3/uhYgF1q ZA3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W56GzCvBEtLEuIK44N5CRkM4FCMJQMbadeF3/LcnPF0=; b=YW5Kj5KInz1AeS9iaf859rlPmgHbmu9QA9MD/lEvJd2RPAc5+hjSceggTV3URZVw2T HkJirf2EnBgyO0OUglu24IZpE9c/xHvGvJwSK8/haLR+PGI3GjmyE+ql5ATPWtEB3baw sXeFo5G1ov4v+umzVHvVzNieZxVWVs6KODAatAJNx+J4xHbW6q00ojkoaOlsDdPEqHTy RmCYdhaRfXRRrln+A5FexGiLt8z9QoNJSbckQbucR9q0z26urfDt8Yj1jYj1smddqKRW BPr7neBwN5R3ObD0Fx83RW/3P3TPjDSyAgm0flU0REGGU1CriZw8td9quPU8Lq4k56f6 62rA== X-Gm-Message-State: APjAAAXzI2dJcBcjFV16UNf0zMnCZEACcSscFkHmw1pf66aeR4zVbjbw euDOb98b43QmDF9BlYjGoWOVK1/sWLgJ/EVWZgpNujte X-Google-Smtp-Source: APXvYqwWZTddDSm9Ms88tp3doKe2QMPRozn1Zj9LtTGwo9wqgtGJhFwydZzBoLwCVukKPHF7g2raVu9GOrRzv0cO7vo= X-Received: by 2002:aca:f40e:: with SMTP id s14mr1185899oih.116.1574116749535; Mon, 18 Nov 2019 14:39:09 -0800 (PST) MIME-Version: 1.0 References: <20191118214505.211353-1-cbiesinger@google.com> <6350506.kqJPLEPMWm@omega> In-Reply-To: <6350506.kqJPLEPMWm@omega> From: Christian Biesinger Date: Mon, 18 Nov 2019 16:38:33 -0600 Message-ID: Subject: Re: [PATCH] Don't use $(CC) for the -std=gnu11 flag To: Bruno Haible Cc: bug-gnulib@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::242 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On Mon, Nov 18, 2019 at 4:15 PM Bruno Haible wrote: > > Hi Christian, > > This patch is not good. In a package where some subdirectories > use automake and gnulib and other subdirectories don't use Automake, > it will have the effect that some subdirectories are compiled with > -std=gnu11 and some without. This is a recipe for hassles. > > One such package is GNU libiconv; there probably are others. > > > Currently, the std-gnu11 module uses $(CC) to store the > > compiler flag to enable C11. This has the downside that > > if someone uses make CC=foo, the flag will be overridden. > > A user is not supposed to use > make CC=some-other-compiler > > This works only with packages which don't use autoconfiguration; > it does not work with gnulib (which has tons of autoconf tests > whose results depend on $CC). OK, thanks for the explanation. I will instead fix the GDB build system to not override $(CC). Christian