From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8CF551F5A0 for ; Fri, 10 Feb 2023 14:11:57 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=sc3d.org header.i=@sc3d.org header.a=rsa-sha256 header.s=google header.b=phqwJVxZ; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQU7z-00083K-DH; Fri, 10 Feb 2023 09:11:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQU7x-00082n-GK for bug-gnulib@gnu.org; Fri, 10 Feb 2023 09:11:49 -0500 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQU7v-0005hi-DM for bug-gnulib@gnu.org; Fri, 10 Feb 2023 09:11:49 -0500 Received: by mail-ej1-x62c.google.com with SMTP id rp23so16153471ejb.7 for ; Fri, 10 Feb 2023 06:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YPYu0HeO7iUxJAGZ5WCDPTpY/EE7dd7OFI9oA3HHU5w=; b=phqwJVxZNNodDNCwR1r+yUcbMSEfen0iTmRCLVFAeff7NG9cKd2mm+/2UJz/qdh1H9 Y3JYE/0kGFVnPyEUICKW3U/aN92uAcmDFalbvNwjDRAj41iokRYUMnbU9bMRUhvNJZ7X FRyRcyUAwrsvp9A3nRglhvTr7erNNO28sLX0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YPYu0HeO7iUxJAGZ5WCDPTpY/EE7dd7OFI9oA3HHU5w=; b=BZ0idiFu+OcDwA4CWWd4fASH0Zy5yj6Gv0rI1ki7Da/RIWgNSTeBCall0E+5HcCpL0 K6+uUHCQqbGvk03ii+ETO0E3MiUdERCFT+XKIxrgC4wN0Zoo0GA0No1vnTZ1S4jfsu3x m15cQAeGGkAEFGm0rpWTW/mJvoUrM7l9R1rFCsjom0Ppz9SzVfgDAeg/NsnrDXCXXtJc ukAwxUovV+RpQEn75219J27/sfI36pyLZeQouSy9BIF/sJye8U8CT6sPrN85ADCeYlXp 1YEib8F1S3Hus6thOkE4zsJwYccSv791jwZgcfeWL0xMz3+YA3EdRS59gQSiQHVEyybo bSkg== X-Gm-Message-State: AO0yUKWHX/YuJWMd7hwvTm4rGsEk8hP2AcRB0S7DBcB1hbMntH/TJxmc 7Vn3pINrHLKEv4WSVanJYjHSUaMP5St7Ni6wZc7S1g== X-Google-Smtp-Source: AK7set/CygdSBxFBKRMHw8qYCYDaflt5qYYRR9yzfcdUlcapGVydG1man+a5sx78JTbmn8Msxn/+X4MA9S9FF078R0g= X-Received: by 2002:a17:906:858a:b0:87b:dae9:a1e4 with SMTP id v10-20020a170906858a00b0087bdae9a1e4mr3129189ejx.48.1676038304646; Fri, 10 Feb 2023 06:11:44 -0800 (PST) MIME-Version: 1.0 References: <20230205194344.269174-1-vinschen@redhat.com> <3384697.1Xququ8Bcc@nimes> <3099885.Repjz8aVax@nimes> In-Reply-To: From: Reuben Thomas Date: Fri, 10 Feb 2023 14:11:32 +0000 Message-ID: Subject: Re: [PATCH] Do not decorate symbols as dllexport on Cygwin To: Corinna Vinschen Cc: Bruno Haible , bug-gnulib@gnu.org Content-Type: multipart/alternative; boundary="000000000000c75b6b05f4591366" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=rrt@sc3d.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org --000000000000c75b6b05f4591366 Content-Type: text/plain; charset="UTF-8" On Tue, 7 Feb 2023 at 15:22, Corinna Vinschen wrote: > In Cygwin projects using libtool, we always have to add -no-undefined > iLDFLAGS. This is some old safe-guard in libtool to remind developers > that when creating Windows DLLs, all external symbols must be resolved. > > Fortunately, libtool allows this flags also on other platforms which > don't require its usage. > > Patch is attached. It would be nice if that's ok for inclusion. I did apply this patch, but just noticed that it broke the Mingwin build; see: https://github.com/rrthomas/recode/actions/runs/4115515520/jobs/7104330023 I haven't had time to look into it yet; help welcome! -- https://rrt.sc3d.org --000000000000c75b6b05f4591366 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 7 Feb 2023 at = 15:22, Corinna Vinschen <vinschen= @redhat.com> wrote:
In Cygwin projects using libtoo= l, we always have to add -no-undefined
iLDFLAGS.=C2=A0 This is some old safe-guard in libtool to remind developers=
that when creating Windows DLLs, all external symbols must be resolved.

Fortunately, libtool allows this flags also on other platforms which
don't require its usage.

Patch is attached.=C2=A0 It would be nice if that's ok for inclusion.

I did apply this patch, b= ut just noticed that it broke the Mingwin build; see:

https://github.com/rrthom= as/recode/actions/runs/4115515520/jobs/7104330023

I haven't had time to look into it yet;= help welcome!
=C2=A0
--
--000000000000c75b6b05f4591366--