From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 145041F5A0 for ; Sat, 11 Feb 2023 11:36:58 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=sc3d.org header.i=@sc3d.org header.a=rsa-sha256 header.s=google header.b=KAF58Dzf; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQoBU-0003Jl-T2; Sat, 11 Feb 2023 06:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQoBU-0003JO-1C for bug-gnulib@gnu.org; Sat, 11 Feb 2023 06:36:48 -0500 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQoBR-0000AJ-TB for bug-gnulib@gnu.org; Sat, 11 Feb 2023 06:36:47 -0500 Received: by mail-ej1-x631.google.com with SMTP id hx15so21656876ejc.11 for ; Sat, 11 Feb 2023 03:36:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=G4deKQglwHbZuROQHGQhAb0eQiCdSZWcaCTwKG0mF1Y=; b=KAF58DzfO0Bkys5jzYbOWZEnYHvh2jCLbBEOFL4qsfMTSMguHawt05QNVq8A1PDT3u WzzOUxsBMAXLlxdlx1zXJpLlbkY7div+mFUwkLDPSFuJaJHbYEakWFmLDWlgXNmNUPOf mhEmB++l9AmY/klws4fRlMmfwFfefdPrpgF88= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G4deKQglwHbZuROQHGQhAb0eQiCdSZWcaCTwKG0mF1Y=; b=rCZ1ncy8fxvr8N5Zd3ADhFT8RyNvBz/JIfwg4AFgEwp/J5nXO8J2YToPEy4xarHyX/ iC9m76/OInNCE3YiyllWRrqfiCieDywkSq23+lDAqILEKxyc0/dxn11qnEwS1nrk+e+k GUi1uonse/Lbx6shvJysX9lTwlomMYTe4Gc3PY1NVFK9nUg4QiSokYMobURRjvd7veRG FJ8O8aD6IsubalnUwvf0wAz0pWPGP1kRbV80kMie3s7Lg7Y7l1amQGOxIF2vgFlwzG4A Sm2kLbw0/SXEgCqLf1Vhh0Nlo3I9eVlqhOAvQ/AXMFIyNTTAUXrLWeIWtS1X8ZzgMGC3 fMVA== X-Gm-Message-State: AO0yUKUwaTyoIK7aMCs7mdjk+zQ34jNU5SQj7VCV1l6YF1jrEmsdt7Vi 10rhtimR99+XHgLNGAUrux9gjAl8DCxTVAptyzOH1Q== X-Google-Smtp-Source: AK7set/3sxTc+9PH/3A4yb6v7B1ftcGXp8bmHUovdCZL1SO1wx858+i2C05dJeuIGnga+Eoy3oPgnWmk198HdyzLLYI= X-Received: by 2002:a17:907:8a19:b0:88d:ba79:4317 with SMTP id sc25-20020a1709078a1900b0088dba794317mr2742423ejc.7.1676115403782; Sat, 11 Feb 2023 03:36:43 -0800 (PST) MIME-Version: 1.0 References: <20230205194344.269174-1-vinschen@redhat.com> <3192712.XEUel18Ref@nimes> In-Reply-To: <3192712.XEUel18Ref@nimes> From: Reuben Thomas Date: Sat, 11 Feb 2023 11:36:31 +0000 Message-ID: Subject: Re: [PATCH] Do not decorate symbols as dllexport on Cygwin To: Bruno Haible Cc: Corinna Vinschen , bug-gnulib@gnu.org Content-Type: multipart/alternative; boundary="0000000000003ecfe605f46b0727" Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=rrt@sc3d.org; helo=mail-ej1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org --0000000000003ecfe605f46b0727 Content-Type: text/plain; charset="UTF-8" On Fri, 10 Feb 2023 at 14:21, Bruno Haible wrote: > It complains about the symbols defined in libiconv. This means, you need > to invoke the Gnulib module 'iconv' and add $(LIBICONV) or $(LTLIBICONV) > to the LDFLAGS. > Bruno to the rescue again! Many thanks. Having added the iconv gnulib module, the Windows build works, but the tests, which use a Cython module, are now broken. The actual error is: Traceback (most recent call last): File "D:\a\recode\recode\tests\pytest", line 135, in main module = __import__(base[:-3]) File "D:/a/recode/recode/tests/./t21_names.py", line 2, in import common File "D:/a/recode/recode/tests/./common.py", line 10, in import Recode ImportError: DLL load failed while importing Recode: The specified module could not be found. I assume that the "DLL load failed" indicates a link error. Obviously my first thought was that something extra was needed for iconv; however, this appears already to be covered (in setup.py.in). I add LIBICONV there to the "extra_libs" argument. I had a look at the way the Python extension is compiled and compared it with the last Windows build that passed, and they seem to be identical; in both, libiconv.dll.a is added to the link line by cython. Compare the working version: https://github.com/rrthomas/recode/actions/runs/4115503607/jobs/7104302788#step:9:2302 to the non-working: https://github.com/rrthomas/recode/actions/runs/4150792693/jobs/7180677411#step:9:2306 They appear to be identical. Is there some other casualty (other than iconv) of -no-undefined here? I've just booted up my Windows VM to have a look myself, but, aside from it being extremely slow, I would again welcome any insights you might have! -- https://rrt.sc3d.org --0000000000003ecfe605f46b0727 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, 10 Feb 2023 at 14:21, Bruno Haible <bruno@clisp.org> wrote:
It complains about the symbo= ls defined in libiconv. This means, you need
to invoke the Gnulib module 'iconv' and add $(LIBICONV) or $(LTLIBI= CONV)
to the LDFLAGS.

Bruno to = the rescue again! Many thanks.

Having added the iconv gnulib module, the Windows build works, but= the tests, which use a Cython module, are now broken. The actual error is:=

Traceback= (most recent call last):
File "D:\a\recode\recode\tests\pytest", line 13= 5, in main
module =3D __import__(base[:-3])
File "D:/a/recode/recode/tests/./t21_names.py",= line 2, in <module>
import common
File "D:/a/recode/recode/tests/./common.py", li= ne 10, in <module>
import Recode
ImportError: DLL load failed while importing Recode: The sp= ecified module could not be found.

=
I assume that the "DLL load failed" indic= ates a link error. Obviously my first thought was that something extra was = needed for iconv; however, this appears already to be covered (in setup.py.in). I add LIBICONV = there to the "extra_libs" argument. I had a look at the way the P= ython extension is compiled and compared it with the last Windows build tha= t passed, and they seem to be identical; in both, libiconv.dll.a is added t= o the link line by cython.

Compare the working version: https://github.com/rrthomas/recode/actions/runs/4115503607/jobs/7104302788= #step:9:2302
to the non-working: https://github.com/rrthomas/recode/actions/runs= /4150792693/jobs/7180677411#step:9:2306

They appear to be identical.

Is there some other casualty (other than iconv) of -no-unde= fined here?

I've j= ust booted up my Windows VM to have a look myself, but, aside from it being= extremely slow, I would again welcome any insights you might have!

--
--0000000000003ecfe605f46b0727--