From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.0.0.0/16 X-Spam-Status: No, score=-2.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, SPF_SOFTFAIL shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XQRUt-0004YK-UO for mharc-bug-gnulib@gnu.org; Sat, 06 Sep 2014 21:42:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQRUr-0004YC-4s for bug-gnulib@gnu.org; Sat, 06 Sep 2014 21:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQRUp-0007yU-U4 for bug-gnulib@gnu.org; Sat, 06 Sep 2014 21:42:29 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:47019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQRUp-0007yF-Jf for bug-gnulib@gnu.org; Sat, 06 Sep 2014 21:42:27 -0400 Received: by mail-we0-f174.google.com with SMTP id w61so1921545wes.5 for ; Sat, 06 Sep 2014 18:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WwzNiUkIpLzkjSCIk7atcPpjQgQROrVdfAlZ+iuPkyA=; b=LWiBlva5PZYdlU/RU0gEvreL8khbqZ9YhLxtZN4KzWBBx4UhpPoRPnXA7eLvJmf3Vp zbG3WIvqMXVh6yWIRvXPLqkyHau0WfXJZec+AdYK79KOOBysvt4faRfP6vQwP6bsovN2 UGlnjrOy2QlmJaWk0NGp8VrGjYq1RhWJLYcLw86DZuv24hgNDMeLEuYmhWDbjSoZxmV6 i05sx4WcpfpWv3VCHjttDPLE95rKj5gtY/ntdxvkZgDzEaGCu1+1BAZMcQl9X5lqleRM 9QV+IP+I5nHlztCHZSoMjebmXCTxMoHxJP7tXt2pCmSBN/0tkrG35oeDq5EgKtDiE2w5 U2UQ== MIME-Version: 1.0 X-Received: by 10.180.205.234 with SMTP id lj10mr13265040wic.1.1410054145630; Sat, 06 Sep 2014 18:42:25 -0700 (PDT) Received: by 10.194.246.36 with HTTP; Sat, 6 Sep 2014 18:42:25 -0700 (PDT) In-Reply-To: <540BA72D.1000904@cs.ucla.edu> References: <5409DBEA.8010006@cs.ucla.edu> <540BA72D.1000904@cs.ucla.edu> Date: Sat, 6 Sep 2014 20:42:25 -0500 Message-ID: Subject: Re: compile warnings when including avltree-list and gcc-warnings is enabled From: Dylan Cali To: Paul Eggert Content-Type: multipart/mixed; boundary=001a11c268ca76fc8f05026fd0bc X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22e Cc: bug-gnulib@gnu.org X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 01:42:30 -0000 --001a11c268ca76fc8f05026fd0bc Content-Type: text/plain; charset=UTF-8 On Sat, Sep 6, 2014 at 7:30 PM, Paul Eggert wrote: > On second thought this doesn't look wise, as the function is not expected to > be exported to ordinary clients, only to the test cases. So let's leave the > .h file alone, and put a declaration in the .c file instead. > > I suppose a pragma is the way to silence the unwanted diagnostics, yes. Updated patch attached. I moved the declaration to the .c file and added the warning suppression for just that function. Everything builds without issue now. --001a11c268ca76fc8f05026fd0bc Content-Type: text/x-patch; charset=US-ASCII; name="fix-gcc-warnings.patch" Content-Disposition: attachment; filename="fix-gcc-warnings.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hzrpuaku0 RnJvbSBkOGY2NDQ5ZDY5NDAxYTgyMGM0YjNmNWQ0NWNlZThjODcwNjM2MThjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEeWxhbiBDYWxpIDxjYWxpZDE5ODRAZ21haWwuY29tPgpEYXRl OiBTYXQsIDYgU2VwIDIwMTQgMDE6NTI6MzEgLTA1MDAKU3ViamVjdDogW1BBVENIXSBidWlsZDog Zml4IGdjYyB3YXJuaW5ncwoKKiB0ZXN0cy90ZXN0LWF2bHRyZWVfbGlzdC5jOiBSZW1vdmUgZ2xf YXZsdHJlZV9saXN0X2NoZWNrX2ludmFyaWFudHMKZGVjbGFyYXRpb24KKiBsaWIvZ2xfYXZsdHJl ZV9saXN0LmM6IEFkZCBnbF9hdmx0cmVlX2xpc3RfY2hlY2tfaW52YXJpYW50cwpkZWNsYXJhdGlv biBmcm9tIHRlc3QtYXZsdHJlZV9saXN0LmMuIEZpeGVzIGdjYyB3YXJuaW5nIGFib3V0IG1pc3Np bmcKZGVjbGFyYXRpb24uCiogbGliL2dsX2F2bHRyZWVfbGlzdC5jOiAoY2hlY2tfaW52YXJpYW50 cyk6IEFkZCBwdXJlIGF0dHJpYnV0ZS4KKGdsX2F2bHRyZWVfbGlzdF9jaGVja19pbnZhcmlhbnRz KTogQWRkIGNvbnN0IGF0dHJpYnV0ZS4gQWxzbyB1c2UgYSBnY2MKcHJhZ21hIHRvIGlnbm9yZSBh IGZhbHNlIHBvc2l0aXZlIHdhcm5pbmcgYWJvdXQgY2hlY2tfaW52YXJpYW50cyBiZWluZyBhCnN0 YXRlbWVudCB3aXRoIG5vIGVmZmVjdC4KKiBsaWIvZ2xfYW55dHJlZV9saXN0Mi5oOiBBZGQgcHVy ZSBhdHRyaWJ1dGUgdG8gKGdsX3RyZWVfbm9kZV92YWx1ZSksCihnbF90cmVlX25leHRfbm9kZSks IChnbF90cmVlX3ByZXZpb3VzX25vZGUpLCAobm9kZV9hdCksCihnbF90cmVlX2dldF9hdCkKLS0t CiBsaWIvZ2xfYW55dHJlZV9saXN0Mi5oICAgIHwgMTAgKysrKystLS0tLQogbGliL2dsX2F2bHRy ZWVfbGlzdC5jICAgICB8IDE0ICsrKysrKysrKysrKy0tCiB0ZXN0cy90ZXN0LWF2bHRyZWVfbGlz dC5jIHwgIDIgLS0KIDMgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9saWIvZ2xfYW55dHJlZV9saXN0Mi5oIGIvbGliL2dsX2FueXRy ZWVfbGlzdDIuaAppbmRleCA3MGU1OWE1Li4wNWZkZTE1IDEwMDY0NAotLS0gYS9saWIvZ2xfYW55 dHJlZV9saXN0Mi5oCisrKyBiL2xpYi9nbF9hbnl0cmVlX2xpc3QyLmgKQEAgLTU5LDcgKzU5LDcg QEAgZ2xfdHJlZV9zaXplIChnbF9saXN0X3QgbGlzdCkKICAgcmV0dXJuIChsaXN0LT5yb290ICE9 IE5VTEwgPyBsaXN0LT5yb290LT5icmFuY2hfc2l6ZSA6IDApOwogfQogCi1zdGF0aWMgY29uc3Qg dm9pZCAqCitzdGF0aWMgY29uc3Qgdm9pZCAqIF9HTF9BVFRSSUJVVEVfUFVSRQogZ2xfdHJlZV9u b2RlX3ZhbHVlIChnbF9saXN0X3QgbGlzdCwgZ2xfbGlzdF9ub2RlX3Qgbm9kZSkKIHsKICAgcmV0 dXJuIG5vZGUtPnZhbHVlOwpAQCAtMTAwLDcgKzEwMCw3IEBAIGdsX3RyZWVfbm9kZV9ueF9zZXRf dmFsdWUgKGdsX2xpc3RfdCBsaXN0LCBnbF9saXN0X25vZGVfdCBub2RlLCBjb25zdCB2b2lkICpl bHQpCiAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgZ2xfbGlzdF9ub2RlX3QKK3N0YXRpYyBnbF9s aXN0X25vZGVfdCBfR0xfQVRUUklCVVRFX1BVUkUKIGdsX3RyZWVfbmV4dF9ub2RlIChnbF9saXN0 X3QgbGlzdCwgZ2xfbGlzdF9ub2RlX3Qgbm9kZSkKIHsKICAgaWYgKG5vZGUtPnJpZ2h0ICE9IE5V TEwpCkBAIC0xMTgsNyArMTE4LDcgQEAgZ2xfdHJlZV9uZXh0X25vZGUgKGdsX2xpc3RfdCBsaXN0 LCBnbF9saXN0X25vZGVfdCBub2RlKQogICByZXR1cm4gbm9kZTsKIH0KIAotc3RhdGljIGdsX2xp c3Rfbm9kZV90CitzdGF0aWMgZ2xfbGlzdF9ub2RlX3QgX0dMX0FUVFJJQlVURV9QVVJFCiBnbF90 cmVlX3ByZXZpb3VzX25vZGUgKGdsX2xpc3RfdCBsaXN0LCBnbF9saXN0X25vZGVfdCBub2RlKQog ewogICBpZiAobm9kZS0+bGVmdCAhPSBOVUxMKQpAQCAtMTM3LDcgKzEzNyw3IEBAIGdsX3RyZWVf cHJldmlvdXNfbm9kZSAoZ2xfbGlzdF90IGxpc3QsIGdsX2xpc3Rfbm9kZV90IG5vZGUpCiB9CiAK IC8qIFJldHVybiB0aGUgbm9kZSBhdCB0aGUgZ2l2ZW4gcG9zaXRpb24gPCBnbF90cmVlX3NpemUg KGxpc3QpLiAgKi8KLXN0YXRpYyBnbF9saXN0X25vZGVfdAorc3RhdGljIGdsX2xpc3Rfbm9kZV90 IF9HTF9BVFRSSUJVVEVfUFVSRQogbm9kZV9hdCAoZ2xfbGlzdF9ub2RlX3Qgcm9vdCwgc2l6ZV90 IHBvc2l0aW9uKQogewogICAvKiBIZXJlIHdlIGtub3cgdGhhdCByb290ICE9IE5VTEwuICAqLwpA QCAtMTYyLDcgKzE2Miw3IEBAIG5vZGVfYXQgKGdsX2xpc3Rfbm9kZV90IHJvb3QsIHNpemVfdCBw b3NpdGlvbikKICAgcmV0dXJuIG5vZGU7CiB9CiAKLXN0YXRpYyBjb25zdCB2b2lkICoKK3N0YXRp YyBjb25zdCB2b2lkICogX0dMX0FUVFJJQlVURV9QVVJFCiBnbF90cmVlX2dldF9hdCAoZ2xfbGlz dF90IGxpc3QsIHNpemVfdCBwb3NpdGlvbikKIHsKICAgZ2xfbGlzdF9ub2RlX3Qgbm9kZSA9IGxp c3QtPnJvb3Q7CmRpZmYgLS1naXQgYS9saWIvZ2xfYXZsdHJlZV9saXN0LmMgYi9saWIvZ2xfYXZs dHJlZV9saXN0LmMKaW5kZXggMWFmZTVjYS4uOWM0MDhhYyAxMDA2NDQKLS0tIGEvbGliL2dsX2F2 bHRyZWVfbGlzdC5jCisrKyBiL2xpYi9nbF9hdmx0cmVlX2xpc3QuYwpAQCAtMzYsOCArMzYsMTAg QEAKIC8qIEdlbmVyaWMgYmluYXJ5IHRyZWUgY29kZS4gICovCiAjaW5jbHVkZSAiZ2xfYW55dHJl ZV9saXN0Mi5oIgogCitleHRlcm4gdm9pZCBnbF9hdmx0cmVlX2xpc3RfY2hlY2tfaW52YXJpYW50 cyAoZ2xfbGlzdF90IGxpc3QpOworCiAvKiBGb3IgZGVidWdnaW5nLiAgKi8KLXN0YXRpYyB1bnNp Z25lZCBpbnQKK3N0YXRpYyB1bnNpZ25lZCBpbnQgX0dMX0FUVFJJQlVURV9QVVJFCiBjaGVja19p bnZhcmlhbnRzIChnbF9saXN0X25vZGVfdCBub2RlLCBnbF9saXN0X25vZGVfdCBwYXJlbnQpCiB7 CiAgIHVuc2lnbmVkIGludCBsZWZ0X2hlaWdodCA9CkBAIC01OSwxMyArNjEsMjEgQEAgY2hlY2tf aW52YXJpYW50cyAoZ2xfbGlzdF9ub2RlX3Qgbm9kZSwgZ2xfbGlzdF9ub2RlX3QgcGFyZW50KQog CiAgIHJldHVybiAxICsgKGxlZnRfaGVpZ2h0ID4gcmlnaHRfaGVpZ2h0ID8gbGVmdF9oZWlnaHQg OiByaWdodF9oZWlnaHQpOwogfQotdm9pZAorCisvKiBHQ0Mgd2FybnMgdGhhdCBjaGVja19pbnZh cmlhbnRzIGhhcyBubyBlZmZlY3QsIGJ1dCBpdCBkb2VzLiBJZ25vcmUKKyAgIHRoZSBmYWxzZSBw b3NpdGl2ZS4gKi8KKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBHQ0MgZGlh Z25vc3RpYyBpZ25vcmVkICItV3VudXNlZC12YWx1ZSIKKwordm9pZCBfR0xfQVRUUklCVVRFX0NP TlNUCiBnbF9hdmx0cmVlX2xpc3RfY2hlY2tfaW52YXJpYW50cyAoZ2xfbGlzdF90IGxpc3QpCiB7 CiAgIGlmIChsaXN0LT5yb290ICE9IE5VTEwpCiAgICAgY2hlY2tfaW52YXJpYW50cyAobGlzdC0+ cm9vdCwgTlVMTCk7CiB9CiAKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcG9wCisKIGNvbnN0IHN0 cnVjdCBnbF9saXN0X2ltcGxlbWVudGF0aW9uIGdsX2F2bHRyZWVfbGlzdF9pbXBsZW1lbnRhdGlv biA9CiAgIHsKICAgICBnbF90cmVlX254X2NyZWF0ZV9lbXB0eSwKZGlmZiAtLWdpdCBhL3Rlc3Rz L3Rlc3QtYXZsdHJlZV9saXN0LmMgYi90ZXN0cy90ZXN0LWF2bHRyZWVfbGlzdC5jCmluZGV4IDFj MDMzMWEuLmM4NzdjMDkgMTAwNjQ0Ci0tLSBhL3Rlc3RzL3Rlc3QtYXZsdHJlZV9saXN0LmMKKysr IGIvdGVzdHMvdGVzdC1hdmx0cmVlX2xpc3QuYwpAQCAtMjUsOCArMjUsNiBAQAogI2luY2x1ZGUg InByb2duYW1lLmgiCiAjaW5jbHVkZSAibWFjcm9zLmgiCiAKLWV4dGVybiB2b2lkIGdsX2F2bHRy ZWVfbGlzdF9jaGVja19pbnZhcmlhbnRzIChnbF9saXN0X3QgbGlzdCk7Ci0KIHN0YXRpYyBjb25z dCBjaGFyICpvYmplY3RzWzE1XSA9CiAgIHsKICAgICAiYSIsICJiIiwgImMiLCAiZCIsICJlIiwg ImYiLCAiZyIsICJoIiwgImkiLCAiaiIsICJrIiwgImwiLCAibSIsICJuIiwgIm8iCi0tIAoyLjEu MAoK --001a11c268ca76fc8f05026fd0bc--